DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ashwin Sekhar T K <asekhar@marvell.com>, <dev@dpdk.org>,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
	"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>
Cc: <ndabilpuram@marvell.com>, <jerinj@marvell.com>,
	<skori@marvell.com>, <skoteshwar@marvell.com>,
	<pbhagavatula@marvell.com>, <kirankumark@marvell.com>,
	<psatheesh@marvell.com>, <anoobj@marvell.com>,
	<gakhil@marvell.com>
Subject: Re: [PATCH] common/cnxk: use cas with release semantics for batch alloc
Date: Tue, 11 Jan 2022 12:12:05 +0000	[thread overview]
Message-ID: <ce249517-4c44-d77a-0b1d-a170875fc1a8@intel.com> (raw)
In-Reply-To: <2f82681c-e615-8e3b-4548-58bcffc0ec8e@intel.com>

On 1/11/2022 12:08 PM, Ferruh Yigit wrote:
> On 11/30/2021 5:45 AM, Ashwin Sekhar T K wrote:
>> Before issuing the batch alloc, we clear the first word of
>> cache lines so that NPA can update the status. Make sure that
>> this line clear is flushed before the batch alloc is issued.
>>
>> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>> ---
>>   drivers/common/cnxk/roc_io.h         | 12 ++++++++++++
>>   drivers/common/cnxk/roc_io_generic.h |  9 +++++++++
>>   drivers/common/cnxk/roc_npa.h        |  2 +-
>>   3 files changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h
>> index fe5f7f46d0..4f15503c29 100644
>> --- a/drivers/common/cnxk/roc_io.h
>> +++ b/drivers/common/cnxk/roc_io.h
>> @@ -78,6 +78,18 @@ roc_atomic64_cas(uint64_t compare, uint64_t swap, int64_t *ptr)
>>       return compare;
>>   }
>> +static __plt_always_inline uint64_t
>> +roc_atomic64_casl(uint64_t compare, uint64_t swap, int64_t *ptr)
>> +{
>> +    asm volatile(PLT_CPU_FEATURE_PREAMBLE
>> +             "casl %[compare], %[swap], [%[ptr]]\n"
>> +             : [compare] "+r"(compare)
>> +             : [swap] "r"(swap), [ptr] "r"(ptr)
>> +             : "memory");
>> +
> 
> out of curiosity, what is the "cas with release semantics"?
> briefly, what is the difference between 'cas' and 'casl'?

+ Honnappa & Ruifeng,

Isn't this API Arm wide, instead of being cnxk specific?
Does it make sense to make this API for arm and cnxk use from there?

  reply	other threads:[~2022-01-11 12:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  5:45 Ashwin Sekhar T K
2022-01-06 12:27 ` Jerin Jacob
2022-01-11 12:08 ` Ferruh Yigit
2022-01-11 12:12   ` Ferruh Yigit [this message]
2022-01-11 12:26     ` [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
2022-01-11 13:46       ` Ferruh Yigit
2022-01-12  3:01         ` Ruifeng Wang
2022-01-12  6:18           ` Ruifeng Wang
2022-01-12  9:20             ` Ferruh Yigit
2022-01-12  9:21           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce249517-4c44-d77a-0b1d-a170875fc1a8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=anoobj@marvell.com \
    --cc=asekhar@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=psatheesh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).