From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 04323A2EDB
	for <public@inbox.dpdk.org>; Fri,  6 Sep 2019 13:51:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1E00A1F2BA;
	Fri,  6 Sep 2019 13:51:37 +0200 (CEST)
Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32])
 by dpdk.org (Postfix) with ESMTP id 82C5A1F299
 for <dev@dpdk.org>; Fri,  6 Sep 2019 13:51:35 +0200 (CEST)
Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])
 by Forcepoint Email with ESMTP id E9BD070D82F832BA34C5;
 Fri,  6 Sep 2019 19:51:33 +0800 (CST)
Received: from [127.0.0.1] (10.57.115.182) by DGGEMS412-HUB.china.huawei.com
 (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Fri, 6 Sep 2019
 19:51:26 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>
 <1566568031-45991-17-git-send-email-xavier.huwei@huawei.com>
 <83ac15f1-c212-9965-3cbe-f053b47567d8@intel.com>
CC: <linuxarm@huawei.com>, <xavier_huwei@163.com>, <liudongdong3@huawei.com>, 
 <forest.zhouchang@huawei.com>
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Message-ID: <ce2da07a-7a06-d5f7-fe26-d460155cfc78@huawei.com>
Date: Fri, 6 Sep 2019 19:51:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <83ac15f1-c212-9965-3cbe-f053b47567d8@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.57.115.182]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure
 promiscuous ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh Yigit


On 2019/8/30 23:14, Ferruh Yigit wrote:
> On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
>> This patch adds dev_start, dev_stop, dev_configure, promiscuous_enable,
>> promiscuous_disable, allmulticast_enable, allmulticast_disable,
>> dev_infos_get related function codes.
>>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> <...>
>
>> @@ -3626,6 +4031,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {
>>  	.vlan_offload_set       = hns3_vlan_offload_set,
>>  	.vlan_pvid_set          = hns3_vlan_pvid_set,
>>  	.get_dcb_info           = hns3_get_dcb_info,
>> +	.dev_supported_ptypes_get = hns3_dev_supported_ptypes_get,
> 'hns3_dev_supported_ptypes_get' has been defined in previous patch, what do you
> thinks defining and using in same patch?
    We will fix it in patch V2.
    Thanks for your suggestion.

    Regards
Xavier
>