From: David Christensen <drc@linux.vnet.ibm.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Marohn, Byron" <byron.marohn@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter
Date: Wed, 29 Sep 2021 10:41:47 -0700 [thread overview]
Message-ID: <ce2e3581-747e-0741-a423-8b53f6c21db3@linux.vnet.ibm.com> (raw)
In-Reply-To: <DM8PR11MB55914EF7BC2AC229DF8F7CE784A99@DM8PR11MB5591.namprd11.prod.outlook.com>
On 9/29/21 12:51 AM, De Lara Guarch, Pablo wrote:
> Hi
>
>> -----Original Message-----
>> From: David Christensen <drc@linux.vnet.ibm.com>
>> Sent: Tuesday, September 28, 2021 4:53 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Wang, Yipeng1
>> <yipeng1.wang@intel.com>; Marohn, Byron <byron.marohn@intel.com>
>> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
>> Subject: Re: [PATCH v4] efd: change data type of parameter
>>
>>
>>
>> On 9/28/21 6:58 AM, Pablo de Lara wrote:
>>> rte_efd_create() function was using uint8_t for a socket bitmask, for
>>> one of its parameters.
>>> This limits the maximum of NUMA sockets to be 8.
>>> Changing to to uint64_t increases it to 64, which should be more
>>> future-proof.
>>>
>>> Coverity issue: 366390
>>> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library")
>>>
>>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>>> Acked-by: John McNamara <john.mcnamara@intel.com>
>>> ---
>>>
>>> v4: Set socket id in EFD tests
>>>
>>> v3: Fixed commit message
>>>
>>> v2: Fixed EFD tests
>>
>> Results with v4 on a non-consecutive NUMA system:
>
> ...
>
>> Test OK
>
> Great! Thanks a lot for checking. Would you mind adding tested-by to the patch?
>
> Pablo
>
Tested-by: David Christensen <drc@linux.vnet.ibm.com>
next prev parent reply other threads:[~2021-09-29 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:53 [dpdk-dev] [PATCH] " Pablo de Lara
2021-09-13 18:18 ` Mcnamara, John
2021-09-14 7:10 ` David Marchand
2021-09-14 10:49 ` Kinsella, Ray
2021-09-14 18:20 ` David Christensen
2021-09-17 12:56 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2021-09-20 19:30 ` David Christensen
2021-09-28 14:18 ` De Lara Guarch, Pablo
2021-09-28 13:58 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2021-09-28 15:52 ` David Christensen
2021-09-29 7:51 ` De Lara Guarch, Pablo
2021-09-29 17:41 ` David Christensen [this message]
2021-09-29 18:13 ` Wang, Yipeng1
2021-10-01 14:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2e3581-747e-0741-a423-8b53f6c21db3@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).