From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74BA9A0547; Wed, 29 Sep 2021 19:41:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9F29410EA; Wed, 29 Sep 2021 19:41:53 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id B6DD4410E5 for ; Wed, 29 Sep 2021 19:41:51 +0200 (CEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18TG0aVJ006539; Wed, 29 Sep 2021 13:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=lwWOgqYyzteG0Ed8jUfYwDqgUJoWSAobqVGKpdns77A=; b=Czr0cs+47+MRZAhRT2nQH2MirUo342d258XtYxEcffAZcVqhTar1B+KxIX88g8PY4eCP bdbnUWP2FJMUmlEA9TxdhhvjxMesp9zOKM5Ugk/yZLgzcnAk0jOp7WbKRJYVZy1aorud SdibNO84QiSRaV6zMV1dzvA6cj0wiaeb11G/YFSD/J6wtT/3occkZPmSDPP5cAfc/05W 2hQzYTuKCtVRsUZuawaQpf3vVrLHvdsqOoD3F00hgUH1BeyHHFlNC7D2ZDvEIiyW3jg2 zUmfE2/VbjuDzLcrjX5xHd8/+wbbYYNRla3BG3/aAnHtUuiT6HU8NzKhfwCOPcg8Xmh9 8w== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bcu9rjtv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 13:41:50 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18THYMK3015969; Wed, 29 Sep 2021 17:41:49 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03dal.us.ibm.com with ESMTP id 3b9udc1ch9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 17:41:49 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18THfn7m41746924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Sep 2021 17:41:49 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDF50AC059; Wed, 29 Sep 2021 17:41:48 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 524C5AC069; Wed, 29 Sep 2021 17:41:48 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.69.22]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Sep 2021 17:41:48 +0000 (GMT) To: "De Lara Guarch, Pablo" , "Wang, Yipeng1" , "Marohn, Byron" Cc: "dev@dpdk.org" , "Mcnamara, John" References: <20210917125606.2524678-1-pablo.de.lara.guarch@intel.com> <20210928135839.3778960-1-pablo.de.lara.guarch@intel.com> From: David Christensen Message-ID: Date: Wed, 29 Sep 2021 10:41:47 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: CLEDfNDH93oqx8yFw-4U54tM0eZStfi_ X-Proofpoint-ORIG-GUID: CLEDfNDH93oqx8yFw-4U54tM0eZStfi_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-29_07,2021-09-29_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109290100 Subject: Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/21 12:51 AM, De Lara Guarch, Pablo wrote: > Hi > >> -----Original Message----- >> From: David Christensen >> Sent: Tuesday, September 28, 2021 4:53 PM >> To: De Lara Guarch, Pablo ; Wang, Yipeng1 >> ; Marohn, Byron >> Cc: dev@dpdk.org; Mcnamara, John >> Subject: Re: [PATCH v4] efd: change data type of parameter >> >> >> >> On 9/28/21 6:58 AM, Pablo de Lara wrote: >>> rte_efd_create() function was using uint8_t for a socket bitmask, for >>> one of its parameters. >>> This limits the maximum of NUMA sockets to be 8. >>> Changing to to uint64_t increases it to 64, which should be more >>> future-proof. >>> >>> Coverity issue: 366390 >>> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library") >>> >>> Signed-off-by: Pablo de Lara >>> Acked-by: John McNamara >>> --- >>> >>> v4: Set socket id in EFD tests >>> >>> v3: Fixed commit message >>> >>> v2: Fixed EFD tests >> >> Results with v4 on a non-consecutive NUMA system: > > ... > >> Test OK > > Great! Thanks a lot for checking. Would you mind adding tested-by to the patch? > > Pablo > Tested-by: David Christensen