From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 69A811B742 for ; Mon, 9 Apr 2018 14:01:40 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C9C6D9C0087; Mon, 9 Apr 2018 12:01:38 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 9 Apr 2018 13:01:35 +0100 To: Ferruh Yigit , References: <1522840238-31740-1-git-send-email-arybchenko@solarflare.com> <92e30c65-2db8-db43-5f52-4a2af865f44a@intel.com> From: Andrew Rybchenko Message-ID: Date: Mon, 9 Apr 2018 15:01:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <92e30c65-2db8-db43-5f52-4a2af865f44a@intel.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23772.003 X-TM-AS-Result: No--13.816100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523275299-U+sGysz4u5XZ Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: support loopback mode configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 12:01:40 -0000 On 04/06/2018 03:09 PM, Ferruh Yigit wrote: > On 4/4/2018 12:10 PM, Andrew Rybchenko wrote: >> All loopback modes are listed in efx_loopback_type_t. >> Available loopback modes are listed per link speed in >> the enc_loopback_types member of the efx_nic_cfg_t. >> >> Signed-off-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton >> Reviewed-by: Ivan Malov > Getting following build error with clang, can you please check? > > > .../dpdk/drivers/net/sfc/base/efx_port.c:122:6: error: comparison of constant 64 > with expression of type 'efx_loopback_type_t' (aka 'enum efx_loopback_type_e') > is always true [-Werror,-Wtautological-constant-out-of-range-compare] > if (EFX_TEST_QWORD_BIT(encp->enc_loopback_types[link_mode], > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../dpdk/drivers/net/sfc/base/efx_types.h:1590:28: note: expanded from macro > 'EFX_TEST_QWORD_BIT' > #define EFX_TEST_QWORD_BIT EFX_TEST_QWORD_BIT64 > ^ > .../dpdk/drivers/net/sfc/base/efx_types.h:1412:22: note: expanded from macro > 'EFX_TEST_QWORD_BIT64' > __CPU_TO_LE_64(EFX_SHIFT64(_bit, FIX_LINT(0)))) != 0) > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../dpdk/drivers/net/sfc/base/efx_types.h:1290:32: note: expanded from macro > 'EFX_SHIFT64' > (((_bit) >= (_base) && (_bit) < (_base) + 64) ? \ > ^ > .../dpdk/drivers/net/sfc/base/efx_types.h:269:50: note: expanded from macro > '__CPU_TO_LE_64' > #define __CPU_TO_LE_64(_x) ((uint64_t)__NOSWAP64(_x)) > ~~~~~~~~~~~^~~ > .../dpdk/drivers/net/sfc/base/efx_types.h:238:26: note: expanded from macro > '__NOSWAP64' > #define __NOSWAP64(_x) (_x) > ^~ > 1 error generated. Thanks, I've added patch to fix the problem. Andrew.