From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 240AAA050D; Tue, 26 Apr 2022 19:58:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1A5B40E78; Tue, 26 Apr 2022 19:58:32 +0200 (CEST) Received: from forward500j.mail.yandex.net (forward500j.mail.yandex.net [5.45.198.250]) by mails.dpdk.org (Postfix) with ESMTP id 66A01406A2; Tue, 26 Apr 2022 19:58:31 +0200 (CEST) Received: from vla1-68d3ce55e22b.qloud-c.yandex.net (vla1-68d3ce55e22b.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3385:0:640:68d3:ce55]) by forward500j.mail.yandex.net (Yandex) with ESMTP id BCAB96CB6681; Tue, 26 Apr 2022 20:58:30 +0300 (MSK) Received: from vla1-62318bfe5573.qloud-c.yandex.net (vla1-62318bfe5573.qloud-c.yandex.net [2a02:6b8:c0d:3819:0:640:6231:8bfe]) by vla1-68d3ce55e22b.qloud-c.yandex.net (mxback/Yandex) with ESMTP id YNZVo4qG7R-wUfKWOdr; Tue, 26 Apr 2022 20:58:30 +0300 X-Yandex-Fwd: 2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1650995910; bh=Zp1Pas2ivYmF5QOgtBqm8S3la680vJwFFR3OZrcBUlY=; h=In-Reply-To:From:Subject:References:Date:Message-ID:To; b=jrRSASNoxPh8u/GN3nsxnAUsVE4LetU50Fe3KIMw5PZdyjgvp7lZn9KCQNTWJbekc aifQXlE/amd89UQM03HQRURXyFzj2PGF9ohmyDq4mSZ3oLUHk0cKGPsPyJ4pcnx9Uz UBPL0sx+zaQdYZXHORkrZjgmltFuHxR39f9L4DDg= Authentication-Results: vla1-68d3ce55e22b.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by vla1-62318bfe5573.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id I1lsQUN48v-wTM4swas; Tue, 26 Apr 2022 20:58:30 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Message-ID: Date: Tue, 26 Apr 2022 18:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Fwd: Does ACL support field size of 8 bytes? Content-Language: en-US References: To: dev@dpdk.org, users@dpdk.org From: Konstantin Ananyev In-Reply-To: X-Forwarded-Message-Id: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ido, > I've lots of good experience with ACL but can't make it work with u64 values > I know it can be split to 2xu32 fields, but it makes it more complex to use and a wastes double number of fields (we hit the > RTE_ACL_MAX_FIELDS 64 limit) Wow, that's a lot of fields... > According to the documentation and rte_acl.h fields size can be 8 bytes (u64) > e.g. > 'The size parameter defines the length of the field in bytes. Allowable values are 1, 2, 4, or 8 bytes.' > (from https://doc.dpdk.org/guides-21.11/prog_guide/packet_classif_access_ctrl.html#rule-definition) > > Though there's a hint it's less recommended > 'Also, it is best to define fields of 8 or more bytes as 4 byte fields so that the build processes can eliminate fields that are all wild.' > > It's also not clear how it fits in a group (i.e. what's input_index stride) which is only 4 bytes > 'All subsequent fields has to be grouped into sets of 4 consecutive bytes.' > > I couldn't find any example or test app that's using 8 bytes > e.g. for IPv6 address 4xu32 fields are always used and not 2xu64 > > Should it work? > Did anyone try it successfully and/or can share an example? You are right: though it is formally supported, we do not test it, and AFAIK no-one used it till now. As we do group fields by 4B long chunks anyway, 8B field is sort of awkward and confusing. To be honest, I don't even remember what was the rationale beyond introducing it at first place. Anyway, just submitted patches that should fix 8B field support (at least it works for me now): https://patches.dpdk.org/project/dpdk/list/?series=22676 Please give it a try. In long term it probably would be good to hear from you and other users, should we keep 8B support at all, or might be it would be easier just to abandon it. Thanks Konstantin