From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C92FEA0C47; Tue, 12 Oct 2021 12:05:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86FFF4111E; Tue, 12 Oct 2021 12:05:38 +0200 (CEST) Received: from mail-108-mta62.mxroute.com (mail-108-mta62.mxroute.com [136.175.108.62]) by mails.dpdk.org (Postfix) with ESMTP id 8AE1E4111B for ; Tue, 12 Oct 2021 12:05:36 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta62.mxroute.com (ZoneMTA) with ESMTPSA id 17c73f6e3840000b55.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 12 Oct 2021 10:05:32 +0000 X-Zone-Loop: 30588499202cb1f2ecd935b10857f4a31308dbbdf6d7 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7etPa30qR0tiz1tC4WNdrv3h2VAZxH5xCCjQJZxMzu4=; b=qEC0aig3I6DtI4Jd9aterTrk7y I47kfRIV25ccRcu2R924vEUmI7TrPF+U82lPFHEdF3CRCRei6ZXRdo9ZMm/2XrbIWfiGdFtrHI6ai ELvunwGV9jZ7jsTwsTHTxpIyMr6f0jBqyQRPghGkJ6T7m+SUl/iE86DEkUabQpKf+zRpGIh92/tLY Cc9fWTn/2jwKHFnl5LZRjTk4ttos2x87+x/oDSUhJj1nVEl/Kobk+wPpZPuRRlyxtB32yrCzGB+5c o07GFUn7/Hl3IHRj4kcI5sLzQ4/DD9jwSxvMJkK0fGbPc6CK9bIQu8isqUagHBUiVzLve6JgbaK0u Inmw1bJA==; To: Jerin Jacob , Thomas Monjalon Cc: "Kundapura, Ganapati" , David Marchand , dpdk-dev , "Jayatheerthan, Jay" References: <20211007125734.2326512-1-ganapati.kundapura@intel.com> <1674729.iRVOSB7e9I@thomas> From: "Kinsella, Ray" Message-ID: Date: Tue, 12 Oct 2021 11:05:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, TO_DN_ALL=0, FROM_HAS_DN=0, FREEMAIL_ENVRCPT=0, FREEMAIL_TO=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, RCPT_COUNT_FIVE=0, MID_RHS_MATCH_FROM=0, NEURAL_SPAM=0] Subject: Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/10/2021 10:26, Jerin Jacob wrote: > On Tue, Oct 12, 2021 at 2:40 PM Thomas Monjalon wrote: >> >> 12/10/2021 10:47, Jerin Jacob: >>> On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati >>> wrote: >>>> From: Jerin Jacob >>>>>> --- a/lib/eventdev/rte_event_eth_rx_adapter.h >>>>>> +++ b/lib/eventdev/rte_event_eth_rx_adapter.h >>>>>> @@ -216,6 +216,10 @@ struct rte_event_eth_rx_adapter_stats { >>>>>> /**< Eventdev enqueue count */ >>>>>> uint64_t rx_enq_retry; >>>>>> /**< Eventdev enqueue retry count */ >>>>>> + uint64_t rx_event_buf_count; >>>>>> + /**< Rx event buffered count */ >>>>>> + uint64_t rx_event_buf_size; >>>>> >>>>> >>>>> Isn't ABI breakage? CI did not warn this. Isn't this a public structure? >>>> Please confirm if moving the above two members to end of the structure overcomes ABI breakage? >>> >>> >>> + @Ray Kinsella @Thomas Monjalon @David Marchand >>> >>> It will still break the ABI. IMO, Since it is an ABI breaking release >>> it is OK. If there are no other objections, Please move the variable >>> to end >>> of the structure and update release notes for ABI changes. >> >> Why moving since it breaks ABI anyway? > > There is no specific gain in keeping new additions in the middle of structure. 21.11 is an ABI breaking release, so move it where you like :-) >> I think you can keep as is. >> >> >>