DPDK patches and discussions
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Min Hu (Connor)" <humin29@huawei.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Chas Williams <chas3@att.com>,
	jerinj@marvell.com
Subject: Re: [RFC PATCH 2/4] net/bonding: move testpmd commands
Date: Tue, 24 May 2022 10:40:08 +0100
Message-ID: <ce5942bc-da86-710f-08da-221a27d75d48@yandex.ru> (raw)
In-Reply-To: <fbc6b688-941b-a91e-15e3-d0407b43080f@oktetlabs.ru>

20/05/2022 07:59, Andrew Rybchenko пишет:
> On 5/19/22 14:26, Thomas Monjalon wrote:
>> 19/05/2022 09:40, David Marchand:
>>> On Thu, May 19, 2022 at 1:25 AM Konstantin Ananyev
>>> <konstantin.v.ananyev@yandex.ru> wrote:
>>>> 18/05/2022 18:24, David Marchand пишет:
>>>>> On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) 
>>>>> <humin29@huawei.com> wrote:
>>>>>>
>>>>>>     I think net/bonding offer 'API' for APP to use the bonding.
>>>>>>       and use the specific PMD as slave device.
>>>>>>     The software framwork is like:
>>>>>>      APP
>>>>>>      ethdev
>>>>>>      bonding PMD
>>>>>>      PMD
>>>>>>      hardware
>>>>>>
>>>>>> so, I think cmdlines for testpmd should not put in net/bonding.be
>>
>> The bonding API is specific to drivers/net/bonding/,
>> so according to the techboard decision,
>> the testpmd code should go in the driver directory.
> 
> +1
> 
>>
>>>> Actually, I feel the same.
>>>> I do understand the intention, and I do realize it is just location,
>>>> but still doesn't look right for me.
>>>> can't we have a special sub-folder in testpmd instead?
>>>> Something like app/testpmd/driver_specific/(ixgbe)|(i40e)|(bonding)...
>>>
>>> That should not pose a problem, indeed.
>>> And, on the plus side, it avoids putting some testpmd global variables
>>> in meson (which I was not entirely happy with).
>>
>> I like the global variables approach.
> 
> +1
> 
>>
>>> But, on the other side, I have a concern about MAINTAINERS updates.
>>>
>>> (almost) everything in app/test-pmd has been under the testpmd
>>> maintainer responsibility.
>>> Separating the driver specific code from testpmd is a way to clearly
>>> shift this responsibility to the driver maintenance.
>>
>> I agree.
> 
> +1
> 
>>
>>> One advantage of moving the code to the driver directory is that there
>>> is no MAINTAINERS update needed.
>>
>> Yes I think moving test code in the driver directory is smart.
>> We already have this approach for some self tests run with app/test.
>> And more important, the techboard has decided to move code in the driver
>> or lib directory:
>>     https://mails.dpdk.org/archives/dev/2022-April/239191.html

Yep, I remember that discussion, though from my impression
(probably wrong) people talked more about need for some smart
testpmd plugin approach.
I didn't realize that it would mean literally dump all
current cmd-line related code straight into drivers/net.
I agree that testpmd code for PMD-specific API should be
responsibility of this PMD maintainer.
I just don't feel that drivers/net is the best place for it.
As another thing to consider: what would happen if we'll decide
to rework testpmd interface (from CLI to gRPC or so), or introduce
new app for PMD testing - would we need to inject all these things
into drivers/net too?

>>
>>> If we keep those in app/test-pmd, it is still possible to mark the
>>> driver-specific sources in MAINTAINERS, but such updates are often
>>> missed.
>>> I can probably add something in devtools/ to catch those updates in
>>> the future...
>>>
>>> I'll try for RFC v3.
>>
>>
>>
> 


  reply	other threads:[~2022-05-24  9:40 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13  7:57 [RFC PATCH 0/4] Split driver specific commands out of testpmd David Marchand
2022-05-13  7:57 ` [RFC PATCH 1/4] app/testpmd: register driver specific commands David Marchand
2022-05-13 10:30   ` David Marchand
2022-05-13  7:57 ` [RFC PATCH 2/4] net/bonding: move testpmd commands David Marchand
2022-05-13 10:09   ` Min Hu (Connor)
2022-05-18 17:24     ` David Marchand
2022-05-18 23:25       ` Konstantin Ananyev
2022-05-19  7:40         ` David Marchand
2022-05-19 11:26           ` Thomas Monjalon
2022-05-20  6:59             ` Andrew Rybchenko
2022-05-24  9:40               ` Konstantin Ananyev [this message]
2022-05-24 10:15                 ` Thomas Monjalon
2022-05-24 22:41                   ` Konstantin Ananyev
2022-05-13  7:57 ` [RFC PATCH 3/4] net/i40e: " David Marchand
2022-05-13  7:57 ` [RFC PATCH 4/4] net/ixgbe: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd David Marchand
2022-05-18 19:46   ` [RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static David Marchand
2022-05-20  6:28     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 2/5] app/testpmd: register driver specific commands David Marchand
2022-05-20  6:55     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 3/5] net/bonding: move testpmd commands David Marchand
2022-05-20  6:55     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 4/5] net/i40e: " David Marchand
2022-05-18 19:46   ` [RFC PATCH v2 5/5] net/ixgbe: " David Marchand
2022-05-20  7:04   ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd Andrew Rybchenko
2022-05-23  7:10 ` [PATCH 0/6] " David Marchand
2022-05-23  7:10   ` [PATCH 1/6] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-23 10:19     ` Dumitrescu, Cristian
2022-05-23 18:09       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 2/6] app/testpmd: register driver specific commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-05-24 10:53       ` David Marchand
2022-05-24 11:43         ` Ferruh Yigit
2022-05-24 17:21     ` Thomas Monjalon
2022-05-24 17:44       ` David Marchand
2022-05-24 17:51         ` Thomas Monjalon
2022-05-23  7:10   ` [PATCH 3/6] net/bonding: move testpmd commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-06-17  5:06     ` [PATCH v2] " David Marchand
2022-06-20 17:53       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 4/6] net/i40e: " David Marchand
2022-06-17  5:07     ` [PATCH v2] " David Marchand
2022-06-20 17:53       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 5/6] app/testpmd: drop ixgbe bypass commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-06-17  5:07     ` [PATCH v2 1/3] app/testpmd: restore " David Marchand
2022-06-17  5:07       ` [PATCH v2 2/3] net/ixgbe: move testpmd commands David Marchand
2022-06-17  5:07       ` [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-06-20 19:04         ` Ferruh Yigit
2022-06-23 12:35           ` Zhang, Qi Z
2022-07-21  8:05     ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands David Marchand
2022-07-21  8:05       ` [PATCH v3 2/3] net/ixgbe: move testpmd commands David Marchand
2022-07-21  8:05       ` [PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-05-23  7:10   ` [PATCH 6/6] net/ixgbe: move testpmd commands David Marchand
2022-05-23 18:09   ` [PATCH 0/6] Split driver specific commands out of testpmd Ferruh Yigit
2022-05-24 20:06 ` [PATCH v2 0/2] " David Marchand
2022-05-24 20:06   ` [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-31 15:15     ` Andrew Rybchenko
2022-05-24 20:06   ` [PATCH v2 2/2] app/testpmd: register driver specific commands David Marchand
2022-05-24 20:28     ` Thomas Monjalon
2022-05-31 15:14       ` Andrew Rybchenko
2022-05-31 15:18         ` David Marchand
2022-05-31 15:18   ` [PATCH v2 0/2] Split driver specific commands out of testpmd Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce5942bc-da86-710f-08da-221a27d75d48@yandex.ru \
    --to=konstantin.v.ananyev@yandex.ru \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chas3@att.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=xiaoyun.li@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git