From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9623A0C43; Tue, 28 Sep 2021 18:53:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58BF8410D7; Tue, 28 Sep 2021 18:53:50 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id F2C1140E3C; Tue, 28 Sep 2021 18:53:48 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7787D7F4FD; Tue, 28 Sep 2021 19:53:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7787D7F4FD DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1632848028; bh=dhDiuSIgj5T1UwAxl/D5BKMw55ngcqbcL1lcMd6Tjvc=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Z9XD9pMnIKqg5lHOeTh1DMsaGBJGs5vMZwUuEhIFVKmu+SIjOcwPP/qFdPjMUh+KC p/g2o/0j2jve01ZCCwatdLFji6/yNiA+paE11tpMympyWfzEVIz9XwKP/va6qtfFW7 v+aqXHT8UoqdXb9lPnbcUC/l0wssThbwHwKi63nA= To: Ferruh Yigit , Thomas Monjalon , Kuba Kozak Cc: dev@dpdk.org, Olivier Matz , Ivan Ilchenko , stable@dpdk.org, Andy Moreton References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210928120533.834334-1-andrew.rybchenko@oktetlabs.ru> <20210928120533.834334-2-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Tue, 28 Sep 2021 19:53:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/21 7:50 PM, Ferruh Yigit wrote: > On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Update xstats by IDs callbacks documentation in accordance with >> ethdev usage of these callbacks. Document valid combinations of >> input arguments to make driver implementation simpler. >> >> Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton >> --- >> lib/ethdev/ethdev_driver.h | 42 ++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 40 insertions(+), 2 deletions(-) >> >> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h >> index 40e474aa7e..c89eefcc42 100644 >> --- a/lib/ethdev/ethdev_driver.h >> +++ b/lib/ethdev/ethdev_driver.h >> @@ -187,11 +187,28 @@ typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, >> struct rte_eth_xstat *stats, unsigned int n); >> /**< @internal Get extended stats of an Ethernet device. */ >> >> +/** >> + * @internal >> + * Get extended stats of an Ethernet device. >> + * >> + * @param dev >> + * ethdev handle of port. >> + * @param ids >> + * IDs array to retrieve specific statistics. Must not be NULL. >> + * @param values >> + * A pointer to a table to be filled with device statistics values. >> + * Must not be NULL. >> + * @param n >> + * Element count in @p ids and @p values. >> + * >> + * @return >> + * - A number of filled in stats. >> + * - A negative value on error. >> + */ >> typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, >> const uint64_t *ids, >> uint64_t *values, >> unsigned int n); >> -/**< @internal Get extended stats of an Ethernet device. */ >> >> /** >> * @internal >> @@ -218,10 +235,31 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev, >> struct rte_eth_xstat_name *xstats_names, unsigned int size); >> /**< @internal Get names of extended stats of an Ethernet device. */ >> >> +/** >> + * @internal >> + * Get names of extended stats of an Ethernet device. >> + * For name count, set @p xstats_names and @p ids to NULL. > > Why limiting this behavior to 'xstats_get_names_by_id'? > > Internally 'xstats_get_names_by_id' is used to get the count, but I think this > is not intentionally selected, just one of the xstats_*_by_id dev_ops used. > > I think it is confusing to have this support for one of the '_by_id' dev_ops but > not for other. Why not require both to support returning 'count'? Simply because it is dead code. There is no point to require from driver to have dead code.