DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mem: fix DMA mask width sanity check
Date: Wed, 7 Nov 2018 10:14:30 +0000	[thread overview]
Message-ID: <ce6d0e01-1e61-8f6b-18aa-cc16f0f90a80@intel.com> (raw)
In-Reply-To: <20181107094456.23123-1-alejandro.lucero@netronome.com>

On 07-Nov-18 9:44 AM, Alejandro Lucero wrote:
> Current code has different max DMA mask width values for 32 and 64
> bits systems. IOMMU hardware could report a higher supported width
> than current MAX_DMA_MASK_BITS when RTE_ARCH_64 is not defined. This
> is actually true with a 32 bits kernel running in a 64 bits server
> with IOMMU hardware. This could also be a problem with embedded systems
> using an IOMMU designed for 64 bits in a 32 bits system.
> 
> This patch leaves a single max DMA mask width which will make sure the
> mask width is within the range for 64 bits variables used for DMA mask.
> This also will avoid wrong values because any value higher than
> 64 bits is likely wrong.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-11-07 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  9:44 Alejandro Lucero
2018-11-07 10:14 ` Burakov, Anatoly [this message]
2018-11-07 11:47   ` Ferruh Yigit
2018-11-07 13:43     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce6d0e01-1e61-8f6b-18aa-cc16f0f90a80@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).