From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EA0EA00C3; Thu, 14 May 2020 09:04:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 109941D606; Thu, 14 May 2020 09:04:36 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 125F31D605; Thu, 14 May 2020 09:04:33 +0200 (CEST) IronPort-SDR: BKNohvRB9e7Dt1OTlVtleQ2m8VpUcFysEUq1uqWjhXY5mVzbghRdnOCjPRFpkS1PRFnGf+gxAZ aKgwGXXr4Nuw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 00:04:33 -0700 IronPort-SDR: 4DvbMjFJk5z4jhzIOqybJ6POMBEqkhFVCE2mHWGL5cQ0u5rv/UeCFVnfabvhyy43O8emELBGu7 8fANmU+NkCzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="266147916" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 14 May 2020 00:04:31 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 00:04:30 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 15:04:28 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Thu, 14 May 2020 15:04:28 +0800 From: "Wang, ShougangX" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow Thread-Index: AQHWKNkbcuqC5KLX50KOxcj3/2STfailRgQAgAHiIaA= Date: Thu, 14 May 2020 07:04:28 +0000 Message-ID: References: <20200424085225.27655-1-shougangx.wang@intel.com> <20200513033320.15771-1-shougangx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Bernad > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, May 13, 2020 6:12 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= ang, > ShougangX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RS= S > flow >=20 > Hi Shougang, >=20 > > -----Original Message----- > > From: dev On Behalf Of Shougang Wang > > Sent: Wednesday, May 13, 2020 4:33 AM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Guo, Jia > > ; Wang, ShougangX ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS > > flow > > > > This patch fixes the issue that the queue region does not take effect > > due to incorrectly setting the flow type. > > > > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shougang Wang > > Reviewed-by: Jeff Guo > > --- > > drivers/net/i40e/i40e_flow.c | 35 > ++++++++++++++++++++++++++++++++- > > -- > > 1 file changed, 32 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..2f937567b 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4625,6 +4625,34 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > *dev, uint32_t index =3D 0; uint64_t hf_bit =3D 1; > > > > +static const struct { > > +uint64_t rss_type; > > +enum i40e_filter_pctype pctype; > > +} pctype_match_table[] =3D { > > +{ETH_RSS_FRAG_IPV4, > > +I40E_FILTER_PCTYPE_FRAG_IPV4}, > > +{ETH_RSS_NONFRAG_IPV4_TCP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_TCP}, > > +{ETH_RSS_NONFRAG_IPV4_UDP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_UDP}, > > +{ETH_RSS_NONFRAG_IPV4_SCTP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_SCTP}, > > +{ETH_RSS_NONFRAG_IPV4_OTHER, > > +I40E_FILTER_PCTYPE_NONF_IPV4_OTHER}, > > +{ETH_RSS_FRAG_IPV6, > > +I40E_FILTER_PCTYPE_FRAG_IPV6}, > > +{ETH_RSS_NONFRAG_IPV6_TCP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_TCP}, > > +{ETH_RSS_NONFRAG_IPV6_UDP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_UDP}, > > +{ETH_RSS_NONFRAG_IPV6_SCTP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_SCTP}, > > +{ETH_RSS_NONFRAG_IPV6_OTHER, > > +I40E_FILTER_PCTYPE_NONF_IPV6_OTHER}, > > +{ETH_RSS_L2_PAYLOAD, > > +I40E_FILTER_PCTYPE_L2_PAYLOAD}, > > +}; >=20 > I don't think this is a complete list of RSS offload types. > See file librte_ethdev/rte_ethdev,h lines 496 to 523. > See also app/test-pmd/config.c lines 77 to 121. >=20 Thanks for your review. We can not contain all the RSS offload types. We need i40e_filter_pctype to= configure the queue region. It only defines some basic pctypes and there i= s no regular between i40e_filter_pctype and RSS offload types. So for "flow= create", it can only configure queue region for these basic pctypes. What = we can do is associate them with RSS offload types. Thanks. Shougang