From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B01B3A0561; Tue, 21 Apr 2020 03:38:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E3121D67C; Tue, 21 Apr 2020 03:38:34 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 71F081C297 for ; Tue, 21 Apr 2020 03:38:33 +0200 (CEST) IronPort-SDR: 2wWZKPlJZq1b89dBEbaxFBFMCs3jPIYaW7U2RaeaBIWclrV/1nhMTWUsTYgWHzaqtkirkawVMM 8W3+ycY6h51Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 18:38:32 -0700 IronPort-SDR: hamDTuJYlQFvwDqj6Fe8xJmrhCzlEu8ciy2YDBQWmE8lppsOQ2BiFRjeQt3DogyXbWKbwa+ZW6 afthhW/x4AIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="429348961" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga005.jf.intel.com with ESMTP; 20 Apr 2020 18:38:31 -0700 Received: from irsmsx602.ger.corp.intel.com (163.33.146.8) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 02:38:30 +0100 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by irsmsx602.ger.corp.intel.com (163.33.146.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 21 Apr 2020 02:38:29 +0100 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 21 Apr 2020 09:38:27 +0800 From: "Wang, Haiyue" To: Thomas Monjalon , David Marchand CC: Neil Horman , dev , "Burakov, Anatoly" , Vamsi Attunuru , Jerin Jacob Kollanukkaran , "Yigit, Ferruh" , "Richardson, Bruce" , "Kinsella, Ray" Thread-Topic: [PATCH v8 0/2] support for VFIO-PCI VF token interface Thread-Index: AQHWFafaI2Lui2Y2EEyeOUOuYmQWTqiBtuGAgACHcqD//347AIAAjE3A//973ACAAQnooA== Date: Tue, 21 Apr 2020 01:38:27 +0000 Message-ID: References: <20200305043311.17065-1-vattunuru@marvell.com> <3674958.iIHpSLecBQ@thomas> <47965937c20e43bebd7458951699a597@intel.com> <3886348.YqazSvReao@thomas> In-Reply-To: <3886348.YqazSvReao@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas & David, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 01:43 > To: Wang, Haiyue > Cc: Neil Horman ; David Marchand ; dev > ; Burakov, Anatoly ; Vamsi Attun= uru ; > Jerin Jacob Kollanukkaran ; Alex Williamson > Subject: Re: [PATCH v8 0/2] support for VFIO-PCI VF token interface >=20 > 20/04/2020 19:37, Wang, Haiyue: > > From: Thomas Monjalon > > > 20/04/2020 19:02, Wang, Haiyue: > > > > From: David Marchand > > > > > I had a look at the CI, I can see we are still missing bits to ha= ndle > > > > > the ABI failure on rte_vfio_setup_device. > > > > > > > > Yes, not handle it now. > > > > > > > > If 'rte_vfio_setup_device' can be internal, not official DPDK API, = then __rte_internal > > > > is the best way to handle ABI issue. > > > > > > Please could you help finishing integration of __rte_internal? > > > > I thought it should be Neil ? "Yes, I'll get back to this today" ;-) > > http://inbox.dpdk.org/dev/CAJFAV8ydLkV0afEHqbh6KeA3Box0Yxb3N0MNGtMD4S9b= mSgT0A@mail.gmail.com/ >=20 > It did not happen after several months. > If you want to unblock your patches, I think it is safer to finish yourse= lf. >=20 Unfortunately, this __rte_internal will still make the ci fail to run when = move the function to INTERNAL session: --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -3,6 +3,11 @@ [suppress_variable] symbol_version =3D EXPERIMENTAL +[suppress_function] + symbol_version =3D INTERNAL +[suppress_variable] + symbol_version =3D INTERNAL + --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -213,7 +213,6 @@ DPDK_20.0 { rte_vfio_is_enabled; rte_vfio_noiommu_is_enabled; rte_vfio_release_device; - rte_vfio_setup_device; rte_vlog; rte_zmalloc; rte_zmalloc_socket; @@ -339,3 +338,10 @@ EXPERIMENTAL { # added in 20.05 rte_log_can_log; }; + +INTERNAL { + global: + + # added in 20.05 + rte_vfio_setup_device; +}; Functions changes summary: 1 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 Removed function: [D] 'function int rte_vfio_setup_device(const char*, const char*, int*, v= fio_device_info*)' {rte_vfio_setup_device@@DPDK_20.0} Error: ABI issue reported for 'abidiff --suppr ./devtools/libabigail.abigno= re --no-added-syms --headers-dir1 old_abi/include --headers-dir2 new_abi/in= clude old_abi/dump/librte_eal.dump new_abi/dump/librte_eal.dump'