From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BAA9C4CBD; Thu, 19 Jul 2018 18:38:11 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C0263800061; Thu, 19 Jul 2018 16:38:09 +0000 (UTC) Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 19 Jul 2018 17:38:03 +0100 To: Anatoly Burakov , CC: , , References: <038143a314345e9c5bf76b1287497a5c4c9f63ed.1531992860.git.anatoly.burakov@intel.com> From: Andrew Rybchenko Message-ID: Date: Thu, 19 Jul 2018 19:37:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <038143a314345e9c5bf76b1287497a5c4c9f63ed.1531992860.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23978.003 X-TM-AS-Result: No--2.570300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1532018291-tOz68WIFk2WC Subject: Re: [dpdk-dev] [PATCH] malloc: don't skip pad on free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 16:38:12 -0000 On 19.07.2018 12:42, Anatoly Burakov wrote: > Previously, we were skipping erasing pad because we were > expecting it to be freed when we were merging adjacent > segments. However, if there were no adjacent segments to > merge, we would've skipped erasing the pad, leaving non-zero > memory in our free space. > > Fix this by including pad in the erasing unconditionally. > > Fixes: e43a9f52b7ff ("malloc: fix pad erasing") > Cc: stable@dpdk.org > > Reported-by: Andrew Rybchenko > > Signed-off-by: Anatoly Burakov Many thanks, the patch fixes the problem I've observed. Tested-by: Andrew Rybchenko