From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 173CEA0547; Wed, 29 Sep 2021 16:54:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 076F0410F5; Wed, 29 Sep 2021 16:54:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (usb-smtp-delivery-124.mimecast.com [170.10.151.124]) by mails.dpdk.org (Postfix) with ESMTP id 5C029410F0 for ; Wed, 29 Sep 2021 16:54:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632927293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tmjrQ5i2XNogBQuJpV+4czwcrs/5S9pCgZ5qZ4XYuVA=; b=UvVXhMZffJaZxFHiO7+TKPFth3IFwcKbUMOlDxKuIGSXKMIO/J2LeDZpguhbeUzbchJKob wCHd6h3MpNciHmAXEmqo0eSFWKhnf2sYznY8ESJFEvKt93g7cbp6wUzlOYoGt6H7QTpLP8 cN0+hbz8LbjCef6TNDTn+jNl9mMouuU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-N81KPPK5M5qbhs9WabXBtg-1; Wed, 29 Sep 2021 10:54:52 -0400 X-MC-Unique: N81KPPK5M5qbhs9WabXBtg-1 Received: by mail-wm1-f72.google.com with SMTP id m9-20020a05600c4f4900b003057c761567so2835834wmq.1 for ; Wed, 29 Sep 2021 07:54:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=tmjrQ5i2XNogBQuJpV+4czwcrs/5S9pCgZ5qZ4XYuVA=; b=0Zvj+YuhiJDsscjZY60mp4XaLkhXqs7fGv0TUaSRxtYWsUwCNKdY17PEp3PhTCDKAW 3Gr9iZYxTVWTRfnXML6JdnPw6TTg0lJ+UCIff2q/5TAF/DC2iK63wh0E5iJyIT3tUmqD o9ZqlTt/5xwnFNGi5tlUfmiaXbjoc+ZEZCRs1fb5SXpTfVIO/hvHYdt7zRbxcjGRnxiX 5A0BA1XAU0ppyT/vDryCt+SC4y3AMXqPV97Hg3yPntEmGLUWsc+hISasEqv2qZrvQHRi DqNqfxy7EOOx7zAjwhENCjkWcd+Y6DxG3vH0vxwdTW3FFpM56iJf/H21c+l1ETIJd8jU UVNw== X-Gm-Message-State: AOAM532emxV+Gb5nN2XMMWy+P8jGWVgwVGMG4pPuzmEEQY65OXFZOGQ5 45dsWCXTPSxFr8s5RyOgtzChb3xiUiNm0yhu+3Pl24YfFcA1wGh5Fwl1N/x8twACwQPn3Ah1Nvk MI7M= X-Received: by 2002:a7b:cc0d:: with SMTP id f13mr338757wmh.85.1632927291199; Wed, 29 Sep 2021 07:54:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLXZlznAPZKgpRzuRE7V8gLkxoXfILP5NbOO4+kJcZ9iY5YdFcl6JrhjKBdhDUSB7Y8BHgTw== X-Received: by 2002:a7b:cc0d:: with SMTP id f13mr338744wmh.85.1632927291032; Wed, 29 Sep 2021 07:54:51 -0700 (PDT) Received: from [192.168.0.36] ([78.19.105.235]) by smtp.gmail.com with ESMTPSA id 1sm2158407wms.0.2021.09.29.07.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 07:54:50 -0700 (PDT) Message-ID: Date: Wed, 29 Sep 2021 15:54:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Bruce Richardson Cc: dev@dpdk.org, ciara.power@intel.com, anatoly.burakov@intel.com, stable@dpdk.org, David Marchand References: <20210915141030.23514-1-bruce.richardson@intel.com> <20210924161842.2879019-1-bruce.richardson@intel.com> <6ea20d4e-a7dd-afcb-3ca1-ffc023114d72@redhat.com> From: Kevin Traynor In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/09/2021 14:32, Bruce Richardson wrote: > On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: >> Hi Bruce, >> >> On 24/09/2021 17:18, Bruce Richardson wrote: >>> When DPDK is run with --in-memory mode, multiple processes can run >>> simultaneously using the same runtime dir. This leads to each process >>> removing another process' telemetry socket as it started up, giving >>> unexpected behaviour. >>> >>> This patch changes that behaviour to first check if the existing socket >>> is active. If not, it's an old socket to be cleaned up and can be >>> removed. If it is active, telemetry initialization fails and an error >>> message is printed out giving instructions on how to remove the error; >>> either by using file-prefix to have a different runtime dir (and >>> therefore socket path) or by disabling telemetry if it not needed. >>> >> >> telemetry is enabled by default but it may not be used by the application. >> Hitting this issue will cause rte_eal_init() to fail which will probably >> stop or severely limit the application. >> >> So it could change a working application to a non-working one (albeit one >> that doesn't interfere with other process' sockets). >> >> Can it just print a warning that telemetry will not be enabled and continue >> so it's not returning an rte_eal_init failure? >> > > For a backported fix, yes, that would probably be better behaviour, but for > the latest branch, I think returning error and having the user explicitly > choose the resolution they want to occur is best. I'll see about doing a > separate backport patch for 20.11. > But this is a runtime message dependent on runtime environment. The user may not have access or know how to change eal parameters. In the case where the application doesn't care about telemetry, they have gone from not having telemetry to rte_eal_init() failing, which probably has severe consequence. I could maybe agree if telemetry was default disable and the application had set the --telemetry flag indicating that they want/need it. As it is, it feels like it's possibly a worse outcome for the user. thanks, Kevin. >> A more minor thing, I see it changes the behaviour from, last one runs with >> telemetry, to, first one runs with telemetry. Though it can be figured from >> the commit message, it might be worth calling that change out explicitly. >> > > Sure. I'll resubmit a new version of this without stable CC'ed and include > that behaviour change explicitly in the commit log. > > /Bruce >