From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1A7BA04A3; Mon, 7 Feb 2022 16:35:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43DDC410F3; Mon, 7 Feb 2022 16:35:36 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1A856410EA for ; Mon, 7 Feb 2022 16:35:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644248135; x=1675784135; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=g+LTrBw2DOJypfSc9zmXVvlDdQXgzkpl5xpdseaaiVU=; b=MptHlSSnTDSGbCIG/g6q7G49stXZqU6xb82rJj589f/XghwPi2deEjNb tUCSpaDtZrHzCtw5xIUlI4D8oNuKBydzDZietwlUBl1p6MaVqOS05RvlI x6X1XBR53ZmTz23qlI4B3BF9JN+mC9BeGaTzfBwjNNQ0U3+kCz7nnMti7 hHf8hlRrj9+FbpyK4zRFaGeV7KQkPXqXTTrXv6lpJdvayWh3tEmwUhDXH ZBoQPPAfDJau8nF99aUfslkzmft5DLg37FymjdPVMqSyUraILIuw5Lvmp /5SzHNeOsRtkg0mrEHpv+bMn3movQcpJyhnR2cUr3D+yUn5YdNB0WZ+Qa w==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="335140903" X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="335140903" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 07:35:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="628560332" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 07 Feb 2022 07:35:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 07:35:33 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 07:35:32 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 07:35:32 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 07:35:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBn17ej87O/42HXtpo6PyKydv1bABg2L2KuCwD0cdgVasUBpXkUUK8CS2ejjWElR7akUb2LhuYmRSJRyj+D9oz+Bio/hGR9ics0R+PyTfQojEWArmARjp0NgIedyJ/8goJnmG1X3VDrlPlSP5Pc3061Hgsg08tRMOECmfcEx7idxGKEVwj2ZLQ+9CDqQRXXmI8mdEwGx3gyBkle/hbFi6NT308/2DZnklIbitIcy/NdpIIUQCSKVUIZy3cREfKiLuU0a2+jUQOBvJUwPGW3wSkc4RIog0JE0jQ/W5ndThhpbLmRIDBjLyfUeeKsASh1N5izhIXXIZAIJLLZHDJJIww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w45vtpVE4igYo93qisXqyeoUySFeX9s9IJLM3245AUs=; b=fMPIm9gs1LC7LljEbgWXnP6j8oJNnrCbMnfG7VGTMvNipvMK4kKEbvSp8b/z49bNe1Y9EHqX5P7/ipPNy3mrMw3p2kRzNdUABNnyY+vC8W5w3pPGIlHTMNPjqh1tFPG4zrqTFUZlRIJA/crucBPmCeegnSOiNLrt+Ey3PNPvTMetHBTPmFvG8zBcaBTCjOhVLYpB4Z0wVkyZMF5mk2VsLDcqd16320TXz9TbYD6PAbbGpGuupngV8Z4K94CmxOuulXRAG/vRDqBjrYv7cpXoBV9xlvDEhXtNhu9GWId/RHBg3R1xtAEvNuPvyreaG3EpawC6Hro2a7nyiJsUwavu1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3015.namprd11.prod.outlook.com (2603:10b6:a03:86::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Mon, 7 Feb 2022 15:35:31 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 15:35:31 +0000 Message-ID: Date: Mon, 7 Feb 2022 15:35:25 +0000 Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Min Hu (Connor)" , CC: Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko References: <20220111115437.32855-1-humin29@huawei.com> <20220207014719.16611-1-humin29@huawei.com> <8b129213-8d64-0b9e-8bb3-5faa8bfdd2d4@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D86E79@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86E7A@smartserver.smartshare.dk> From: Ferruh Yigit Subject: Re: [PATCH] ethdev: introduce ethdev dump API X-User: ferruhy In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E7A@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0341.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf5f815c-0d39-4dd4-4002-08d9ea4f7975 X-MS-TrafficTypeDiagnostic: BYAPR11MB3015:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QlzXBXbeKn32rowbzgQCVqs/rI6tGX2C9Pg+H+BhbCVoN+UltLjjji1Mo7pimT8z0ITEi7X+yAtlDjj8b+83hq4oDlhlcoVsqUvM8tORSZJDWFxzB1ILtyqUyzmA4nHQRLcPDMt2/s68QleS43VTnxAZzEhmDgA1duypKQXvj4TtUz4064+Rw8VF/jUN0A/bB7e8KLrK+AJAnQJmOIv0N5d22e5RFW1t4s0EHudWF6Ui/Gy7oMbWuwsEgTLcOEBLYfQxT1GWbpHJYrbThMJpBQMYIC9GtJ4YzBklRrfkKXEQFUF1vT3aAdyP8Z+L7imHXR42T++BCnTC2Xbrn0DGZ9PcJDArebih08NeFkc7EYErIqthoI+0BPP1L5QPgAwdOC2PWbDwTHbcqcE5eIJC/6jQcCVqg8vRstkO8W1Bn7lDXOwPVYdW7Oj6OJqWQ7+Jds9qHlPblXsupVBWQ/upfNPGfSepA6zvAmJdLfb9y9cNTxxUnq2bG71z0bZRXaOsIAW8YdjQR/iBeF2mCejWpHLbXRmn+8Jbsbxm5r6eGh1X92XpGMjvfIoqlK0zaTLesa3if6QEjvWVWFKpoI53PpzTJ0xeUy37kOvWO9PMx/JrgF8SkZGiWJ5/MxWXpo2H50GJKLqWmYWpwVp7pFywuAgdBuIHeGmh5YoOEi3m8/2Vd1c+LuAe+5QXDAOzUJUOJTVgCKuqxbuxMNRvJgnAvw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55236004)(53546011)(6506007)(6486002)(508600001)(6666004)(2616005)(26005)(186003)(31686004)(36756003)(316002)(6512007)(54906003)(110136005)(66574015)(2906002)(38100700002)(66946007)(31696002)(66556008)(8936002)(8676002)(66476007)(4326008)(86362001)(44832011)(5660300002)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0FIaWZSVUdvL0NhRDFLTWYyVWx1T0ZyN1JxcDZLcGJBME40TTI3MnhtdFlH?= =?utf-8?B?TUtDaGk4blRyNVIwMzlzZUxsUG1FWDFXaDhDaTZxWm44NDJLYXlqUXdHUURs?= =?utf-8?B?MW5UaWZQdVZkNkEzTHoyL1VlWEEvZFR5TGtKVjJYNGNRamJnb0VCNWdiNFlR?= =?utf-8?B?UXI4UXdKdDhidFUxUSswR0dqWXhVb0NTZnU1bWJUdXdzZlVmRWJ2QVRqQVJ4?= =?utf-8?B?dWgrTnkxck1pSVZiSnRZS3FOOC81aEM4WGUyQmw2NWkzb1ZlbGFxazRxdVZV?= =?utf-8?B?d011MTc1K1NJN1dDVnhlMUZyM1VVQ2o2bUN3ZkNrL0tTT3JtM2FkNWNKOVVh?= =?utf-8?B?UkV3TlpKR0c5SzFUT1FMYlJNUkNXR3EwTnM5MFovRzQ2Wkt1Nm9oWTZoeWRi?= =?utf-8?B?UXJpb2xzSFMzREtvOWgrNjR1TWRyaWZIV3NZd09WelpXK29SakE3dzRtSUtJ?= =?utf-8?B?Ui8wVWRDQ0JRTjJDNnZGVVpMalJFandvandOTncyMUxLbEpzYnNHWDZPaGVL?= =?utf-8?B?VFNmZ2dqTEszUGRPelJrL0txa3BUc0RQOWxSNVJVT0pXa0p2bm5lcXM0MUI1?= =?utf-8?B?NTNkR1dta3FjcHYzRzFPZ2FOVDJuRDBHMldzd2FOZmpSVmNzaGNxOE5TTFBI?= =?utf-8?B?VFB1aFlQeXZsRE55MWx2YWx3RkNqTy9kWndrWkNOdzFjU3U0UkhXN0RTNXJh?= =?utf-8?B?eHoxUkRIUE5sOUJnY3g0a3lZd1RMZUtDUllIa3VSUTh2dElVMzVpUzcvRTlt?= =?utf-8?B?eEx2SGd5dzJWRUUwT3Q1Sk5FTlNqQ3hFMWVTSWZndk42TnpaOHZPaktEN0hh?= =?utf-8?B?aGpiV1A0bEZid3JhanhPTEhLRnNVQndKcnNiYTl1MGI3MUhVV3krUVJrNXZ1?= =?utf-8?B?QkRpcU9LaXl0ZjQ1OG0rRThBK1ZXQTFQNytKclovdU5VR09QN2pqV0RRYjMw?= =?utf-8?B?ZlRpYjIwbmhVdkZPUTgyYTBaczBXYkJNcDI0QmZvL3RLVEFLTjB1NjZmWGJ5?= =?utf-8?B?MlJNaGUyL1AvSjBuSlNHbkNPNnZMLytRRjNMTGE4YVhFejlNUnlQMllNMVNM?= =?utf-8?B?ejRnT2p0aVdETlQ4dG1meEdPTnJVMHZLOEVUVkFzVFo2VTFGNEFZT2FKMW5q?= =?utf-8?B?cVp6aFZCM2pNQUtHWFozU092WEZabW1HbVlkanRINlBZSlVnYitDaDFOVzJi?= =?utf-8?B?c25CMm5QTG9Nbk8zdGlIR2R4UzJ4VmxlZjFWK0pTN2FIcEtBTE9ienJxYzMw?= =?utf-8?B?YnV0aGpUZHJhaCtKUW5GTVo5SStsRyttUG12aFMxMDdDUVhjL3NMdmdvUzR1?= =?utf-8?B?ajhlckN4a3c5TVRQcUcyTmdhRCt2cWZaeHVsTFdSNzhoSXpUZnlJWWlqSWZK?= =?utf-8?B?ZlRLOVRXSWk5UGNHU0FYTXJRRjd0WGtDdDV5Zi9XSkhRbXBiOGR1U3ZRZXJ2?= =?utf-8?B?cXdqb3hBUEhrL0lEa2s4WW1wZGdZU3pvS2NwNWpuVnlPd3dXRGhkZFdHT2FB?= =?utf-8?B?LzNpQTBPUU5zcTg4M0tLWDk2QVh2dWpPaHJ0SXhrRkJMelJUZ0Vpdzd6NnU5?= =?utf-8?B?aUREYjlIcjF4Q3BlMUxPakZXN2dDeDA3Y09kTHFyMUpLZjJabk9US3E2THlk?= =?utf-8?B?VzlxV2ZQdnJoelRTR1llQStEekhrVXA0RnJvdEYvKytRMnU1QzVQUHYyc2VL?= =?utf-8?B?ZlNTVVBoL2NSeGpBOVdKUXhXVkRhY3lLeFF5S001M2ZqQTVwMU10UWZHV29w?= =?utf-8?B?ZEcxVjliMjI5MHA4aUQ2RFpxNktQZW1xNy9ZREpHb1JSMlgva1VZbzUzaGI2?= =?utf-8?B?SGZTVmlyazhiZ0VQdXhwT2x0NHpNTEJOdlJsSkw5ZXZyeEVRNUoxMFh1UldP?= =?utf-8?B?MG5PKzBWYUhnN3RxSFh0ODBGelBIV0tUWXRwQm9tTEk1U0JNMWdvVjBDOXE4?= =?utf-8?B?VFJpWW41dTVXS29tUzdKYnh0TlhFbXJTSVVERXBmZDE4ckVmcjUyRUt5Vk9h?= =?utf-8?B?MDR2YktQZEwwSjVoRTJ5RlJrMlNlOCtQazdKS0tqdlY1R2s4YTBPYTRLOFd4?= =?utf-8?B?RWdldVZLT0hHd1VuR0Y3NWFEOHo3cDBjcG9hZnNoZ2dRWGZLdXhsUktwUFJZ?= =?utf-8?B?NjA3MkhIc0R2Q0ZVZ01FRDF6bUlGdlJOaEhLNDlaUzg4VmtlNi81T2VSZElz?= =?utf-8?Q?ivz4uJnbk4DsZFVVyk4H1OM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf5f815c-0d39-4dd4-4002-08d9ea4f7975 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:35:31.3647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TDCxzpu652E0ALniOtUDwXxEl7YcYHiJwl8n1RI0e7F2iMZq7yMzF8Jl/JoJtvt3iQSrTLBlx76pBS/Yj5xdOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3015 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2022 12:56 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Monday, 7 February 2022 13.36 >> >> On 2/7/2022 12:18 PM, Morten Brørup wrote: >>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>> Sent: Monday, 7 February 2022 12.46 >>>> >>>> On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: >>>>> Added the ethdev dump API which provides functions for query >> private >>>> info >>>> >>>> Isn't API and function are same thing in this contexts? >>>> >>>>> from device. There exists many private properties in different PMD >>>> drivers, >>>>> such as adapter state, Rx/Tx func algorithm in hns3 PMD. The >>>> information of >>>>> these properties is important for debug. As the information is >>>> private, >>>>> the new API is introduced.> >>>> >>>> In the patch title 'ethdev' is duplicated, can you fix it? >>>> >>>> >>>>> Signed-off-by: Min Hu (Connor) >>>>> Acked-by: Morten Brørup >>>>> Acked-by: Ray Kinsella >>>>> Acked-by: Ajit Khaparde >>> >>> [...] >>> >>>>> @@ -990,6 +990,20 @@ typedef int >> (*eth_representor_info_get_t)(struct >>>> rte_eth_dev *dev, >>>>> typedef int (*eth_rx_metadata_negotiate_t)(struct rte_eth_dev >> *dev, >>>>> uint64_t *features); >>>>> >>>>> +/** >>>>> + * @internal >>>>> + * Dump ethdev private info to a file. >>>>> + * >>>> >>>> It doesn't dump the 'ethdev' private info, it dumps the private info >>>> from device. >>> >>> It seems perfectly clear to me. How would you prefer it phrased >> instead? >>> >> >> What described in the document is more accurate, >> "query private info from device". >> >> What we are dumping here is not ethdev private info, it is device >> private info, >> and we really don't know what that data may be in the ethdev layer. >> >> Also there is a chance that 'ethdev private info' can be confused with >> 'ethdev->data->dev_private' > > OK. Now I got your point! The difference is very subtle. > >> >>> [...] >>> >>>> >>>>> + */ >>>>> +__rte_experimental >>>>> +int rte_eth_dev_priv_dump(FILE *file, uint16_t port_id); >>>>> + >>>> >>>> What do you think to have the 'port_id' as first argument to be >>>> consistent >>>> with the other APIs? >>> >>> The _dump APIs in other libraries have the file pointer as the first >> parameter, so let's follow that convention here too. No need to move >> the port_id parameter here. >>> >> >> Yes, for most of the _dump() APIs, file pointer seems is the first >> argument, >> bu they are from various libraries. >> >> Within the ethdev APIs, I think it makes sense that all APIs start with >> 'port_id' parameter for consistency, like done in: >> rte_flow_dev_dump(uint16_t port_id, ...) >> >>> Only rte_dma_dump() has the file pointer last, and I didn't catch it >> when the function was defined. >>> > > OK. Then I agree with you about following the convention like rte_flow_dev_dump() with the port_id first. > > I even think Connor got it right the first time, and I proposed following the other convention. > Ahh, may bad I missed that, sorry for not commenting on time. > It's not easy when there are two opposite conventions. :-) > Yep, that is the main issue.