DPDK patches and discussions
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Vadim Podovinnikov <podovinnikov@protei.ru>, linville@tuxdriver.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] add drop statistic for af_packet
Date: Thu, 28 Nov 2019 15:03:21 +0000
Message-ID: <cf03b5bc-3cf2-795f-8107-ba8de273dfe0@intel.com> (raw)
In-Reply-To: <20191126154744.25342-1-podovinnikov@protei.ru>

On 11/26/2019 3:47 PM, Vadim Podovinnikov wrote:
> From: Vadim <podovinnikov@protei.ru>
> 
> add drop statistic for af_packet
> 
> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
> ---
>  drivers/net/af_packet/rte_eth_af_packet.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index f5806bf42..eee0fbce2 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -327,8 +327,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
>  {
>  	unsigned i, imax;
>  	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
> -	unsigned long rx_bytes_total = 0, tx_bytes_total = 0;
> +	unsigned long rx_bytes_total = 0, tx_bytes_total = 0, rx_drop = 0;
>  	const struct pmd_internals *internal = dev->data->dev_private;
> +	socklen_t sock_len = sizeof(struct tpacket_stats);
> +	struct tpacket_stats st;
>  
>  	imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>  	        internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
> @@ -337,6 +339,12 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
>  		igb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;
>  		rx_total += igb_stats->q_ipackets[i];
>  		rx_bytes_total += igb_stats->q_ibytes[i];
> +
> +		memset(&st, 0, sock_len);
> +		int rc = getsockopt(internal->rx_queue[i].sockfd, SOL_PACKET,
> +					PACKET_STATISTICS, &st, &sock_len);
> +		if (rc == 0)
> +			rx_drop += st.tp_drops;

stats values should be preserved until it is reset, in this implementation
'imissed' values are values between two stats calls (since PACKET_STATISTICS
resets the stats after retrieved).

Can you add a field to "struct pkt_rx_queue" to save the dropped packet values
and send the accumulated values in each call?

Also need to add resetting this value in 'eth_stats_reset()'

>  	}
>  
>  	imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
> @@ -349,6 +357,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
>  		tx_bytes_total += igb_stats->q_obytes[i];
>  	}
>  
> +	igb_stats->imissed = rx_drop;
>  	igb_stats->ipackets = rx_total;
>  	igb_stats->ibytes = rx_bytes_total;
>  	igb_stats->opackets = tx_total;
> 


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191125180325.2E2284C9D@dpdk.org>
2019-11-26 14:32 ` [dpdk-dev] [PATCH v2] " Vadim
2019-11-26 14:45   ` Ferruh Yigit
2019-11-26 15:47     ` [dpdk-dev] [PATCH v3] " Vadim Podovinnikov
2019-11-28 15:03       ` Ferruh Yigit [this message]
2019-11-29 14:59         ` [dpdk-dev] [PATCH v4] " Vadim Podovinnikov
2019-12-02  9:40           ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf03b5bc-3cf2-795f-8107-ba8de273dfe0@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=linville@tuxdriver.com \
    --cc=podovinnikov@protei.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox