From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DEA742D8D; Thu, 29 Jun 2023 17:52:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BAB540EDB; Thu, 29 Jun 2023 17:52:59 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2048.outbound.protection.outlook.com [40.107.237.48]) by mails.dpdk.org (Postfix) with ESMTP id 2EC54406B7; Thu, 29 Jun 2023 17:52:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PNiUtcDENUOId4R4VUj8cCVlikC92VGsC4DRjqm20AOIvMGHGj0swl3HLXAudtCHIIFcSdGZCiHxK0261LSfPF7lA36ivaG/cwhjtoJxLTIg28GREKCGAmoyajDeYo5NPJdY2N5RpgG+DZZHxzfkWlIWa/Kd4KkiQeYNYvi/zc6MJjFJaTsGv35AFT2NvGw133R4tT6naujxmN+CKLqMDH5J5BA6eylbGHY8DtD6qVc9DRRsUNp2qZEk7U/vLi/DeIDKx4iTb+xNTf3WHbNqefnc2SQuyZxz4Yi8ZWocOchufUgtXNHHDY1z7t0bw5fFBqnyzcP0e5YgYlvpsIfE2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YeBXrvv+9N2gKZrHR/PObzLODKla+yIlx0+y3EVl6go=; b=n6sOHYGXeXjIDh7L69KyadwExkqvf1pX7dx4Ag148G8ph70HeSWlkS8AlOPX40WLy/Jt/rFzry2ZgOytbccyAaAcFf1r7Zw3h4a5KTUtrqPbTmDKvfrhXg3/Bx31fQNDH2ne4Ftwkzz5GSrlJgcLeb8UmMDfqosMkuw2t9gfwE5Yu5Rq6532kFceADO/4vWmxZVrXpRydLj0PsqncA+HOJA80WR5UG+nZpSFzfEH0kbCBRZbOS6cv0ojilwUYJyNNa+RqKVV4cATVfOCmLy+Sy0I8ypcFJasLpGXVY4WuFjXRJQDES0wAjQO2hJCR3C5du02zdjoTqlofAk5VJjNqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YeBXrvv+9N2gKZrHR/PObzLODKla+yIlx0+y3EVl6go=; b=jHfMXwVktCj6+C0tEwCbTujgUU5XGBnfMU5oHkY9UQPDjz07fhkhXI6GRPf2BGfmkuq1JqGZqS2vas3syZasFiixqKZ9ue6piloU9Lmz93NibcJBZVsrj9Li7ikSBtU08MQwbp67mpWwP7XwFeZU/BCUph1vSuNZz5yFufiVrHI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8351.namprd12.prod.outlook.com (2603:10b6:208:40e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 15:52:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Thu, 29 Jun 2023 15:52:55 +0000 Message-ID: Date: Thu, 29 Jun 2023 16:52:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org, lihuisong@huawei.com References: <20230626124332.28157-1-liudongdong3@huawei.com> <20230629132127.7508-1-liudongdong3@huawei.com> <20230629132127.7508-3-liudongdong3@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config In-Reply-To: <20230629132127.7508-3-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8351:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a4bc6d1-b9e8-436d-6b74-08db78b8e6fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9qtcTYkRewzL65mGDHquJRc4tV3skIz0T94LroKNTiRRRR4Kik1iskzQIkSrfiaRqR/8yTaVizig5P9TzVXmqezsVWVUzT69kBZIlGxx7haCFA6jTOdONNsiaHGpqFU4Hf2I0irexcbQ224ZjCnNgcWMa1aHiLSBUqOoEKqERoA+tyEnBsM7I0rzvPDjGUuN3H8N8/8kLxkyTyIw0ArYoN1T2wjaazM1yXRfTWjgwjj5d/UIsMkpxQhxdM+SmIFuwG8x0b5UtrI4h5qAHrzrhxFbNM5k94OmiEV/oVbUzm1BhIcbOus4gG8g3ZFQ7ysaNylVrQ7Volc6dOFv9WvFeCfEm2lwC/v6DrFZLOdrt49Ace4KGaAriHT560jObbcwLn6rTgNgnkbFv8Qjwf5vf1BsVHKt+3LYWmzZ2OELvSnNJd3Avzs3hRVqtdJwBapK8xP7BV/v56++v46BD+EAF47NyuQAQSkqssy8sycnO9GLxkz8LjmxP5Got1dGnSGeMYmOYyl0JiiKoP9aJyp6zOOKycCZSAKRWUQA9vlWUad5eWAslliO+rKOcRbdroABgVqbKTox0WwSiKP8IzKo5hfLzRpJxKnRwa5M0qKmreH7v+QFdI/whMhQcvrZ39344ptT+zIE8YspynFOMNJu2w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199021)(44832011)(5660300002)(31686004)(66946007)(66556008)(4326008)(66476007)(478600001)(36756003)(316002)(8936002)(8676002)(2906002)(6512007)(6666004)(41300700001)(31696002)(6486002)(186003)(6506007)(53546011)(26005)(86362001)(2616005)(83380400001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S20rRUJEdEorS3EvWWJDMHJFUWEvdWRBYUN0Q2tsc0lBejM5TUpMUWRWajBE?= =?utf-8?B?N3czVHRHRmhIQVVWRnI3UmppV0lsUWF2S05pWUxhaEVic2FWWGdBVTFkT3g5?= =?utf-8?B?MDZMTmUxVlZicSsvWmZkZGJKRUlKSm5NQklsakJLbEMveHJuNFJWZVRtNVlo?= =?utf-8?B?SmxNVHdrQ2IwVlpMZVQyNno2djV3SWp0RnUwam9Jb1dWSnlLNnZ3WXlLTlNL?= =?utf-8?B?WDBqWUZPdnpXK21Ma1ZQeTF6dGxmVkJwVkw2eW0vZWYrNmp0SURVZTlIZXRy?= =?utf-8?B?UXBsRC9IeW55aHBvNjZ6d2g1Q1E3TEtsa2tpUEhHeEdTYkJES3h2UjEySVNj?= =?utf-8?B?YmRhU1duaGpzZHhrb21jWVNSSDMrTWs4SmhpZXNKZ2YyM0pRbS9sZXJIcUhw?= =?utf-8?B?TnJrR0N1RkgrMlpaUzdGejJzYkp1ckZEbzRXTUtTWWlIMXFlM25raGxOb0FJ?= =?utf-8?B?Y0RqM0FqaWlld3NQeERpb1RBcjNTSmZ6YXBFSDdJNXk3U29UbmN5cDdaY2Zq?= =?utf-8?B?eUlBaUxuUFNPWTZBeFVCci9BcXpVZHoyZXVaQVdpb3ljSzV2N2gyOFozUHA3?= =?utf-8?B?d3JkcjkybUZMUDRIOHkvdDFlSm84Y3RsZERva0kxakxqMXZLelU2c2IvS0E0?= =?utf-8?B?K1RYS1RUdlFZN2IwZkJSTndSUFJBYUZsRDE0NU5UTjc0QTNhdm5sM3VjSEZP?= =?utf-8?B?bzVLbUVvRU5Xb0ZsdkFlZStTVE83TlpkSE9vTENTdlhyTjNoMjhzVjlrUVRZ?= =?utf-8?B?YnJuNWpHY3VqZjViWFlCS2thWW1aOWk2Q1QwSzMvM21uTnZVOFEzVldzdFpu?= =?utf-8?B?dXVYU1hUWlVsblg0aXhvbFZhN3ROTU5ZbUxiak1lRUU2ZlVGNGJnK1YrejQv?= =?utf-8?B?ZzF5aHMzQkxMRmVVMGttK0xEUVlhcUxkZVVxSmlHczZORWc0akRJN1hGcFFj?= =?utf-8?B?bGVuUy8xMllvTG9odlMvR1lYTGpDdUh6ellXczlhVkR0L2piVTRwRFFjVCtU?= =?utf-8?B?Wm8rcHhERjlmWkUySlRtL0V1YmVVVDlpQnVpaHpoY3E4YkRzOWhKbU82dXZa?= =?utf-8?B?bDJPWnQvZjVIS3RHQjFOU01vM3pYNlpmaUhWYUt0NGcxRlNRbndDbUNEV1Fu?= =?utf-8?B?Z3hJbXNUaTFQQjlSL0hqbWF6S3BubEhEVVVyYmcrZ1A0a1YxWmhoUUtGQ3M0?= =?utf-8?B?c2FaZVZNVDUrNG52Q1ptMkg3VFhwd2R3anR0MmVqV0hTeHNnaVZTQ3N3OW9H?= =?utf-8?B?dTNlbW9wSjl3MVgrbUxHS0FVNHRkWENHbWhRd1RwZlZkQzV5d2VZSUt4UzR1?= =?utf-8?B?TUdsYlpmcGcxVlhpY1dTRTZpdS90dmEwRE84UlN4R0Zjc3JsaFFrSkkvaXNk?= =?utf-8?B?Wk45YWY4VUVHdENtdERVMWp2dVZYdlpaWWQyN2NwZWxKQ1dyRE9TdHRUYVFq?= =?utf-8?B?dHdTU09kT1hkQ3dObG5vLzBRbElVV2lOdUljYThmK29yT2NRMmUwakxubHlo?= =?utf-8?B?dWsvSTlMN3Y0RC9HZ0Z4cGFNbXFCSnZadmVRQXo3VDIrYUNLTytxRnIrejVv?= =?utf-8?B?cXpiSmJyc2ZMRTU3T1g2Z0JPT2wwc1QxdmpoMVQrbG5UVmhWMFFUS21VdEdk?= =?utf-8?B?RzNHenlZVjZvVjlsd0V4cFYzNmNycEZiak1GQlhaZGxQZ2wvMzRwbnhBMWp4?= =?utf-8?B?b2JhR2E3UFJrdVNWYTlGWGsyQko4VWdwa3ZKaTc4SFlMQmhUN08vMm9UUUJQ?= =?utf-8?B?U1FUb0g1WTlMRGM1QzF5NG03NE9BVXJzUEI4ZjhNMFB1M2ErdzM5eXBOZ21J?= =?utf-8?B?K1BWL08wazBvNjR4Y3BBZkhXbmVpdHRMKzBLd2Ftcjh6Umx0L2t5eWV2M21W?= =?utf-8?B?K2RkZHYxLzlvTWsxaGFoRFpHWm5TMGdZNU9sbWdjUVgvdmo4THplcytqMmZa?= =?utf-8?B?aVBpQVBDbjM0blZMOWpWdjRjMGMwelk3VHlSY0c0Q0MrS3NIN0FTVXlMUjBB?= =?utf-8?B?RDlINjhPNWlQTGh1QjFOcUFha2tyTStHcVp4UGVzWkJaVzB1bjRodXNqTDUw?= =?utf-8?B?dlc2dzVqOTlkRzR2cmlBVmt4N2luZGRvY0ppYzJ1bitYRHdXR0lZUy9ldnpD?= =?utf-8?Q?bkUXtCAZL2+7jii1I2ZkVh4bt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4bc6d1-b9e8-436d-6b74-08db78b8e6fd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 15:52:55.0036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oHOx4k0kbajT88fYNOgC8A47Xj3XVALXeNFoic6yZdqGaoDDTlLXEYb4ReidC0bs X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8351 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/29/2023 2:21 PM, Dongdong Liu wrote: > diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst > index 5373ec5a8f..001ccbdb62 100644 > --- a/doc/guides/nics/hns3.rst > +++ b/doc/guides/nics/hns3.rst > @@ -140,6 +140,32 @@ Runtime Configuration > For example:: > -a 0000:7d:00.0,mbx_time_limit_ms=600 > > +- ``fdir_vlan_match_mode`` (default ``strict``) > + > + Used to select VLAN match mode. This runtime config can be ``strict`` > + or ``nostrict`` and is only valid for PF devices. > + If driver works on ``strict`` mode (default mode), hardware does strictly > + match the input flow base on VLAN number. > + > + For the following scenarios with two rules: > + > + .. code-block:: console > + > + rule0: > + pattern: eth type is 0x0806 > + actions: queue index 3 > + rule1: > + pattern: eth type is 0x0806 / vlan vid is 20 > + actions: queue index 4 > + > + If application select ``strict`` mode, only the ARP packets with VLAN > + 20 are directed to queue 4, and the ARP packets with other VLAN ID > + cannot be directed to the specified queue. If application want to all > + ARP packets with or without VLAN to be directed to the specified queue, > + application can select ``nostrict`` mode and just need to set rule0. > + > + For example:: > + -a 0000:7d:00.0,fdir_vlan_match_mode=nostrict> '::' doesn't provide pre-formatted text without an empty line after it, I will fix this while merging, but other device argument documentations have same problem, can you please send a patch to fix it?