From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Renata Saiakhova <Renata.Saiakhova@ekinops.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] drivers/net: Fix in e1000 and ixgbe HW rings memory overlap
Date: Tue, 5 May 2020 12:36:33 +0100 [thread overview]
Message-ID: <cf2201da-281e-3ce8-6581-c8de3b7bd745@intel.com> (raw)
In-Reply-To: <22376860.ouqheUzb2q@thomas>
On 05-May-20 11:59 AM, Thomas Monjalon wrote:
> 05/05/2020 12:28, Burakov, Anatoly:
>> On 03-May-20 5:26 PM, Renata Saiakhova wrote:
>>> Delete memzones for HW rings in igb and ixgbe while freeing queues
>>>
>>> Signed-off-by: Renata Saiakhova <Renata.Saiakhova@ekinops.com>
>>> ---
>>
>> +Thomas
>>
>> Should this perhaps be fixed in all drivers, not just ixgbe/igb? Is this
>> safe to do in multiprocess? I'm not too well versed in ethdev mechanics
>> when it comes to multiprocess, presumably the application itself is
>> responsible for synchronizing access to ports, so freeing the resources
>> should be OK?
>
> The application is responsible of port policy.
> If the application decides to close a port,
> it must be safe in all threads and processes,
> meaning it is application responsibility to not refer to port resources.
>
> About fixing in all drivers, is it something missing in other drivers?
>
I can see several other drivers using the dma_reserve API, so presumably
they would suffer from the same issue, unless they use this API for a
different purpose.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2020-05-05 11:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 16:26 [dpdk-dev] [PATCH 0/2] Memory corruption due to HW rings allocation Renata Saiakhova
2020-05-03 16:26 ` [dpdk-dev] [PATCH 1/2] librte_ethdev: Introduce a function to release HW rings Renata Saiakhova
2020-05-05 10:25 ` Burakov, Anatoly
2020-05-05 10:45 ` Burakov, Anatoly
2020-05-05 12:49 ` Renata Saiakhova
2020-05-05 13:36 ` Burakov, Anatoly
2020-05-05 15:47 ` Lukasz Wojciechowski
2020-05-05 17:25 ` Renata Saiakhova
2020-05-05 17:31 ` Lukasz Wojciechowski
2020-05-06 10:14 ` Burakov, Anatoly
2020-05-03 16:26 ` [dpdk-dev] [PATCH 2/2] drivers/net: Fix in e1000 and ixgbe HW rings memory overlap Renata Saiakhova
2020-05-05 10:28 ` Burakov, Anatoly
2020-05-05 10:59 ` Thomas Monjalon
2020-05-05 11:36 ` Burakov, Anatoly [this message]
2020-05-05 11:01 ` [dpdk-dev] [PATCH 0/2] Memory corruption due to HW rings allocation Thomas Monjalon
2020-05-05 11:19 ` Renata Saiakhova
2020-05-05 12:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2201da-281e-3ce8-6581-c8de3b7bd745@intel.com \
--to=anatoly.burakov@intel.com \
--cc=Renata.Saiakhova@ekinops.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).