From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B13A04B8; Tue, 5 May 2020 13:36:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71DCA1D5D2; Tue, 5 May 2020 13:36:38 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 794951D5BF for ; Tue, 5 May 2020 13:36:37 +0200 (CEST) IronPort-SDR: CE0oTvG5fkcVH9IQ2UgkZ9JgGl8C5mreAdoNFOx1U8uxiARdmw0/2NGP0v5HJzM86fALWOyShM nlgkQOm1oyJw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 04:36:36 -0700 IronPort-SDR: JR9d0W8RHaomySvbKYBouS8xRn8TiT2V4RFGvttiL77qIMMzCRoIcjLSbRnrGFhOeO08zecrdi AtLv/xmop9EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,354,1583222400"; d="scan'208";a="304452706" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.197.31]) ([10.213.197.31]) by FMSMGA003.fm.intel.com with ESMTP; 05 May 2020 04:36:34 -0700 To: Thomas Monjalon , Renata Saiakhova Cc: dev@dpdk.org References: <20200503162636.5233-1-Renata.Saiakhova@ekinops.com> <20200503162636.5233-3-Renata.Saiakhova@ekinops.com> <1694bc99-39ee-35b7-c316-dd2f00a73069@intel.com> <22376860.ouqheUzb2q@thomas> From: "Burakov, Anatoly" Message-ID: Date: Tue, 5 May 2020 12:36:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <22376860.ouqheUzb2q@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] drivers/net: Fix in e1000 and ixgbe HW rings memory overlap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05-May-20 11:59 AM, Thomas Monjalon wrote: > 05/05/2020 12:28, Burakov, Anatoly: >> On 03-May-20 5:26 PM, Renata Saiakhova wrote: >>> Delete memzones for HW rings in igb and ixgbe while freeing queues >>> >>> Signed-off-by: Renata Saiakhova >>> --- >> >> +Thomas >> >> Should this perhaps be fixed in all drivers, not just ixgbe/igb? Is this >> safe to do in multiprocess? I'm not too well versed in ethdev mechanics >> when it comes to multiprocess, presumably the application itself is >> responsible for synchronizing access to ports, so freeing the resources >> should be OK? > > The application is responsible of port policy. > If the application decides to close a port, > it must be safe in all threads and processes, > meaning it is application responsibility to not refer to port resources. > > About fixing in all drivers, is it something missing in other drivers? > I can see several other drivers using the dma_reserve API, so presumably they would suffer from the same issue, unless they use this API for a different purpose. -- Thanks, Anatoly