From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 203C1A0032; Wed, 11 May 2022 17:31:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC31840DDD; Wed, 11 May 2022 17:31:33 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 3A3DC406B4 for ; Wed, 11 May 2022 17:31:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652283092; x=1683819092; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ETFIuw/lpRhiGttqV5EQhHVD80NzkAfWJhkh/m0mGbU=; b=KKpBCJBpBLIMkQf8thiW279FDdVTkoGPs17FO+aO+vbJxJILAc9CbwCo fd5/XI0aeonqhAivsH8OwX8uPTcmD3Zw7p+ism16adviXIkuyfsnPlP2V wpUZM17Y3Qoe6L1dLUFqwiScQ2FluZj8dmVsAtoj80xdlqn14hCN2i6ez aEp8fi+CNvRV6wPb+9Z2g35bOoE0dcZ83SfwkQSV/wemXGbS/S+j69SIm 5MoTJe5pZI8aIEsSgy78qO1ns2L2hzm68mzBPJbkgmwFqM2THXjX6tqn+ ln0l9DfNg5TRNpYrLPxQ5EFufe8b6z35P22utRjTPVxIjDIV/sMRoOCJn Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="249627837" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="249627837" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 08:31:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="711526605" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 11 May 2022 08:31:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 08:31:30 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 08:31:30 -0700 Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027; Wed, 11 May 2022 08:31:30 -0700 From: "Zhang, Qi Z" To: Thomas Monjalon , "Wu, Wenjun1" CC: "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v1] net/iavf: fix resource leak issue Thread-Topic: [PATCH v1] net/iavf: fix resource leak issue Thread-Index: AQHYZAuwVaVdh/pZMk2oX19VCKhiva0ZkVRQgACpV4D//5UiAA== Date: Wed, 11 May 2022 15:31:30 +0000 Message-ID: References: <20220510005425.1648591-1-wenjun1.wu@intel.com> <2551212.tIAgqjz4sF@thomas> In-Reply-To: <2551212.tIAgqjz4sF@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 11, 2022 10:52 PM > To: Wu, Wenjun1 ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue >=20 > 11/05/2022 13:46, Zhang, Qi Z: > > From: Wu, Wenjun1 > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > Coverity issue: 378017 > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration") > > > > > > Signed-off-by: Wenjun Wu > > > > Acked-by: Qi Zhang > > > > Applied to dpdk-next-net-intel. >=20 > In the title, the word "issue" is useless. > It would be more interesting to precise where is the leak. >=20 Added below into commit log in dpdk-next-net-intel. kvlist should be freed before return an error due to invalid quanta size.=20