From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2102642BA3; Fri, 26 May 2023 05:41:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1C8840A89; Fri, 26 May 2023 05:41:19 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 517B640A87 for ; Fri, 26 May 2023 05:41:18 +0200 (CEST) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QS9gs6TQzzTkr3 for ; Fri, 26 May 2023 11:41:13 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 11:41:16 +0800 Message-ID: Date: Fri, 26 May 2023 11:41:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3] usertools/telemetry: fix unused parameter To: Samina Arshad , CC: , References: <20230518134730.68538-1-samina.arshad@intel.com> <20230525155048.523875-1-samina.arshad@intel.com> From: "lihuisong (C)" In-Reply-To: <20230525155048.523875-1-samina.arshad@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/5/25 23:50, Samina Arshad 写道: > This bug fix ensures that the runtime socket path is generated > correctly, based on the user-specified file_prefix value, > resolving the issue that occurred in the previous implementation. > > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument") > Cc: lihuisong@huawei.com > > Signed-off-by: Samina Arshad > Acked-by: Ciara Power > --- > v2: > Made changes for previous commit to be efficient. Removed > "args" from "args.file_prefix". > --- > v3: > Edit commit body by removing stable@dpdk.org from cc as > the fix is not needed to be backported to 21.11 or 22.11. > --- > --- > usertools/dpdk-telemetry-client.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py > index d6718ca5b0..e3bb1c9ee0 100755 > --- a/usertools/dpdk-telemetry-client.py > +++ b/usertools/dpdk-telemetry-client.py > @@ -55,8 +55,8 @@ def getFilepath(self, file_path): > # Gets arguments from Command-Line and assigns to instance of client > self.file_path = file_path > > - def setRunpath(self, file_path): > - self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix), > + def setRunpath(self, file_prefix): > + self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix), > RUNTIME_SOCKET_NAME) Apologise for the mistake. Acked-by: lihuisong@huawei.com > > def register(self):