From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ktraynor@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id D0DB65689;
Wed, 6 Feb 2019 16:54:13 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 01B3589AE3;
Wed, 6 Feb 2019 15:54:13 +0000 (UTC)
Received: from ktraynor.remote.csb (unknown [10.33.36.135])
by smtp.corp.redhat.com (Postfix) with ESMTP id 2734467634;
Wed, 6 Feb 2019 15:54:04 +0000 (UTC)
To: Yongseok Koh <yskoh@mellanox.com>, olivier.matz@6wind.com,
shahafs@mellanox.com
Cc: dev@dpdk.org, arybchenko@solarflare.com, roszenrami@gmail.com,
david.marchand@redhat.com, stable@dpdk.org
References: <20190109085426.39965-1-yskoh@mellanox.com>
<20190114211622.6900-1-yskoh@mellanox.com>
<20190114211622.6900-2-yskoh@mellanox.com>
From: Kevin Traynor <ktraynor@redhat.com>
Organization: Red Hat
Message-ID: <cf42c729-1127-7153-835d-cef7ef9ce5d4@redhat.com>
Date: Wed, 6 Feb 2019 15:54:04 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20190114211622.6900-2-yskoh@mellanox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.26]); Wed, 06 Feb 2019 15:54:13 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on
replenishing Rx buffer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 15:54:14 -0000
On 01/14/2019 09:16 PM, Yongseok Koh wrote:
> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed
> to be accessed as it is static and easily calculated from the mbuf address.
> Accessing the mbuf content causes unnecessary load stall and it is worsened
> on ARM.
>
> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx")
> Cc: stable@dpdk.org
>
This is using the API introduced in 1/2, so it's not really suitable for
backport. Maybe you want to send an alternative for stable?
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---