From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0060.outbound.protection.outlook.com [104.47.33.60]) by dpdk.org (Postfix) with ESMTP id 64220201 for ; Fri, 27 Jan 2017 11:20:04 +0100 (CET) Received: from DM5PR03CA0020.namprd03.prod.outlook.com (10.175.104.30) by BN6PR03MB2466.namprd03.prod.outlook.com (10.168.223.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Fri, 27 Jan 2017 10:20:03 +0000 Received: from BN1BFFO11FD044.protection.gbl (2a01:111:f400:7c10::1:125) by DM5PR03CA0020.outlook.office365.com (2603:10b6:3:118::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Fri, 27 Jan 2017 10:20:03 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD044.mail.protection.outlook.com (10.58.144.107) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.874.2 via Frontend Transport; Fri, 27 Jan 2017 10:20:02 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0RAJw9k014094; Fri, 27 Jan 2017 03:19:58 -0700 To: Bruce Richardson References: <2358632.GCFl4gnRC2@xps13> <7fb35576-ba10-019a-a6ba-e38418e03848@nxp.com> <20170127101304.GA69896@bricha3-MOBL3.ger.corp.intel.com> CC: Thomas Monjalon , "Van Haaren, Harry" , , "Yigit, Ferruh" , Igor Ryzhov , Steve Shin From: Shreyansh Jain Message-ID: Date: Fri, 27 Jan 2017 15:54:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170127101304.GA69896@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131299860025791158; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39850400002)(39450400003)(39840400002)(39410400002)(39380400002)(39400400002)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(52314003)(24454002)(377454003)(199003)(377424004)(2950100002)(6916009)(5660300001)(23746002)(54906002)(6666003)(626004)(81166006)(305945005)(36756003)(2906002)(68736007)(76176999)(54356999)(189998001)(8936002)(33646002)(356003)(50986999)(86362001)(97736004)(93886004)(38730400001)(110136003)(229853002)(31696002)(53936002)(77096006)(65826007)(4001350100001)(31686004)(230700001)(106466001)(85426001)(50466002)(105606002)(4326007)(104016004)(65806001)(47776003)(92566002)(81156014)(65956001)(8676002)(64126003)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2466; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD044; 1:TGOpJxvLkmXhW70S7QHVTxpS6n83qPcKLvwJKKk5ifjsbAjVZRS796iwbesGOjuFOohP4LTwQKgH0tmzZLWrXFX4NFzxP/7qVWRAmXx3XoyLUthzvjn2z+xuWI4ojdMpr9e3pjByq+Pto5XyXyhQAEW/ctPzW/ApZaII7W2tmH6SlzkJPPRV+nZnnRJDfvf7v6EgBxcOfZdBFsaeIEwDqPJabTAVReEfmcbTCl13xdWMqIQge9/39+jS/XpFr3vJGifCFKqJ6AifHlYYrC9AkXOjC7sq07OWtU85p/Sdm8xNpFKKNvk4Yta7H+qusHInFkA/9hiqCjDoN0hS41h7xTuuf3hkShaiLSHV9xKXsh91HGtQwFdDdtc0dnObBqD9QW/hNrHTRvTNkS3S43KnqsL5TWsscxCpcc2AzUVB3o12IAzf91b5SbJI0CFr7eefOTL8s9W2sS5Q2lEnEsnEqXZohzcGMwb67bvs74H2rRBpPyHO2zgjBnjo24NpG+qvT4krv46d12D7vMJ7xaUHXSEDYCEBpeb5rTUilPfBgAoNvP0tFpiLoKcTOJ/XagfYWkkyp5OgEGOsGeIsU2lM+sAFtjxqH2aTeRlMbMVQGplXDen3fG3W3b22tbZonxa5 X-MS-Office365-Filtering-Correlation-Id: e88a82c2-ccbf-46a9-8ff4-08d4469e0e57 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 3:C7hFKf+bNCVbsj1RG5vL+tdaftuZxKFSBm1GnQ5BsEbu4iHP6gD2IkJ9A+aMdnQAFXHqyAKTT37yBFOjfMEoiPcY8ixdznNIMTx6T5pdmR7tdg3iMdtVPy85tjbfg1wpgy+eiKTOwA6tRsm9YOcJwC0t79R2fnzDJldcuzLEswtr9DcVJloiXhhEeSHZtTt3sHYuhLuO4vRYfVda28fh6RIf2VpX3aWUwV2RWYXnyT4RFQH/DhxL3e4k3XIAs5Ok/5f8dd4EY8s1UV7oiH85tkyKKlT/mqRh7/OhMFGwxc3rb7NcK5SRKT9teZsFBDbUBRi39feihMuxs8NNpzIbbol2P52O3vgoby4hWPbjo+ZGxVdrDoCg1raINMWajQjK; 25:PRuBtYaeXiBgpjtP1FOB/IE3qvJMG4wfQc5tlChm5AYWWf/FeKbIfDQHgd3MOYf4uJusbJCYQke1c8lwdcH3R4pM7RJcaYSYUlfvpf5ZdDrottRJ3Paj7wY9jFbwnqTe2S6zNTvPVqZHmphhyK/4UQCcm0QwnR5CBdAQi2pnc9W0EwEYTLmerj6ZgtC5v0LTWNvuG/VDdo3c4wQgnfGGRkRtR4TpHJcjYYTFjs9IuWmd8alsO1WVNvODX8SJzql8xzV10bF0+WbPXwxB2Z3v2okKdDyJ+CN6AqdrnKZm0y4rvibNt3w/lxovooKOx5a1u81Lik1wRWBhchgQhJvqT1ailLUgp1Cwju+NjKFuAvLIVgPnjl3+OcTDAiuLvVC6jWK5JRuEWIyE9+FP7JcOFW+tvddb38rUsYNDHZinTfYNU7gcMQriQ9rdWdeoO9DqHcI3yUuh5qdymuo9f34Ntg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 31:b194R3gR0q2QhYxcs4WOPAcoOZ8n/2x6OrBX0hYy7nPi8wKntwQdWMuQBnnCHT5aNZjPMe+5AwVcHv48UNt3rvy5A6lkXTrGCrfooodTMoEwwSOwdoVuG+DBFwYd0blSB6rEwPBOOV5t9/2EQTIUOwdwky3ELk7fYO84qyOMpAQNiTYTaAbP1omOvOS/DcwrZ60Im2Y53KuiiTQWqS2/knZ7PuqLQxQiIO13yDD9bKkjGiJNPzSp2UsD8S3faqRx269vV2YJ7rIEv94BZ5UNmQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(100405760836317); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13018025)(8121501046)(13024025)(13023025)(13015025)(13017025)(3002001)(10201501046)(6055026)(6096035)(20161123559025)(20161123561025)(20161123556025)(20161123565025)(20161123563025); SRVR:BN6PR03MB2466; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 4:CoB+n+dhwceLp+lsXFuUyLhJQm1f6b4NSqX9fF1u1qLECZWuPeCg1Ge1olutJmLPBP7wXdvez5hDRqRDrElq+rQoYlbk1Rm4f+A8n9kH6H2nvAkglcFIzaQ0Jd9FAb4oL2EKSjtB17F/lTtwjGYERCynm1jzS4p5dLi3T3AgZ1U8TMdTXzVZTB44dZbFYp39dBn8AHTmlDTs5cg/6/37y4fahyfTPnAsoU5cYVSH7JcrUf3v8BXuZkhKcL8O/DEirj/teyOAv4XpFsWn9++DD/mGSzfTakUR3pX/GyTAPjRuLXxrykuVqgKXmc4emmt3CLPk4pKXVuY+w1V1OJwYC+gzfGY7mrhn7Bj4v3mVI4do8ZUS8uX2fo9uTXT/SGI5dzB9ekayq2Do4j87PgSv7ePscIgS8pwez2irDD6XNogIpFJDsLKgRS7xAehYd0wHZzy6A2G959+EGcF+/shUdf/kxjzMncL6xjQ+NH1tmy+e0i4Gg6sNS67N7w7htMMtJGYDsOhE6E/xcGCTFsaSja4MN1O/XKBBAtL2GmmUrDGnNeER0BmVDBScmNZ9JrAZNQ8LWV56BlbmRAXiPJBZswESKBE9PNdDErJK/dm9oQ1eVfsCLoKTd7It/Oa+zLCYv36k4mlbJKQONn4euw/LS5RB/iS4x8zbwZTv8Pk5j2Vv0qJ1eMZl4uJqHVs4J4rAbXS4rwHIeAqVMYwS0FkpKrUw0amdTZx0aeRBr4Etd/MXlCeyNie1u5Ym+1fDDgqy X-Forefront-PRVS: 0200DDA8BE X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2466; 23:Kgt0dbPsJYaSGSBhtixdjBQsTLOBJIhJEAZWk?= =?Windows-1252?Q?zF1tmTDV1ojmHDiOhO55uwRXmRD8vCWIVA1nDoc12wyIhitnDgUmx600?= =?Windows-1252?Q?JwS47BdkJvIgn6YbqT9oTGf09SeEFOTZVCBKDw9YdFXyQRgWI57C4e7v?= =?Windows-1252?Q?JFUY7O3ZcNoAsuMHtAtuWSPRXqi1QwPq7TmeoPdZOEC5LAYgP1BX/ivP?= =?Windows-1252?Q?6GpSIgr4b4/gf/8AIgLHrFKlxWIF41wg6zkoQ2mD3DIEnKQmEw25+YWu?= =?Windows-1252?Q?v5TaMVul2A2gt3MdF/+FbvlQcpTEdSpJVp1ow15NaPqvc+hgMvB6cBDx?= =?Windows-1252?Q?tWK04ZXXv7XmpXHxGZFzXLEQ5W3tS0t/fqZ2oWOVZ9ePDFfkiyXXApAJ?= =?Windows-1252?Q?fzwb2z+c7tIi46UMNEKxo9qmuy6v741zR2wujsSQ6lTz53q9QrujrHma?= =?Windows-1252?Q?/Vb8KAp7rR5Vn9ojWYmRa97qta0/8t3zF8+OYCckqwMfxhttdyxMQ+Vq?= =?Windows-1252?Q?jwv/jeo+PCaOW/19NmncWZEQLMF0jbcPwjYR38qY4VSiWJVftsa0xchK?= =?Windows-1252?Q?7PM4reMNnsIyEknRwgGeiDQhhWp0t4O/AnQNiWEnRZft1Q0544Kdy3DL?= =?Windows-1252?Q?Q60YrF8IN178wja4fjiKMbUgOASzrH8pkV4eMknMvOcrKg4/slhiWwV2?= =?Windows-1252?Q?jr4CegGeUuwH1EGKdBGL025/vc621gUzm+w8D3HH+Ofp6UW7eDaQn93+?= =?Windows-1252?Q?u7dHJP5eS4dcoJJh/PxtL/S/BQkDCL6nBbebula4JCzM4TEDNUGrgMOT?= =?Windows-1252?Q?NWjJMDQ6SJMuyXqbY23QaCdHi1a1mD0Io5PcyJ72JS/JPzXUcfdFGvBS?= =?Windows-1252?Q?8gWW5mgY7720bkR+CafJWOcPbvNV1P60sWV9qaf5Bx5mNDPRkyE40LIy?= =?Windows-1252?Q?a1jOkeYp57MOHBaEIajZ3UXTXuLLYyvja+aNG4RkuWZ74ONVVE6p78RE?= =?Windows-1252?Q?FgF9ID2X8oh+UqTv7Jlp2S2sNiw5ff91WKD3VRhXX2xMXTcQhyZmbcHi?= =?Windows-1252?Q?cNCxb/HbAWPwDAhmsxG+0FH51S+/qk15BQoHHE6KpA002epKJ3VHD/Zb?= =?Windows-1252?Q?017tFXrKkKGCsmOXDpim+iPyD4UIAg5PUPLMJ2lFnBkVQpRjXpcuhXlu?= =?Windows-1252?Q?1z2OQsiAj3dnXJX8BDawW8ePqyGgX0uF0rsMK1g1jmBynvwqZtS3pbOu?= =?Windows-1252?Q?FHtEkjQ9tMG3UxgrcxG89rtEdtlecd9XKhKFS3hFE4LYl/kAh87VgjWM?= =?Windows-1252?Q?nf5XJpoZFj24HNmODq3PWox4ALSyPcotUi/uG0ljLkcHOf29eilicjsh?= =?Windows-1252?Q?mwMH7pY2Vt0z0MHCcCahhwoV9RPglbJOiGrv8oP6rx+d5cVlDscOa12D?= =?Windows-1252?Q?km3fowKsppmWSmhrhi9jhlIcxfkTkUd9Lcl6PHBjuQrWLYhwW+tDOFlT?= =?Windows-1252?Q?JCVRiqXCRsOiZfOp7jVb5E3shXk8o6whvG5mfyMhuTXCqUKn3379Eed2?= =?Windows-1252?Q?byHU2QpmOC5oaGOflD/jHN0nEpcHo6GOZF1QPefHAG70YILquIQz/ASa?= =?Windows-1252?Q?AlOJiyJrXdH3FTs/e5UxTryj3Y9xxVLIqHQQIJcv669fTn0AbM5yFkRz?= =?Windows-1252?Q?lTcc62HQu7xF1oDsLbLqWX9HZbFoPa3xVuTOfMrHjyDipwaPXfEI2VcC?= =?Windows-1252?Q?ZimX16lyifFEsRdPg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 6:zsEKSmINFIHLhTAzVC1Q30avtaVFANWkljhEomaH5EyaYzTXbWd7Ml0v3JdVJZbUHfuGq0xYiPNgZK/YIZSaV63QX2bDCIk/l7gS46U5/45VZe6m+e+L54xMk56d9JuqguOnl0Swh1NkcSDT8VVZ/APR9wtsvTuc8I4tlP4yUwz9CUEAolTUFhKLr2HdeuZiNeX30r6W9yvjg5/ATsb0KKV0CtdUsd/wTLNa/IhZzhKz/lxvftTSSOpXf5BH16Gz5dWb+1AHXCr0rBX/vccqKRAS2p2ElNf6PH6ctqZ1iviJssK7wv3Ma6ByFqNG0ZA3AlkbbINTXfd8FlFRCd94EoEudxaWTWUwau/yLO2b0VE6CYK4HuPAB2a9Z2iqsT2RyDEWJlgyKIqkpVh+Euev4gMTLOMkm6CFGuxqsUU3gdKenOwkX+CPz2VxxDTND69I; 5:W5gMaLtkzO+D8ywqiaDJx/2zsDOy9rdHk1vIXqnMbhpv9GHRwB+QeFe5h74sseAkhx6A+NVGsBs/ur8odrhRgkNoV+t/Cn9edrSmPJasZ9GEmXYT/BAm3htBYI0cH0rlwvMq380F0u0SV4fJxlOl6BtDISQUw1JpYvZ4NqPEsw/ExeM9cIIJoMeFe78yNpcP; 24:cJsg703aoZ859KFCpLYUfRj4hyPW0LUFSh+NR2rYuVPnGrroCCWONSkPDHcYpqMDnvtLheO2rFPXQygKc3yK9CUbSEO7huR6zHeycCoth8k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 7:iLD8M1ZFnDEXNZybfbEIRb/z3wNK6uKGln0wpXxkEtW/pj2Nm34wiYSGCSfIyf9BC0YcFsN6AWAl18tJuREyUn5lQjergNOEOvwTfQ2SbFJPtLpFX3ykbRpFzZqNQoT3dSIDVd42zNwWfLfnr+yDZrpg7AP1IgoPkrqMAKZluGFjRHBt+Oi11FGtTO4cYPX5ZGBKtkfBpHbkC/Zf0MQ8+l7HKmrKUFKke5wvoIggnerl7Ldtse1ipQSEc1kjhZWewHpX2ibQK707SkVioONErtuiZ+2cFQNGJGMGfiw1uMLvbm8cLLexG7CsL/UaeYSvVKGOLtNO6NOTPpPa6DN1+CsF9oXDK7ol3s2LDCKoiLb3RYNM0LinbD59bFHzMiiCaFBe7nB3cQ00nXsqb6zYs3Unc3JWrS6EJGKnXHeZ7jYeOunb8KrRvwvH/ihA6H2FkIbTpnrUE1wMVQYSOG7fOQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 10:20:02.3295 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2466 Subject: Re: [dpdk-dev] Understanding of Acked-By X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 10:20:04 -0000 On Friday 27 January 2017 03:43 PM, Bruce Richardson wrote: > On Fri, Jan 27, 2017 at 12:48:06PM +0530, Shreyansh Jain wrote: >> On Wednesday 25 January 2017 08:28 PM, Thomas Monjalon wrote: >>> 2017-01-25 13:53, Van Haaren, Harry: >>>> There was an idea (from Thomas) to better document the Acked-by and Reviewed-By in the above thread, which I think is worth doing to make the process clearer. I'll kick off a thread*, and offer to submit a patch for the documentation when a consensus is reached. >>>> >>>> >>>> The question that needs to be addressed is "What is the most powerful signoff to add as somebody who checked a patch?" >>> >>> I do not see the benefit of knowing the most powerful. >>> Anyway, the most powerful tags are done by trusted people. >>> And people are trusted after delivering good reviews or patches ;) >>> >>> The question should be "How to use the tags?" >>> >>>> The documentation mentions Acked, Reviewed, and Tested by[1], as signoffs that can be commented on patches. The Review Process[2] section mentions Reviewed and Tested by, but nowhere specifically states what any of these indicate. >>>> >>>> Offered below is my current understanding of the Acked-by; Reviewed-by; and Tested-by tags, in order of least-powerful first: >>>> >>>> >>>> 3) Tested-by: (least powerful) >>>> - Indicates having passed testing of functionality, and works as expected for Tester >>>> - Does NOT include full code review (instead use Reviewed by) >>>> - Does NOT indicate that the Tester understands architecture (instead use Acked by) >>>> >>>> >>>> 2) Reviewed-by: >>>> - Indicates having passed code-review, checkpatch and compilation testing by Reviewer >>> >>> Compilation testing is done by the CI. >>> The reviewer must just check the results. >>> >>>> - Does NOT include full testing of functionality (instead use Tested-by) >>>> - Does NOT indicate that the Reviewer understands architecture (instead use Acked by) >>> >>> I disagree here. >>> The reviewer must understand the impacts of the patch. >>> That's why a Reviewed-by tag is really strong. >> >> From what I understand, 'Reviewed-by' and 'Acked-by' are the other way >> around. >> - Acked-by is intent that 'I agree with change'. >> - Reviewed-by is 'I vouch for the changes' either through review or >> testing or both. >> > > Other way round in what way - compared to proposed by Harry or by > Thomas? Which do you view as the stronger indication that the patch is > ok? Sorry, I should have posted this against Harry's mail rather than Thomas'. 'Other way round' as compared to Harry's text. Reviewed-by is a strong indication, in my understanding. > > Regards, > /Bruce > - Shreyansh