From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24774A0546; Fri, 30 Apr 2021 13:57:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE5754014F; Fri, 30 Apr 2021 13:57:13 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0A21D4013F for ; Fri, 30 Apr 2021 13:57:11 +0200 (CEST) IronPort-SDR: TbJAdngp/CEtOia11Rfr3HUik2lkjfy/IxpdnaYskQIT62vX4ffb7cIQBVg6RGc4pkt3NyYwk/ OkAHfIdm89LQ== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="197306749" X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="197306749" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 04:57:10 -0700 IronPort-SDR: euTDSUMk/tkk2lkzeUbF1adUpG9f3fsoqNNrO173cOtQMv9tc6mfGazGplIf/SYajQ7I4gwxAm NNaI4TSPL/6w== X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="404570043" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.242.68]) ([10.213.242.68]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 04:57:09 -0700 To: Qi Zhang , qiming.yang@intel.com Cc: dev@dpdk.org References: <20210429004143.2921260-1-qi.z.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 30 Apr 2021 12:57:05 +0100 MIME-Version: 1.0 In-Reply-To: <20210429004143.2921260-1-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 1:41 AM, Qi Zhang wrote: > Add IP fragment support in base code and couple QinQ improvement. > update the release date as the last base patch for DPDK 21.05. > > Qi Zhang (6): > net/ice/base: add IP fragment flags > net/ice/base: add function for post DDP download VLAN mode > configuration > net/ice/base: add print if DDP/FW don't support QinQ as expected > net/ice/base: modififcation to support L3 DSCP QoS > net/ice/base: signed External Device Package Programming > net/ice/base: support IP fragment RSS and FDIR > Hi Qi, Patch by patch build fails, can you please check it? Also some of the above patches title doesn't match to our convention, plus there is a checkpatch warning, can you please fix them too? And in 4/6, the message logs are too long, yes we allow long lines instead of breaking them, this is to help searching log in the code, but those lines are ~150 chars and I think makes harder to read the code, what do you think indent the message and break in the sentences boundary, something like: " ice_info(hw "QinQ functionality cannot be enabled on this device. " "Update your DDP package and NVM to versions that support QinQ.\n"); "