From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B342B2B84 for ; Wed, 5 Apr 2017 12:08:13 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 05 Apr 2017 03:08:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,278,1486454400"; d="scan'208";a="1131283137" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2017 03:08:11 -0700 To: Bruce Richardson References: <20170404163654.86100-1-allain.legacy@windriver.com> <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> Cc: Allain Legacy , dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Wed, 5 Apr 2017 11:08:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 10:08:14 -0000 On 4/5/2017 9:23 AM, Bruce Richardson wrote: > On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote: >> On 4/4/2017 5:36 PM, Allain Legacy wrote: >>> The AVP devices are only supported on Intel 64-bit architectures so >>> adjusting the defconfig attributes accordingly. >>> >>> Fixes: c5ab4707ba97 ("net/avp: support driver registration") >>> >>> Signed-off-by: Allain Legacy >>> --- >>> config/common_linuxapp | 1 - >>> config/defconfig_i686-native-linuxapp-gcc | 5 ----- >>> config/defconfig_i686-native-linuxapp-icc | 5 ----- >>> config/defconfig_x86_64-native-linuxapp-clang | 5 +++++ >> >> Right now compiler config files only have compiler and architecture >> configs, although it is OK to update them, to be consistent with what >> other PMDs did, what do you think: >> >> Keep AVP config enabled in "common_linuxapp" >> >> Disable AVP in following configs: >> defconfig_arm64-armv8a-linuxapp-gcc >> defconfig_arm-armv7a-linuxapp-gcc >> defconfig_ppc_64-power8-linuxapp-gcc >> > > I actually disagree with that, and I think the approach proposed is > better, given that it's only one target type that is supported. Agree that it is better, but other PMDs are doing what I suggested, so I am for AVP follow the same, and fix them all later when required. > > However, I think we should have an AVP config option in common base, set > to "n", so that we at least there have an entry to indicate it exists. > > /Bruce >