From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7693F2C38 for <dev@dpdk.org>; Mon, 11 Dec 2017 18:56:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 09:56:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="10981200" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.161]) ([10.241.225.161]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2017 09:56:42 -0800 To: Hemant Agrawal <hemant.agrawal@nxp.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org Cc: Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org> References: <20171208102830.2817-1-olivier.matz@6wind.com> <eb74dade-439e-dbf4-0455-26100755dd23@intel.com> <f43f61fb-3630-03ba-6328-5935276e1975@solarflare.com> <448cfe74-224b-8a25-6be3-42c70c6ac514@nxp.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <cf86b313-5e9b-c8c0-ccb8-31afc77c2139@intel.com> Date: Mon, 11 Dec 2017 09:56:40 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <448cfe74-224b-8a25-6be3-42c70c6ac514@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net: update licence for network headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 11 Dec 2017 17:56:46 -0000 On 12/10/2017 9:27 PM, Hemant Agrawal wrote: > On 12/8/2017 11:52 PM, Andrew Rybchenko wrote: >> On 12/08/2017 08:29 PM, Ferruh Yigit wrote: >>> On 12/8/2017 2:28 AM, Olivier Matz wrote: >>>> To be compliant with the DPDK licensing guidelines, switch to >>>> BSD-3-Clause. It can be done safely since the BSD headers from which >>>> these files derive also exist as a BSD-3-Clause license in FreeBSD. >>>> >>>> Link: >>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip_icmp.h >>>> >>>> Link: >>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip.h >>>> >>>> Link: >>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/sctp.h >>>> >>>> Link: >>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/tcp.h >>>> >>>> Link: >>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/udp.h >>>> >>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com> >>> <...> >>> >>>> + * SPDX-License-Identifier: BSD-3-Clause >>>> * >>>> - * @(#)in.h 8.3 (Berkeley) 1/3/94 >>>> - * $FreeBSD: src/sys/netinet/in.h,v 1.82 2003/10/25 09:37:10 ume Exp $ >>>> + * Copyright(c) 1982, 1986, 1990, 1993 >>>> + * The Regents of the University of California. >>>> + * Copyright(c) 2013 6WIND S.A. >>>> + * All rights reserved. >>>> */ >>> Not sure how much it matters but in the document Hemant put, order is >>> different, >>> it starts with Copyright line instead of SPDX line: >>> >>> " >>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER >>> SPDX-License-Identifier: BSD-3-Clause >>> " >>> >>> So I assume for multiple Copyright holder: >>> >>> " >>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER >>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2 >>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3 >>> SPDX-License-Identifier: BSD-3-Clause >>> " >>> >>> And do we still need "All rights reserved." ? >>> >>> >>> I am for following same syntax in all files (whichever is chosen), >>> this may >>> helps us in the future for scripting licensing checks. >>> >>> <...> >> >> License text example in [1] starts from Copyright and has All rights >> reserved. >> I agree that template should be clearly specified from the very beginning. >> >> [1] https://spdx.org/licenses/BSD-3-Clause#licenseText >> > Hi all, > Most templates are showing copyright first and SPDX later i.e. the > typical way for writing the license. > > However some projects has followed it other way around to make it easy > for tools i.e. the TOP line. > > I agree with Ferruh that we shall follow single convention. I will > prefer to do it in following way to make it consistent. (I will also fix > my change patches). > > >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER > >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2 > >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3 > >> SPDX-License-Identifier: BSD-3-Clause Stephen mentioned Linux already has a defined syntax for this, unless there is a good reason to change I think we can follow same syntax, what do you think? > > > Regards, > Hemant > >