Re: [PATCH 1/7] examples/ipsec-secgw: disable Tx chksum offload for inline

[Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>]

Ping.

On 3/22/22 11:28 PM, Nithin Dabilpuram wrote:
> Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside
> crypto/protocol or cpu crypto is needed.
> For Tx Inline protocol offload, checksum computation
> is implicitly taken care by HW.
> 
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
>   examples/ipsec-secgw/ipsec-secgw.c |  3 ---
>   examples/ipsec-secgw/sa.c          | 32 +++++++++++++++++++++++++-------
>   2 files changed, 25 insertions(+), 10 deletions(-)
> 
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
> index 42b5081..76919e5 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -2330,9 +2330,6 @@ port_init(uint16_t portid, uint64_t req_rx_offloads, uint64_t req_tx_offloads)
>   		local_port_conf.txmode.offloads |=
>   			RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
>   
> -	if (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM)
> -		local_port_conf.txmode.offloads |= RTE_ETH_TX_OFFLOAD_IPV4_CKSUM;
> -
>   	printf("port %u configuring rx_offloads=0x%" PRIx64
>   		", tx_offloads=0x%" PRIx64 "\n",
>   		portid, local_port_conf.rxmode.offloads,
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 1839ac7..36d890f 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -1785,13 +1785,31 @@ sa_check_offloads(uint16_t port_id, uint64_t *rx_offloads,
>   	for (idx_sa = 0; idx_sa < nb_sa_out; idx_sa++) {
>   		rule = &sa_out[idx_sa];
>   		rule_type = ipsec_get_action_type(rule);
> -		if ((rule_type == RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO ||
> -				rule_type ==
> -				RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL)
> -				&& rule->portid == port_id) {
> -			*tx_offloads |= RTE_ETH_TX_OFFLOAD_SECURITY;
> -			if (rule->mss)
> -				*tx_offloads |= RTE_ETH_TX_OFFLOAD_TCP_TSO;
> +		switch (rule_type) {
> +		case RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL:
> +			/* Checksum offload is not needed for inline protocol as
> +			 * all processing for Outbound IPSec packets will be
> +			 * implicitly taken care and for non-IPSec packets,
> +			 * there is no need of IPv4 Checksum offload.
> +			 */
> +			if (rule->portid == port_id)
> +				*tx_offloads |= RTE_ETH_TX_OFFLOAD_SECURITY;
> +			break;
> +		case RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO:
> +			if (rule->portid == port_id) {
> +				*tx_offloads |= RTE_ETH_TX_OFFLOAD_SECURITY;
> +				if (rule->mss)
> +					*tx_offloads |=
> +						RTE_ETH_TX_OFFLOAD_TCP_TSO;
> +				*tx_offloads |= RTE_ETH_TX_OFFLOAD_IPV4_CKSUM;
> +			}
> +			break;
> +		default:
> +			/* Enable IPv4 checksum offload even if one of lookaside
> +			 * SA's are present.
> +			 */
> +			*tx_offloads |= RTE_ETH_TX_OFFLOAD_IPV4_CKSUM;
> +			break;
>   		}
>   	}
>   	return 0;