* [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
@ 2021-05-13 3:38 ` wangyunjian
2021-05-13 6:46 ` Slava Ovsiienko
2021-05-13 3:39 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: " wangyunjian
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: wangyunjian @ 2021-05-13 3:38 UTC (permalink / raw)
To: dev; +Cc: matan, shahafs, viacheslavo, dingxiaoxiong, Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.
For example:
for(...)
do
rte_eth_dev_configure
rte_eth_rx_queue_setup
rte_eth_tx_queue_setup
rte_eth_dev_start
rte_eth_dev_stop
done
Fixes: 97d37d2c1f6b ("net/mlx4: remove device register remap")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/mlx4/mlx4.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 7cd35cd3ca..c522157a0a 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -201,6 +201,7 @@ mlx4_proc_priv_init(struct rte_eth_dev *dev)
struct mlx4_proc_priv *ppriv;
size_t ppriv_size;
+ mlx4_proc_priv_uninit(dev);
/*
* UAR register table follows the process private structure. BlueFlame
* registers for Tx queues are stored in the table.
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
@ 2021-05-13 6:46 ` Slava Ovsiienko
0 siblings, 0 replies; 8+ messages in thread
From: Slava Ovsiienko @ 2021-05-13 6:46 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: Matan Azrad, Shahaf Shuler, dingxiaoxiong, stable
> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Thursday, May 13, 2021 6:39
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> dingxiaoxiong@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device
> configured repeatedly
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Currently, configuring a mlx device, it will allocate its own process private in
> mlx5_proc_priv_init() and only frees it when closing the device. This will lead
> to a memory leak, when a device is configured repeatedly.
>
> For example:
> for(...)
> do
> rte_eth_dev_configure
> rte_eth_rx_queue_setup
> rte_eth_tx_queue_setup
> rte_eth_dev_start
> rte_eth_dev_stop
> done
>
> Fixes: 97d37d2c1f6b ("net/mlx4: remove device register remap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device configured repeatedly
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
@ 2021-05-13 3:39 ` wangyunjian
2021-05-13 6:47 ` Slava Ovsiienko
2021-05-13 12:37 ` [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5 Thomas Monjalon
2021-05-13 12:51 ` Thomas Monjalon
3 siblings, 1 reply; 8+ messages in thread
From: wangyunjian @ 2021-05-13 3:39 UTC (permalink / raw)
To: dev; +Cc: matan, shahafs, viacheslavo, dingxiaoxiong, Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.
For example:
for(...)
do
rte_eth_dev_configure
rte_eth_rx_queue_setup
rte_eth_tx_queue_setup
rte_eth_dev_start
rte_eth_dev_stop
done
Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/mlx5/mlx5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 35f91e965e..cf1815cb74 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1455,6 +1455,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
struct mlx5_proc_priv *ppriv;
size_t ppriv_size;
+ mlx5_proc_priv_uninit(dev);
/*
* UAR register table follows the process private structure. BlueFlame
* registers for Tx queues are stored in the table.
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device configured repeatedly
2021-05-13 3:39 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: " wangyunjian
@ 2021-05-13 6:47 ` Slava Ovsiienko
0 siblings, 0 replies; 8+ messages in thread
From: Slava Ovsiienko @ 2021-05-13 6:47 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: Matan Azrad, Shahaf Shuler, dingxiaoxiong, stable
> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Thursday, May 13, 2021 6:40
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> dingxiaoxiong@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device
> configured repeatedly
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Currently, configuring a mlx device, it will allocate its own process private in
> mlx5_proc_priv_init() and only frees it when closing the device. This will lead
> to a memory leak, when a device is configured repeatedly.
>
> For example:
> for(...)
> do
> rte_eth_dev_configure
> rte_eth_rx_queue_setup
> rte_eth_tx_queue_setup
> rte_eth_dev_start
> rte_eth_dev_stop
> done
>
> Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
2021-05-13 3:39 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: " wangyunjian
@ 2021-05-13 12:37 ` Thomas Monjalon
2021-05-13 12:51 ` Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2021-05-13 12:37 UTC (permalink / raw)
To: Yunjian Wang; +Cc: dev, matan, shahafs, viacheslavo, dingxiaoxiong, humin29
13/05/2021 05:38, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This series include two fixes patches for mlx4/mlx5.
>
> ---
> v2:
> * remove redundant empty line
Please mark your old patches as superseded in patchwork.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
` (2 preceding siblings ...)
2021-05-13 12:37 ` [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5 Thomas Monjalon
@ 2021-05-13 12:51 ` Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2021-05-13 12:51 UTC (permalink / raw)
To: Yunjian Wang; +Cc: dev, matan, shahafs, viacheslavo, dingxiaoxiong
> Yunjian Wang (2):
> net/mlx4: fix mem leak when a device configured repeatedly
> net/mlx5: fix mem leak when a device configured repeatedly
Applied in next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread