From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Cc: Harman Kalra <hkalra@marvell.com>
Subject: Re: Question on a patch in lib/ethdev/ethdev_driver.c
Date: Mon, 11 Mar 2024 10:58:57 +0000 [thread overview]
Message-ID: <cfa26f6e-e5b6-41a0-9a71-843667b2f911@amd.com> (raw)
In-Reply-To: <4250e68c-6874-4954-bf2a-406c22378db4@6wind.com>
On 3/11/2024 9:07 AM, Thierry Herbelot wrote:
> Hello,
>
> Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes
> the following variable initialization in rte_eth_devargs_parse():
>
> memset(eth_da, 0, sizeof(*eth_da));
>
> This in turn causes a failure in ixgbe PCI probe on Arm server:
>
> eth_ixgbe_pci_probe(): unsupported representor type:
>
> Indeed, nb_representor_ports was supposed to be correctly defined when
> calling rte_eth_devargs_parse().
>
> The question is:
> why was "memset(eth_da, 0, sizeof(*eth_da));" removed ?
> This is not explained in the commit log.
>
Hi Thierry,
I think it is an oversight, thanks for reporting it.
+1 to preserve the existing behavior and function memset the input
parameter.
@Thierry, do you want to submit a fix? Else me or Harman can send one.
Thomas/David, can we hold the -rc3 for this fix please?
Thanks,
ferruh
prev parent reply other threads:[~2024-03-11 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 9:07 Thierry Herbelot
2024-03-11 10:58 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa26f6e-e5b6-41a0-9a71-843667b2f911@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).