From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D3E43C86; Mon, 11 Mar 2024 11:59:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEE9D4026B; Mon, 11 Mar 2024 11:59:05 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062.outbound.protection.outlook.com [40.107.92.62]) by mails.dpdk.org (Postfix) with ESMTP id 1A4FA40156 for ; Mon, 11 Mar 2024 11:59:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajPwzD47pRiejggCdazz8CPRxTLcRYfFicppbhaH5g6J922jXrZu+Al7MxQ59+8axBErJ9FF8y+SuBnVOojQRrPmUVgkp6PmBlNtPExXQ+9+708J1wFhnjx8e6id8Wy0dzUxg6n5qYdAtwbSKHlm/KV9Ia7XVFDiDoL8Xsc6CXNtbJIpe3bLteRSijfGRIzovxZDNcQfCMft9JmvpCbY1W5a+A5prrSd6yc30ccaLQmeQ6APHa1o6u+gZGkLBH1bqeWnT46CPN0YCqNK2umqk1jK6wV+WLTBE+FOI/Oq1TGWJ7qleYapiBeW7G9yyzaz3GA8nqlbVDVqwonBAvqY8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwo7fYE5kINVA+vXQ+7ATeM3whAyF3y6eKbTk8SffjE=; b=e6iW9FAMgNG/pPjYazD8YIGlLlQZANOY4kkzU+cVXKjKoT6rXVrWmcORzm00A59Jk7jlOz1Vbn5EAE8NHSZbDFfY28Z7UmaQJkR6jSkefN6Xay497AxsCi6ylWVFFi/1/UtQhX6zrjSTo4TsVcYtlL7D4vgKdZXoH7fRNWbr977ut0NXpiGpLzcDfznjsQ1LtBL9Xs5naxI/Ur3y7SMFi02Q970yl3FPnrfhH+jKo/JL++ZwFzwvR5GPo8ICv429nsPgNvTTFCkCUglUNW123MAhCMHl+vWKOaUiHQERCU86c8E3jXRIaclJYMByAfsgMLthgyxIJaXAvM0ciqgQUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwo7fYE5kINVA+vXQ+7ATeM3whAyF3y6eKbTk8SffjE=; b=rcdC5u8sueHIC8OjQq1HHmWY3w/MSTvgDsdDnp2q3+Cdp+ggPGE2ZOGYj1sQlXKZg1cztzG543F5MGbU3mB7B06d6+PgkEC2RhjSlCorrzPA5WOSwk6MR2gU9PY9Ek+XFP0AeNZLoe/eVI+hFKZA5Ix3/X3LGE4m51F6picPJ4U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB9429.namprd12.prod.outlook.com (2603:10b6:610:1c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Mon, 11 Mar 2024 10:59:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 10:59:02 +0000 Message-ID: Date: Mon, 11 Mar 2024 10:58:57 +0000 User-Agent: Mozilla Thunderbird Subject: Re: Question on a patch in lib/ethdev/ethdev_driver.c To: Thierry Herbelot , dev@dpdk.org, Thomas Monjalon , David Marchand Cc: Harman Kalra References: <4250e68c-6874-4954-bf2a-406c22378db4@6wind.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <4250e68c-6874-4954-bf2a-406c22378db4@6wind.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB9429:EE_ X-MS-Office365-Filtering-Correlation-Id: 17501011-7a07-4232-09d8-08dc41ba42ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ncKyeCOnvTVVmTHYN4m9shvJKT2/qC1JIXGPaXOH7GR2gDI0gGwcNIhmuB0huFXb3ShJiRWwypRNAgQZUWEtk4HRz9FpI6m3Oqj9STLhDf85NHBCeY1mQRqJua/vKteXcBPs3rqKN6Cn764o/yY3++sFxj/vPWwUHH6sKvlQHbgXRFpk/xxMAyXV/w3AY5jAg51q3s7SxXK1FqowDe+SY5QzFNKIW9/2tAojUN3wXXj8NF7af97PNiWtQzFD4Ngtv1b6AsEIb6JBzYfW3Wa1iPsCjwsaMxHJ5yhxmQHD3/6eoXGnNAOYQBzdgWf8okL2iTsoZFCdS2rU0/03vgi0V2z3XJEa+byccdL5PP2BtaOpzQG5vt+ev0JcfuS36xoBgs0ZLaNdojS3XR2R3Ucqnry4LdXiwhMQbJA6jfBT21JwMhbY8xSiZmbLwR2GlIlvp201ZWDgd2JFpLVecX5C9Ru5ervEhL9jrNyJcUDvgJg0C3nYFSVaARzWYWy2yO/bSLjmP3tiQAQI9Xz3FQnogrVHj6LyatDFEcvpFSd+fFEr3bGvl5KG/qvMJXpCv8ma8DTNdaL4kPIB5SCXuFxh8E7SdySO1pQ7TnxHIgJWOX6hNQm6vBZnOh0Gv7q5ygjJuJypOPkjHUxXappTYnHxcvSd86Vj7MIOgaPzIjf1eV0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1BlRWIwR2xFWHVSUjF1UHRNUzdFWU1BZ1k3WHR4NndUZmt3bVZ6V2cyUytZ?= =?utf-8?B?aG5SNTJPUU85NGlLR1NjUkovNW5BUFNBSHV6Q2tMWUc1TFV6VTUyTEVieGVi?= =?utf-8?B?dmlMRzg3cXBMdFhyS2gyMUVkY0JTSml2dnlOUCtKVEVpd1B2VDJXd2F2cjZ4?= =?utf-8?B?eVY5Q1doY2pma2FKK0YrSy9UYXBldTQvRFVpSno5TkdyZjNuaTV0cmtIOStt?= =?utf-8?B?K2ZGS3B0eUJzVDhmT1lOeU92WVBYaFRlQ203aUpsQ1BhUlFrcjNMbmhVdU9P?= =?utf-8?B?SFY3S2l6Ymw4K2RrM3krYmJqYVBQU1ZlTHQ4OUdiYjVOWFpKb0xLRW1zS1hC?= =?utf-8?B?WFo1Mko4Sk9YNzRkMWNyclNOWTNwZmhJTkNZdTJ1bU9sOGNIb08wbEV6bW5K?= =?utf-8?B?VkFjd0FTTlUwazZ3WFp4SVFYbFdJN2pJLzNOcklQVXdjSEo4T09LTjVTMWFN?= =?utf-8?B?NzZqU0VMOHpPYVRXdlA0TGIzb2V2cnVlbUxKVDRsMWpRVXZuaFpYZk0ybU5Q?= =?utf-8?B?elhkV3RNZ3l4YTdFVmRJWWZqUFhSZVRiS3hMMkw5aStINzkrQkxVZ3ZEZXRo?= =?utf-8?B?NkNFT1U0RHhPcm9LQXkyZW5rTVZtRkNBcE1UTHhnY3d4ajdzeU5jZW9qV2hv?= =?utf-8?B?YklRSE1ScVV1WU1sNEluZ1hzTThreVREV2hDSzFJSlB3d1JLWWJHQXJtYjdm?= =?utf-8?B?SFBVQUV4Q2pUZnVjYVVzcFdZaVJaa0R6UFhTYzR3bDJNUU84UUVDMTRDZUIy?= =?utf-8?B?L29IQU1wZHRlUzZzUjNrdGlZWlhydEhmMHU4eE5EN0dwR1l5NmNYcXZzUWpJ?= =?utf-8?B?VXk3eEJWNjllM3F1OGNKVU1hOFdhcmE2NWhWMlEwamhwbW5WWlVmdmEwT2Yz?= =?utf-8?B?SUZGeUxTWnQ1N0cvaHg1emQ1S2k1cEdFTHpPbGhpRG9nYlUxRUpiTjhHUUdz?= =?utf-8?B?WHlPQ0tteWYweGk5VXpyZS9yYU9FTzlaaWt1TnFmTGRtbmQ2eStaUThFc2l1?= =?utf-8?B?VXBPcHVtOU9HdjVxUDNWcVk5U1FGbGZBaTJXWFRBQmdZMHpwTlQ1eXZxb21w?= =?utf-8?B?RkFxMXBoQU4yRlExa2VST2c1SHNiNE1kT0FtRDM1MVRWZzI2ck5XZ21EalpL?= =?utf-8?B?QTQ1bE1yKzhkTXJnMk1hRzNQdGp3RGhUMnowSVpVYWJJL3ZLbGc5aFVCNUhG?= =?utf-8?B?ejlKNlhkQlNXdzcxNk92c2dwYmhzTU1tWHJ1U0dvT3I1Tm42NDVZNnY5QllH?= =?utf-8?B?YjU4REhRdXRlNi84WHd5NTY1eVBEL2dlSCtBbWFXQiswUSs2d24wODU2eHMy?= =?utf-8?B?RXJCRll1czNTMFZNcWhRSm12cnVtOTdFejdxNUpzZ3JwaWJQZFkwSWdvK3Vi?= =?utf-8?B?QWFYdU5qSm8wMWl0VTIzbFd4L3NHYndIdDE1WFI2eThpdS9VMU1iUGxKZEtQ?= =?utf-8?B?V0JrN2pWaUNjWC8zb0c0OXdhWDQwWW5lNzFxVitqRUxCVkVyL0ZMZHBJbXFo?= =?utf-8?B?cnNhczBXVEd4emVoc2E1QTJ6QmM5S05HYm5UbDlJRzZGZWd1KzdJZzMxR1hn?= =?utf-8?B?cS9pdm83cUZDckJOSlBUMFloNnVGbENKNWl1bWo5enJDc2FrRzZlemJ2WGdv?= =?utf-8?B?bVIwQUMyeTM1L3V6d21acGZLeEVDZlRYZnIyWUwxRmJTbTExV3NIazBnbG9W?= =?utf-8?B?eUh0VjhUM1pnMVU2Mm9yR3d0NTFYak5LNGgrR2doLzZocXJJbGQ5UUt0S0FG?= =?utf-8?B?VlNqNHZIK3BtVTBNZ1pSVWhoKytsYitXUEZxMXdkZjc1ZUxFZFJLOGl0K09w?= =?utf-8?B?ZEd5aExoT1BHbGtTZGJtZjBIclhOYzhzaEh5KzdwR0VEeVNVREF3ZDJQQ1Vj?= =?utf-8?B?RmVGYXRNU0gxL0lzcmZMUUk5VnZVVmxGRHFqVUxQZ3g3d1Y3WFk5Nk5NK0dX?= =?utf-8?B?ektFYXdXVEZDblBRQzA2MnhnalBRdzRhNTNEMDhzYXJrTDFDcjB5MkU5bjBw?= =?utf-8?B?Mit2UkZXZHB5TkdPQlFBNHBiY0J5UjlhdHJYSHlIVHg2N0NBalVGQXljWEJu?= =?utf-8?B?YXBISGdqSjJrY0R6VlIrTkIxeWx4eTJzRkREaXowUjVLQUJuek1rSVNyOVZV?= =?utf-8?Q?5W2kBXNywY2hYCoMxcXItTn/6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17501011-7a07-4232-09d8-08dc41ba42ca X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 10:59:02.2092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pn1J+6PmNRrXfM1atpsMNIVZw3zwfv0EWd3HXOg+i6+e8r91t/v9QXFJymP9fgF8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9429 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/11/2024 9:07 AM, Thierry Herbelot wrote: > Hello, > > Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes > the following variable initialization in rte_eth_devargs_parse(): > >     memset(eth_da, 0, sizeof(*eth_da)); > > This in turn causes a failure in ixgbe PCI probe on Arm server: > >     eth_ixgbe_pci_probe(): unsupported representor type: > > Indeed, nb_representor_ports was supposed to be correctly defined when > calling rte_eth_devargs_parse(). > > The question is: > why was "memset(eth_da, 0, sizeof(*eth_da));" removed ? > This is not explained in the commit log. > Hi Thierry, I think it is an oversight, thanks for reporting it. +1 to preserve the existing behavior and function memset the input parameter. @Thierry, do you want to submit a fix? Else me or Harman can send one. Thomas/David, can we hold the -rc3 for this fix please? Thanks, ferruh