From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DFE9BDE0 for ; Wed, 10 May 2017 12:08:39 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 03:08:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,318,1491289200"; d="scan'208";a="98075770" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga005.jf.intel.com with ESMTP; 10 May 2017 03:08:37 -0700 To: Gregory Etelson , dev@dpdk.org Cc: "Lu, Wenzhuo" References: <99629734.on6ryOyqmF@polaris> From: Ferruh Yigit Message-ID: Date: Wed, 10 May 2017 11:08:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <99629734.on6ryOyqmF@polaris> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] IXGBE VF: segfault in ixgbe_dev_link_update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 10:08:40 -0000 On 5/10/2017 9:41 AM, Gregory Etelson wrote: > Hello, > > My application works with IXGBE VF 17.05-rc4. > After I shutdown switch port, > a call for rte_eth_link_get() crashes with SEGFAULT. > Apparently, ixgbe_dev_link_update() calls for non-existing in VF driver ixgbe_get_link_capabilities(). Hi Gregory, This doesn't looks like because of the ixgbe_get_link_capabilities() but hw->mac.ops.get_media_type. Crash happens in line 3802, which has: hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { In that stage "speed == 0" but that is expected. You already aware of the issue and patch, but as reference, this issue first reported in: http://dpdk.org/ml/archives/dev/2017-May/065533.html and proposed fix is in: http://dpdk.org/ml/archives/dev/2017-May/065562.html Thanks, ferruh > > Is there a patch with get_link_capabilities() implementation for IXGBE VF I can use ? > or > Can I safely disable call for ixgbe_get_link_capabilities() for VF ? > > Regards, > Gregory > > #0 0x0000000000000000 in ?? () > (gdb) bt > #0 0x0000000000000000 in ?? () > #1 0x0000000000491c36 in ixgbe_dev_link_update (dev=0x751680, wait_to_complete=1) at /root/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:3802 > #2 0x000000000043b753 in rte_eth_link_get (port_id=, eth_link=0x7ffe991fff90) at /root/dpdk/lib/librte_ether/rte_ethdev.c:1306 > (gdb) f 1 > #1 0x0000000000491c36 in ixgbe_dev_link_update (dev=0x751680, wait_to_complete=1) at /root/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:3802 > 3802 hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { > (gdb) p speed > $1 = 0 > > > s32 ixgbe_init_ops_vf(struct ixgbe_hw *hw) > { > hw->mac.ops.get_link_capabilities = NULL; >