From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 676EE2A58 for ; Wed, 5 Jul 2017 05:02:59 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2017 20:02:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,310,1496127600"; d="scan'208";a="122798241" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.76]) ([10.67.68.76]) by fmsmga006.fm.intel.com with ESMTP; 04 Jul 2017 20:02:56 -0700 To: Thomas Monjalon References: <1495986280-26207-1-git-send-email-jia.guo@intel.com> <1498648044-57541-1-git-send-email-jia.guo@intel.com> <1643564.1KfnGSoeuV@xps> Cc: dev@dpdk.org, helin.zhang@intel.com, jingjing.wu@intel.com From: "Guo, Jia" Message-ID: Date: Wed, 5 Jul 2017 11:02:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1643564.1KfnGSoeuV@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 03:02:59 -0000 hi, thomas On 7/5/2017 7:45 AM, Thomas Monjalon wrote: > Hi, > > This is an interesting step for hotplug in DPDK. > > 28/06/2017 13:07, Jeff Guo: >> + netlink_fd = socket(PF_NETLINK, SOCK_DGRAM, NETLINK_KOBJECT_UEVENT); > It is monitoring the whole system... > >> +int >> +rte_uevent_get(int fd, struct rte_uevent *uevent) >> +{ >> + int ret; >> + char buf[RTE_UEVENT_MSG_LEN]; >> + >> + memset(uevent, 0, sizeof(struct rte_uevent)); >> + memset(buf, 0, RTE_UEVENT_MSG_LEN); >> + >> + ret = recv(fd, buf, RTE_UEVENT_MSG_LEN - 1, MSG_DONTWAIT); > ... and it is read from this function called by one driver. > It cannot work without a global dispatch. the rte_uevent-connect is called in func of pci_uio_alloc_resource, so each socket is created by by each uio device. so i think that would not affect each driver isolate to use it. > It must be a global mechanism, probably a service core. > The question is also to know whether it should be a mandatory > service in DPDK or an optional helper? a global mechanism would be good, but so far, include mlx driver, we all handle the hot plug event in driver by app's registered callback. maybe a better global would be try in the future. but now is would work for all pci uio device. and more, if in pci uio device to use hot plug , i think it might be mandatory.