From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74FADA034E; Mon, 21 Feb 2022 14:10:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0460440DF6; Mon, 21 Feb 2022 14:10:13 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E9EC04068C; Mon, 21 Feb 2022 14:10:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645449011; x=1676985011; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=nsgiGoaZqZZUY2vgDOKzyTSsN5DOc1quU6VFf/QUIic=; b=MHinfDDsKD0XnX7JfsjWfMorA1XwtieXbT8Ar24G0+sWJjoYUC2majk6 xXlAupRob9SReI9zjz3pWkkpEnU52du07Kbe8JTkXhIx0+qDpGYUp4mJ5 sWU9tryKDRuZFdatUzu8ZXu/Uxe7W36gRzeCW58TFC0WdBpC1FYpRlZ7s 32rIO3N9yg/SWhjr6viRw5bJAE2ogrwNq7W5SyITh9B5Z8tJZta0p711a CZxmweRZCCG6Trb9EloOZTOEM7YL9oTp4mSU8qOz6XRu7FfBtbjtOsOm3 XXIScIi6eNsU8M/GkOFZ3NlKA5aXmWDjsFnToXXRKv1g8gs8jU6zbMQUD w==; X-IronPort-AV: E=McAfee;i="6200,9189,10264"; a="251688322" X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="251688322" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 05:10:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="606384269" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 21 Feb 2022 05:10:09 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 05:10:09 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 05:10:09 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 21 Feb 2022 05:10:09 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 21 Feb 2022 05:10:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMCrQUG9f5NcyIv01V0QTuc1WJblb9FipEYr+BFfSZ1GHtYjBS/v4LTGdEiPHMHQQBrRY47Qhkrlr9qHZv251LxjgdANno62XIgrq1hGJd4XCR3qS+VqNGPBjnMngqBef9z7gs4RjqAm6d1dvuAiZyQXx4NiaXpmb4l0Sa4JD3REDvOvOIrZz+CIsNFpybA3NrHqqpJ6kqxHadQDC/rRXoLMwiY8AfUlYEaPcbkOdew+ir2vSCmFkN/wz27mML+VmJ/XlNRLOzHCjVfBNJAXZBAeZH6BRoCwGzEmDG6GfJYuFPpqlOB3uZfGV8PUItNkkMMzbTmiUe452ZynwLqg5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q55aBePkjXfl0+g57lmScvmPZuKKdK4WzJyPKkFLyBQ=; b=UcVwM2NKgttuAPOKZonLpEOwdT9uIZJqlsiwVrDJ1KfkNFth1J52jEsc6L7e+hSkpFNuvIHaDczBZqb9jDkedtNmDHQsNJ0avHnqUKer1VCVooWhH+mF8VHOw/+faGQPU0XUrYiXs5XDHi26JXATU6Ql/QlaU7LPK/WcQ1j2UBDPbgr2YAJ2Hpn3g247s36HB3YDNkQhDrrOjjdOp4VR85Xrjsko35jgNs8Z014BHcRv59nAQ81lyyTGgbRXRWX8fH0dRVe3PUIp8bhO50P5vrfeJI3H5OKj3JQpWxBC89dqvMimeB0SosI0zjOKuNF8Hx5MN2EpyduH2bYJB5KWDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3512.namprd11.prod.outlook.com (2603:10b6:a03:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb 2022 13:10:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 13:10:07 +0000 Message-ID: Date: Mon, 21 Feb 2022 13:10:00 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20220221092121.2145802-1-jiawenwu@trustnetic.com> <20220221092121.2145802-3-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] net/txgbe: fix debug log X-User: ferruhy In-Reply-To: <20220221092121.2145802-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0047.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d579fd73-3d04-4413-8eaa-08d9f53b7b56 X-MS-TrafficTypeDiagnostic: BYAPR11MB3512:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sSdzRg3jMiAwWSpOc9PTBvvOoL8ZITOWB6AcdBL8dAyCz5AtfQnPWlSTBRy9Bmtz+uxxwQvwpliwcCrp8qcFAWNb7SVGS/U1QhtfcSa+gZXcJgbiZo4mb1G8FN2qxap0TdF642L8RQnh005a/Ieai/vMwzJZ0mxDMMYjD1VNf1hSQUsER5nDY+p52iIQDdDSed9e0wKgUSdDiYinuVrOCFk4Jor9g4N7vtkudclh5yn3he3haVOnvOBWM1oX0zMV43Pw6M9xO4lz91b8JcHGynKbk1Ij3tsC/1FGT8jwJjwnZwy2HoaneyV7Oq6swf31O8ujpdG8M5v0TQF2bOd671rd1r9zxrCcLoHfixn8BCIUlybfHhwYH5ZiqRh0tLe8FSsLl2xPx/vkaeu+SsAd1dTfQRT3y6wV/BNqsNML+Y4bhTzp+MsTpY0TeLAmonpfiZGropqHvl/bpOkMtY0aOZdglWZqj615nN873ORTnBoTVB2IeclPyqWgYTlLDH24gkhzQWNnjLaB3PNCin+DyzODLamMw+Bri+04Gjr2vIxLd+J0VHAztfionVAfnOXEmbygNjO0Y9Z/Nm+hzWPCfhZM7tpFZblE5+Ej1JKKytf/q1U2ZKBH3yLjGaOoa3W6DWcSi+Y/aMq6ZmEBDSVbSLeiGfDzSjrIX6t+F/NIBqRQMXj7cwMWVF9fiVMa3LjpTrkJDZTD5QULpHy+AN5hZA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(36756003)(6512007)(44832011)(316002)(26005)(6506007)(38100700002)(186003)(6486002)(508600001)(6666004)(31686004)(8936002)(53546011)(8676002)(4326008)(66946007)(66556008)(66476007)(82960400001)(31696002)(5660300002)(4744005)(2616005)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnVXR09hVkRtRmw2Z1B4OEVEKzNtcHh0WW55RWNhZ3UxYldGOVVQTlVHM0E5?= =?utf-8?B?VHBjMStrR0VCQ0RncHlEUEFtWkhUaGhCTFRZWmtkb0hOaXRqaS83Q2YvNnR3?= =?utf-8?B?TllXMU9iT0lxZ0JRVmthenFVTFFZTlBjMTBHTmh1cGVUemROTHBYZndwWVpK?= =?utf-8?B?ZmtXWmk2ZHRueGFxUjloTEhDeU1PK2pucktrUExOTTZaMmo3dG5mMEtlMGFw?= =?utf-8?B?aWp3L3VBK3VncFkvRGlQQ3dIallYK0pBb2UvMzdJSG5oL3ozMTYzWUhyUldP?= =?utf-8?B?bG1tNHdWZGZRbnpRVlRQd3VuNjlNa2pFQnRLT0hwTk1ESkdscTdHbU5PcjVT?= =?utf-8?B?R1Q3TGJJTk1uYUdwMkwxNmpHOVZRb3grejZRNCtYTUJZbDBsRmE3WTR1Zk0z?= =?utf-8?B?Z3BibVNnQkFVaVNKeFpENHE4T2pWeTBicHl2SEF3aFhGVDQzeWppK2lMUlVu?= =?utf-8?B?OVZBNFFIL1Z5M3BTR2djeGMrcU96eWVzVWgxaCtIdjg5Z0tNUkdTRUNJUHJC?= =?utf-8?B?QjNrbTZkL1N6R0ZTeEFJRUk4M3ZZeERnUWFoaXVuc2l6bGZtWlpEZFBwb1U2?= =?utf-8?B?SDh2OXBFek5pUTh1VVBtcmY0QzRicjNjUHdGbnJMT1RzcEFzWDZ0dUdNbjRM?= =?utf-8?B?Sjh1N29mRzRZSkNoYWR5TmtSZlFBclpHZXlhbE1zUG90V0ExUTIybk10ZEQy?= =?utf-8?B?RktlaFhSNnBEc3hISXd3RXo3cld5ZFR2RGNZaG0wNHRJZ0xLZm1qRmpLMlpx?= =?utf-8?B?VmFFbDNwRzIzZ2hqL1FpaTVaNEhyMkdSeWk0THRpQ3RveVE3OHVjRFJ0M1pv?= =?utf-8?B?NldyNExlVzFveTdDTXovV1ZyNVpyMVZOWVo1MWs0RGw3UVdCZUIxdnNTYTEw?= =?utf-8?B?bldXcC9mblhVenZYcjFxWEdEeFM2c0RvUDlMS25YQnpxUEZiYzRQT3hiRXBH?= =?utf-8?B?TUlMQS9Ga2syLzdJY1RpNjZYT2xHeFNOSEJkY0V2d09ORUNwMksrby84QUph?= =?utf-8?B?S1RjcVNqMlg2NGJSUHAxN3dseTdZS0wwTXBSeVQrdmhjYnlvU3NpMU9sV29M?= =?utf-8?B?K0NvWHorVllxR2J6R1VxVjVZbCtSa2luSC9rUkNzM1EvSWo0VnJPbkRkUEhZ?= =?utf-8?B?dlp2MDFFOGVnYzJMVG5ub0VzMStlditpZE1rY1FJVCtSWWZyaXlxbnpRNzFI?= =?utf-8?B?UUF2VTVnamdqRmdJZGdiVUsvbkgwSlFuMG4ybWtzRDMxSkgrN3BmT3VPNGN6?= =?utf-8?B?MERnVTdIdU5RNUViaTI4S1pSeCtnSzM5b2R0dnRqcE0wRWJoSmtYNWIxMWZa?= =?utf-8?B?c0hpd2p6VEhEUTJBdG8yS3hiL1dMdEl4Q1cvZ01tVU13eE9sTGRCZER1M1B5?= =?utf-8?B?VUNWKy9McjF1V3VFejNKUVZKQ2V4eThKbnNqOHFuaTdxa0Vkdnp3NHdNV0Zl?= =?utf-8?B?NzZkT2pWOFNteTJkcEg1dDVmQTN5b3h2bnJZWXpsRWt2RE1SK3RzbWRPWlFm?= =?utf-8?B?dTZxTWFjZzB4QTBNQXdLckVzWGRGTzZlS1REbGVKRDRrcVUyV2U4VEtUOVNX?= =?utf-8?B?bjRKLzl3WXA2V3lqSXp6OXdBM3NCRy83akJQaks0Z0VZUzBLMXI3R0t0eW1u?= =?utf-8?B?Tm5JWlp4Y3MvdFhjVGVTeGN6UnBFVVNkWVByWUlLcUs4S1FTMkNYV1MzQnFv?= =?utf-8?B?WklOQlRXakJvTFVtbjZscjBHWGFKcWd0T0RHNTZmdThLaWpTSldEVEdXajJN?= =?utf-8?B?ekFNVG5sOURtdzBLNFljR3NQQUVwc3ZkaHpZQ2NNM3VWTVpnMXZvaXJubUFp?= =?utf-8?B?NmRaQTNzNnpqWWtpUTB3MUZQNXhibXRLY2x3L0ZLQ05ka1Q2WGwwcUVwZ3Rh?= =?utf-8?B?ekNGZlp6NGd5Zkd0dFRNampKTE9tZ21HditONVJsc2FRc0J5K2V0NlBCeFhm?= =?utf-8?B?YU41OFk5YkJ6b0FSZVZNTldlZXZjU1o0NTdHV1lXUVZ3bkwycytmMFcvT0Fh?= =?utf-8?B?bndtOEVnNS9EWDFBS2crWUoyVXR3RmtlNXgyZy9GbGtZUkdSZW9yM1BWVksz?= =?utf-8?B?L002SUMzd3dDWDNiMDU4UHF5QjV2YmFVWDdjZFlmOFk5SU92bVZjS0d2RU43?= =?utf-8?B?TGY2NXRvaERlc1NhUjNqYmw3ZG9pbzYwcHN4TlFHMlFHZ21DL3B2RWhrYm5I?= =?utf-8?Q?mAbuPx4hGnH1m4zXpAnk8kA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d579fd73-3d04-4413-8eaa-08d9f53b7b56 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 13:10:07.3307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nH/1r3rDPGqEgX3yk/E26gJXNM4do2bxmzkZ5O0gXAB2r+9aF5/xantygDLW98bG1/Ukaa06k8ZzsrXYcn0seQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3512 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2022 9:21 AM, Jiawen Wu wrote: > diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h > index 67e9bfb3af..38c5d05984 100644 > --- a/drivers/net/txgbe/txgbe_logs.h > +++ b/drivers/net/txgbe/txgbe_logs.h > @@ -48,11 +48,8 @@ extern int txgbe_logtype_tx_free; > #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0) > #endif > > -#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args) > - > -#define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args) > -#define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(" >>") > -#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt) > +#define DEBUGOUT(fmt, args...) PMD_DRV_LOG(fmt, ##args) > +#define PMD_INIT_FUNC_TRACE() PMD_DRV_LOG(" >>") > Hi Jiawen, This won't work, macros are missing the log type. I guess intention is to change as done in ngbe patch [1]. I wonder if you send the patches even without compiling them? Expectation is authors test the patches before sending them out! [1] PMD_DRV_LOG(DEBUG, fmt, ##args)