From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 524A4A0C47; Wed, 27 Oct 2021 17:53:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3559441151; Wed, 27 Oct 2021 17:53:22 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6C6DB4114E for ; Wed, 27 Oct 2021 17:53:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="210273878" X-IronPort-AV: E=Sophos;i="5.87,187,1631602800"; d="scan'208";a="210273878" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 08:51:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,187,1631602800"; d="scan'208";a="529672698" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 27 Oct 2021 08:51:33 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 08:51:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 08:51:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 08:51:32 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 08:51:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpPqlK4iXdZXdaalaRSRP97XDfyM7taWduUuMX7SM2qut44JL6Cnpa551NGkpl2PixANV1BRPu3quVjdUPQjz27UnE1VMKBoY6pDogQ6V2YfsdUKVyHYCDt11u3JX00m7w605czz4kT+AeRzRivT5GxRKSF7ZQNdxyc+JLzVpbwHZN2lumOuUpGv8Z7i32JQJCaDy774EtyQdiIb747kWy3tqiuBDXPj20nn+rm02cLg607KNFm3phXFoaxAVpI3cfGR2xJJgOt888gP2nWhULeCoCRmlVcBqQXBtcMLRIA7okXOPRnRXIa/AQfhOrhRulCbaSKVVdthGP3je6hNFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JLGmvV2iB2IHgAVMDIJskd/ArZHLM5RHUnMCjNynhM8=; b=m5eUhJJPJfUQnzSq+EmDPKcS4TZxJqmum+IvintBOmOfoQG2oisKaPea6U+v6W1JLrvFr221N4idChYoGUsmpb5WB5xxeQlTZ9b/kg+i66RpL2XGuTojKZgqKMoX1/qikkOihohqnx5Gubz2XltoG9CxBnCnDwZ9XhEE7neiU7qFtb8HO5/2xBvmUV1+svbc0FQMmmiU5E5i6YsHxQuQHvRdrzZ3duZXaJyp4wF8X/jMp5BdXCjXefUwS3wzZMty8qK8Rk9+7JCcxmIIAxGRnJ6Ok7aRmml0OJneYn/jg2shduzl6vUObvwAsudUscEI9lkRDoyeBqsURYoQhWe1Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLGmvV2iB2IHgAVMDIJskd/ArZHLM5RHUnMCjNynhM8=; b=raQ33OpPekBUCo63OqE/GX/dWx9VvwEqSaeYhKjWjONLXh/5jGM7imL1BvPxfOI/OJUIz0HJAMUmgIO8TCVXiPFd93qxVO1hO6wCvreAmwXn5bIHR742udhQpoagLa+JFiFtdMqKr6DpZ1g+KomybRNLXNJnRFSZme3+zKprZ3Y= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5094.namprd11.prod.outlook.com (2603:10b6:510:3f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct 2021 15:51:31 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 15:51:31 +0000 Message-ID: Date: Wed, 27 Oct 2021 16:51:24 +0100 Content-Language: en-US To: Andrew Rybchenko , "John W. Linville" , Hyong Youb Kim , "Konstantin Ananyev" , Ajit Khaparde , Huisong Li CC: References: <20211026153802.1820636-1-ferruh.yigit@intel.com> <20211027091429.2996153-1-ferruh.yigit@intel.com> <1bf9fa5c-4b7c-6b96-5723-e3d8af958bdb@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1bf9fa5c-4b7c-6b96-5723-e3d8af958bdb@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0202CA0025.eurprd02.prod.outlook.com (2603:10a6:4:a5::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0025.eurprd02.prod.outlook.com (2603:10a6:4:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 27 Oct 2021 15:51:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb316c91-ec6c-421c-f455-08d99961a565 X-MS-TrafficTypeDiagnostic: PH0PR11MB5094: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W2SimwThOdx0BcpaBaATcovrNGlo+Ooml/n0CZW+tv6/d2Dyn4zhMYZREoo9Je2aaclZwFcPlHcd1Jpfh4d2pS8pWRYZ+DsHTcF8uw79mocXHziM9wvcYcB0N4wuKwpqJX8st/OQyyy5cqPRRut7ZYKCh+t/p41CQSu/Y6i67J5sqyx+M2UKDAau3HDLSmHoY6IAnFtzdk5UMCJS1Myai4wQVPwFE/u2AjCy9gY+5DwbjTlogG/RiO7VgKVhRbNn+zSz1csJ9bFQJuVyhu06Z4Qx+fA9WCObnKF9qQ0BOEz8ORNrEDPThFCD4fM17kN3rmyfYCUt28mxhYUCmAtwLGRqrbUYWUZTG3EU8EuxKV5E5nFYuyv6WcMJczfi/y0ZY+aEIf3aDWhY6//XXsD8Cim/H9rVx9pCPadYWssZsigO5qiYvN7rddbNIzAhAbNncexdr3vKD/VILtjIrG1qtyYbjQ2xqo0ZPHE6lbrC7kDJu66KKbLuRfUP8Weus7V6+zSaExfuZjGsCX0Y3JUUyIUe1t23wHYhiUptJ8Z014fHtKzPWTb9nPhLDfqziAIQPmbAgK9MDZ+3bZUpd3sHLN8O2E1B/3v3nHF8vCz+DVv9qAXqIyurXEFHU/eMc8QQyF5KJ+xSroqTigkFXK2jV/pwmXeNvcJS+AJ/PY+WJEYbvNIBk0GZ4d2edQY5QNMqXqwif5ETtO9x81Qcg8hEvg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(16576012)(66946007)(82960400001)(316002)(31686004)(186003)(110136005)(2616005)(956004)(26005)(38100700002)(86362001)(36756003)(66556008)(6666004)(53546011)(4326008)(44832011)(508600001)(8936002)(8676002)(2906002)(6486002)(31696002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjRXbld4RGhzTEtrNWR1TnVFajRWL1dxTFJPazVnSDhaV1pHTWZyK1VrL2sw?= =?utf-8?B?T3hZcWNHdlpyNHByT3lQQjZFZ2FicVFjZUdzVXlwUTh1QkROdElMUHpLZnpq?= =?utf-8?B?WFgrK0NWWHMxdUw4dk1RSlpLNkhBS1VTWkd3RG96WWJwcnhsYzlmVENwQ0NS?= =?utf-8?B?Y0VVZlJESURGOFRqcDQvaTlVNFd3VFF0am42TktrOVZ4Q0h6R1B3cnJvbmRU?= =?utf-8?B?ZmxZNTNPU09TeDZhYXU5QjdLbC9xaW9FWExJSkwrSit3ajV0ZGJBZG9xMS9o?= =?utf-8?B?d2swSTAzRGxLZlhTUkFESEdxUlhlZE92MU5TVFp4MGNiUmlORHVJejlhb2Rr?= =?utf-8?B?VVp2cHEyUVV6TU91M2pvZkQ3WUtXOFFRNVpGNW5qN3BscFpIdUhhRS95eGtr?= =?utf-8?B?NjRQZ1BTL2JXbjkrL1R4TFVIbkFlY1NYaEpOWm1qSHVPRC93dlJUYXpBWitj?= =?utf-8?B?NnNjUDZ0R3NKN0I2ejVnck41amhTNGdpVEpGQ3VwbnRDdy93TXowYnIyUE9w?= =?utf-8?B?cmNiUXZ5L2pqK0lKUVNCdTMyS0RwbTBXNTg5VTJ3T01ET3d3Wm1ENHVZTlFv?= =?utf-8?B?ZWtmcEFlNldiQ2hrQmpiYUdwRTFMUEczYjVmU1E1c0kwYWgza1ZvNlhUaDUx?= =?utf-8?B?cWZVZFpXaVpnZWZMQm9xNHljUHp2cGdWMmwvMVl2cnVVaGVGREFNWC9kSjMz?= =?utf-8?B?U1BCWFpyQ0JjTHFEbEViZUFRT1dHd3FUdHZXOU5yNFhwemdqeXJnZjNNR3N4?= =?utf-8?B?TDVUOGhPMlQyY1pUR3ZaSE5mbitBcjZxWDFpOXhROWtuaGNNa2tQUGY3a0hv?= =?utf-8?B?cmJsRlFSczM0dkp2U3YvelFJZW9lbDVWV2dhN2NuZ09uRmRQOUJ1TW5vRk43?= =?utf-8?B?QXdTL3pKdk5WTVl0bGc2VlpwZmhPcUY2QnhHZjN6QVloblA4U3JvOXNaenhC?= =?utf-8?B?U2ljbmhiR2pqT0R2SlUrRTlwNVNlRUdidnRTZ0JhWmJ4MkdZRjdiMDAvQXBT?= =?utf-8?B?cWc1VW5acklKS2Yxd2hlMWlqTXdzRklFTENnVUtLQ3FFNzhON2p3bXpEL05X?= =?utf-8?B?NUhiYmVuSmt5T29KbmNsUXViQ3Q2WktpdnZ1YnR3SWxzd2crVWFvaW5rQnUv?= =?utf-8?B?S2p6S3NzUld3WWloSnc0T2FHQVBodHZRenl0WkxmbWZLRVR4RDZXcXErTG5I?= =?utf-8?B?bGZpUUFyNmEyamNyQmdvNHFIS0QvUFVXNnBqQWFCN09UMVNOZDlxbTJaUDMz?= =?utf-8?B?VGZ6aTNiSEFCa0FkcnZ3MVhpd2NSNk5PM2xCdG1wcFlEUnlZZE9NTW5PbDhm?= =?utf-8?B?U3N3NDJSRzJMcDRFODJpSi9yWFhrV2xzNlVLU3pPSFBvdzF1bDZiT1N2Mmg2?= =?utf-8?B?ZnNjU29IZktKMlQ2aDdLN3p6OG1rVWVLVmFCazY5cW5ZUXprRWVNbnJ5dkpi?= =?utf-8?B?T2lYQWtsN0J6Y1Z2R09yZUE4MzgyVk5qQjZhS0d1Yy9rb1BMb0RSVVNYamow?= =?utf-8?B?bTEzNVJNS2IwNms3MnNvYjNmM3BFR3ZGd3ZKN0FsOHNqMmtUTzcvWjBIS2U1?= =?utf-8?B?ZHZLYnY4ZmFxZTRNdTB2NXJkTzJuRVRyZGIyTXljK3ZYRTdLeXBtQXd1bnpP?= =?utf-8?B?dndQRU5BYXBTOXhWZzFadzJrNVVpa3AwT2JQa044Q3pCekxjUWhSZG5XL0Nj?= =?utf-8?B?Q25VcFp3T1pNSUg2cFIyRnBvWXZTYVIxSlJGOTZpZ0l6VlBvRGRRbGhDU1Av?= =?utf-8?B?REowcHFRSnJsdmUrTnRBTjUraGMwck8yZnFoYk1SQm1QQlRGdUJZc0t6L2t3?= =?utf-8?B?aDVEMGVGZXdFWTBYb0U4RVRUNktZOWg0b2xNbXdsSTJHMmNVVUU2dW5iK3Q1?= =?utf-8?B?K1RpS0oraU9LYy83R1cycmtMaUdlTGVxenRCUWcyMmE4enVsbDRJTUJDLzBS?= =?utf-8?B?VjdkNzlVdFh5RnVYRlFSWHhDdTZUSDhWR21BbDc1V0xxSVc0V3FjRXB5TlE0?= =?utf-8?B?OFZ1RklYU3lLZGxaN2N4ZWFIbXhMU1o0UTJreSt6SGZWTllTOUZKOEVkQVJR?= =?utf-8?B?dWFHRHRBbTNvQk5jMk12bzlUQkRWOERoQ041d1Qyems2bTRGNUw0RFpibE82?= =?utf-8?B?NnZCdlk3TnRpRllvYXNYbmR3aHZTdjBZTEtmOWJnWW5pOUZjRFN1eXExeGR6?= =?utf-8?Q?D25TOYQBU8WiuznqzvTlhP4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb316c91-ec6c-421c-f455-08d99961a565 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 15:51:31.7695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BEscohFYS/hKgVpXx0+4h51FXAnDxvhaaZwa2akWSPkBKKvyKzf5WZMdkm8zgPp4J3ckg6Nhc8AiFW+55Jh9+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5094 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/af_packet: fix driver init with default MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/2021 4:12 PM, Andrew Rybchenko wrote: > On 10/27/21 12:14 PM, Ferruh Yigit wrote: >> Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length, >> which doesn't include FCS (4 bytes CRC). But ethdev by default uses >> frame size with FCS when application doesn't define any explicit value. >> >> As a result device configuration fails because device is tried to be >> configured with a frame size length that is bigger than what device >> reported as supported. Device reports as max supported frame size is >> 1514 but configured value is 1518. >> >> Instead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the >> driver to report the max supported frame size, this matches to the >> initial intention. >> >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >> >> Reported-by: Andrew Rybchenko >> Signed-off-by: Ferruh Yigit > > Reviewed-by: Andrew Rybchenko > Series applied to dpdk-next-net/main, thanks.