DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: "Shahaf Shuler" <shahafs@mellanox.com>,
	"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats
Date: Thu, 23 Nov 2017 14:06:27 +0100	[thread overview]
Message-ID: <cffa957e-b2e4-a89d-7b76-2673a82f17aa@6wind.com> (raw)
In-Reply-To: <VI1PR05MB3149507F228D322E5B390BA4C3210@VI1PR05MB3149.eurprd05.prod.outlook.com>

On 11/23/2017 02:00 PM, Shahaf Shuler wrote:
> Hi Thierry
> 
> Friday, November 17, 2017 9:55 AM, Nelio Laranjeiro:
>>> 2.11.0
>>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> Am having the following check-git-log errors:
> 
> Headline too long:
>          net/mlx5: cleanup the allocation of the buffer used for the ethtool stats
> Wrong tag:
>          Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics')
> Wrong 'Fixes' reference:
>          Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics')
> Is it candidate for Cc: stable@dpdk.org backport?
>          net/mlx5: cleanup the allocation of the buffer used for the ethtool stats
> 
> is the below suggestion[1] acceptable? If so I will merge into next-net-mlx
> 
> [1]
> Author: Thierry Herbelot <thierry.herbelot@6wind.com>
> Date:   Fri Nov 17 14:51:34 2017 +0100
> 
>      net/mlx5: cleanup allocation of ethtool stats
>      
>      Simplify the computation for the needed size:
>      - exact size for the structure header,
>      - exact size for a number of 64-bit counters.
>      
>      Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics")
>      Cc: stable@dpdk.org
>      
>      Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>      Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>


Hello Shahaf

Your suggestion is excellent: thanks for it.

	Best regards

	Thierry
> 
> 
> 
> 
>>
>> Thanks,
>>
>> --
>> Nélio Laranjeiro
>> 6WIND


-- 
Thierry Herbelot
6WIND
Software Engineer

  reply	other threads:[~2017-11-23 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 13:51 Thierry Herbelot
2017-11-17  7:55 ` Nelio Laranjeiro
2017-11-23 13:00   ` Shahaf Shuler
2017-11-23 13:06     ` Thierry Herbelot [this message]
2017-11-23 13:20       ` Shahaf Shuler
2017-11-17 15:08 ` Nelio Laranjeiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cffa957e-b2e4-a89d-7b76-2673a82f17aa@6wind.com \
    --to=thierry.herbelot@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).