From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B46D5377A for ; Thu, 23 Nov 2017 14:06:40 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id u83so16827652wmb.5 for ; Thu, 23 Nov 2017 05:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hju3DWknu1chDo6QvN/ZuIfRa1bmd7GY/nhKUD0rYWU=; b=UZqCwtZkDjJyo8s6U0DmJL2Cgqk8Ej1a76ZhYBm6fgAEqCvG96g2s63uL7y/7LaFbJ fidgT7SuGfwFni2Y4QHj0jBWWOqziP6D2/bSwtC2+qBFsXx39UQzNtoR7HnrhiiG/APk gzNRI2XSpusJFT88v6J2ADm7+ttqdnRQnZf5Qh978i/Lwc52+4o4Wbz0iZjdZ6SKk3le TV/nzI8jVcH2CMtbiMFpeA2zyLDcKraMImZVf55dxSOYn2OSkcwl2P0D1w9rjmq39UFs kEUI2tdv846/aZ4KyiAqg9ghPFhUW/pMkm4TcK6Uj3UeCmtGWXlqVVPl2L89BbYo1R1Z VKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hju3DWknu1chDo6QvN/ZuIfRa1bmd7GY/nhKUD0rYWU=; b=m44RZcI4kskiwY7Wqu6dYDbz1IAR0EYD8zvFJ8QX447iHm/dzs0H0W3W+hScRK8cSp XGRPdjpsElmEA14mxat5iiBZ0C18hkDuwF7Zhq/oLZ2b59BSTil7pdccNrPltE8msJZ6 v52kt+HkOndeqUlLCFTi74XYJaz53wvlbWu2csdkBmy8sz2EdTEwc8phfmbeV2WOI+1D 2yJRgloorX9V2eLQAd48oVoC9nqVQeCJ4lxM0WgETc73wxJ/ceSEVhq6UK5yip7pAyUQ HdqHH2nAfbELmanHXimV25p+Qvcuw7cccrnqXVic4etbLm30wQvEIke3z5o64kwo7gHi QtRw== X-Gm-Message-State: AJaThX5CGFQRrUMxjmiTogd4aZX1yFOgPyHC6HoTlk0nofgjgk5jp3wZ bi5u1bitAx7GwyDuCKL3NF67 X-Google-Smtp-Source: AGs4zMYlFOhUeIMeVDF2Mue/yvf43lzISyluEfUGOdoFHqBn/XFko04fhsDcojwdzblnNnYo3xC/Wg== X-Received: by 10.80.187.99 with SMTP id y90mr29533664ede.154.1511442400405; Thu, 23 Nov 2017 05:06:40 -0800 (PST) Received: from ascain.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h56sm15789808ede.15.2017.11.23.05.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 05:06:39 -0800 (PST) To: Shahaf Shuler , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= Cc: "dev@dpdk.org" , Adrien Mazarguil , "stable@dpdk.org" References: <20171117075500.bgusljznteuhwdo2@laranjeiro-vm.dev.6wind.com> From: Thierry Herbelot Message-ID: Date: Thu, 23 Nov 2017 14:06:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 13:06:40 -0000 On 11/23/2017 02:00 PM, Shahaf Shuler wrote: > Hi Thierry > > Friday, November 17, 2017 9:55 AM, Nelio Laranjeiro: >>> 2.11.0 >> >> Acked-by: Nelio Laranjeiro > > Am having the following check-git-log errors: > > Headline too long: > net/mlx5: cleanup the allocation of the buffer used for the ethtool stats > Wrong tag: > Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics') > Wrong 'Fixes' reference: > Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics') > Is it candidate for Cc: stable@dpdk.org backport? > net/mlx5: cleanup the allocation of the buffer used for the ethtool stats > > is the below suggestion[1] acceptable? If so I will merge into next-net-mlx > > [1] > Author: Thierry Herbelot > Date: Fri Nov 17 14:51:34 2017 +0100 > > net/mlx5: cleanup allocation of ethtool stats > > Simplify the computation for the needed size: > - exact size for the structure header, > - exact size for a number of 64-bit counters. > > Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics") > Cc: stable@dpdk.org > > Signed-off-by: Thierry Herbelot > Acked-by: Nelio Laranjeiro Hello Shahaf Your suggestion is excellent: thanks for it. Best regards Thierry > > > > >> >> Thanks, >> >> -- >> Nélio Laranjeiro >> 6WIND -- Thierry Herbelot 6WIND Software Engineer