From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 437EEAAB3 for ; Tue, 17 Apr 2018 17:46:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 08:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="34051375" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga007.jf.intel.com with ESMTP; 17 Apr 2018 08:46:27 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w3HFkQih030699; Tue, 17 Apr 2018 16:46:26 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w3HFkQ39023696; Tue, 17 Apr 2018 16:46:26 +0100 Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id w3HFkQSE023692; Tue, 17 Apr 2018 16:46:26 +0100 From: Anatoly Burakov To: dev@dpdk.org Cc: thomas@monjalon.net Date: Tue, 17 Apr 2018 16:46:23 +0100 Message-Id: X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 15:46:30 -0000 This patchset fixes a few Coverity issues introduced when various parts of DPDK IPC were added, and explains away other reported issues. Coverity issues fixed: - 272595 - return without mutex unlock - 272609 - fd leak Coverity issues intentionally not fixed: - 260407 - strcpy into fixed size buffer - Both src and dst strings are fixed size, so this is false positive - Hopefully will be silenced by replacing strcpy with strlcpy - 272565 - strcpy into fixed size buffer - Same as above - 272582 - strcpy into fixed size buffer - Same as above - 268321 - tainted string - Not an issue, we handle errors correctly - 272593 - tainted string - Same as above - 272604 - tainted string - Same as above - 260410 - not checking return value of rte_thread_setname - We intentionally don't care if it fails - 272583 - return without mutex unlock - Independently discovered and fixed [1] [1] http://dpdk.org/dev/patchwork/patch/38042/ Anatoly Burakov (3): ipc: use strlcpy where applicable ipc: fix return without mutex unlock ipc: fix resource leak lib/librte_eal/common/eal_common_proc.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- 2.7.4