From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 31093AAD6 for ; Fri, 27 Apr 2018 19:07:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 10:07:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="37556697" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga006.jf.intel.com with ESMTP; 27 Apr 2018 10:07:11 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w3RH7BGF026427; Fri, 27 Apr 2018 18:07:11 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w3RH7Aj6023459; Fri, 27 Apr 2018 18:07:10 +0100 Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id w3RH7ANT023451; Fri, 27 Apr 2018 18:07:10 +0100 From: Anatoly Burakov To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com Date: Fri, 27 Apr 2018 18:07:01 +0100 Message-Id: X-Mailer: git-send-email 1.7.0.7 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v4 0/9] Coverity fixes for EAL memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 17:07:14 -0000 This patchset fixes a host of coverity issues in memory subsystem introduced with recent DPDK memory hotplug patchset. Coverity issues fixed: - 272601 - leaking fd - 272560 - double close fd - 272568 - leaking fd - 272570 - leaking fd - 272589 - dereference before null check - 272602 - freeing wrong pointer - 272608 - expression does nothing - 272584 - use after free Coverity issues not fixed: - 272577 - negative return not handled - 272578 - negative return not handled - Proper usage of API guarantees no negative returns Additionally, also replace all instances of snprintf with strlcpy. v4: - Better comments for fd leak fixes - Improve fix for double close fd v3: - Drop fixes for 272577 and 272578 and mark them as false positives v2: - Rebase on top of latest master Anatoly Burakov (9): mem: use strlcpy instead of snprintf mem: fix resource leak mem: fix potential double close mem: fix potential resource leak mem: fix potential resource leak mem: fix comparing pointer to value mem: fix potential bad unmap mem: fix statement having no effect mem: fix possible use-after-free lib/librte_eal/common/eal_common_memalloc.c | 5 +++-- lib/librte_eal/common/eal_common_memory.c | 6 +++--- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 33 ++++++++++++++++++----------- lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 4 files changed, 28 insertions(+), 17 deletions(-) -- 2.7.4