From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 193BB43206; Thu, 26 Oct 2023 13:30:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4E27402CE; Thu, 26 Oct 2023 13:30:49 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2076.outbound.protection.outlook.com [40.107.220.76]) by mails.dpdk.org (Postfix) with ESMTP id F051F402BA for ; Thu, 26 Oct 2023 13:30:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSg8EvdDXJMeUpb1QdS31sSAW0GmrkjKU4Nj7n/YGg8GLYxUbiqMRs94aj9OnBPdnBsLK6swYxW5EZ6mvzvpzZkB3jCmvxTerBCVHxI86w7Y5i7ZIFG2dLGXO58AFH132A2W8bsz/R2YGobaS5LxsmuUAZARP2YnVWtNyvlDVfA1W+s3UGWvM7/1qrZq0u/MnG6Q2pWsRaKDiDM5XnDNOkrvkrlCoDfeCRzL+EZkqsuYShJHNnxfw59DyZH7LmLzYx4o1vBXNCGXywFIJMMLoLKi2ZBEofdDD66ckmPNE3rjNSQHsetGGaDWmnaYgzPdVKJpxTp0LkYsCf5UeYPmZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DWQzWlJOsR0ebW5s4aypJFiGurHUTLpJVhqJDLL1DPI=; b=Vj9yKKZgPRKq0jTY1Nf5hO+A+X60eneqOKpDPUH+ck5QWDRQvRkpfr6ANp0/jyiFL9i9sTqsjm/gXYC6DSGj1mPIP7lq7I0pwlhu9L1Eh+gT53i4v+4YB6rraYDnwlE/0+/PJtQ8pxQmMFgq7xyJv49RI2lhcw1kXOSnWyzCG72e1V3bd/IW2oupXabJlGWkyW3Q1Bvqk0et+9Ck7bnuFBPJ+X1LSnvZ66Re1TrmsFblSKaNM6zTu2FeeGPeamVh8Vwm4uHwKgmx6WoZEk6N8NztLcQVWPCBVivhvHEIeoQz77NrTJr3hUgeO9F4yjY3ctmayFZCg+cdQjkxBZ4UZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWQzWlJOsR0ebW5s4aypJFiGurHUTLpJVhqJDLL1DPI=; b=QomLsZWmZuWp7dLHypl3ijFr6bObYC9MD5WsYhZ+i9NzN7aW5DPhXIec984PuiSsm4AShGR3MK9k0j6DMoSSD3zzg3em1ijyKRTbRuCNb1PC/cvf7w72zg/u1bWCnZqwNsL4/eH1BX1e7e0CddizAfMyzR/NRpDFvcd9FtsUHKM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5331.namprd12.prod.outlook.com (2603:10b6:610:d6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Thu, 26 Oct 2023 11:30:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Thu, 26 Oct 2023 11:30:44 +0000 Message-ID: Date: Thu, 26 Oct 2023 12:30:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/25] add the NFP vDPA PMD Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" , David Marchand Cc: oss-drivers , Honnappa Nagarahalli , Tyler Retzlaff References: <20231017054545.1692509-1-chaoyong.he@corigine.com> <20231024022849.3092506-1-chaoyong.he@corigine.com> <14f709f5-6290-4ee1-8c8f-dddcd938240c@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0419.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5331:EE_ X-MS-Office365-Filtering-Correlation-Id: 142bd0d5-5e1c-4379-5fd0-08dbd616fe0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5KtuSAObZhhqiR/DT1bINltul6Kzb/fRHNjccm8G08K33Km3WYmoWbM4LRN2GWojMglw4cd/WT6UPlajgJIcEHZnMea7xH9CGdjH7uyrwIo6tqhHLzURmiCiTugR5NhYQNJfR4sUxJmVYPHmHV2HHuH3MlITJzbYxWcT3ySmUljpcnXME3G2d9S+3AW2n+lScV+1EFOvYzHIeMV+voewbSNkQ8hiV72X1nlD2BV1FhI6lzkIX1RoIfeCQyrJ7EEot7Bhyn8r7MUa4EZp3ftvb3TwzVvQOu5rxbTHhgtNtizvZWuocR9FzUjWWQBnk1X1fJOcGl42x4PZvcaiK/+KdCCiDyVUtGjkecKV0ARrldcKxahAXXoeadrH01loLvMU5k7KsXJmM5beCV7Mf4W5UPKmOUqu1xYSa76CouL1isb0M58eQ4JeoadnOhI6FXRtOK4jOTl3Ox2tMO4TcmWAFzsFTEx5FP2ukX+pHbG8JomGsz+mQ74sVfgxWeZpNkG1ejbl+H5r7MdgP7V3kUgmU+X9Via1ILfZds8sGsPNOtA6kA3hWk4EeqRroujRj60aIMKjn6CIuUfOm+cL8hSLlJExG3v/ysnB4f1+rYm/oGSlwwXFPlfEa2yyOvxPQwqAixRdqOQXPMmN6JF6853mazRggeLQn+Y6HZFT5f9OjUA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(346002)(39860400002)(366004)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(2616005)(6512007)(44832011)(41300700001)(5660300002)(26005)(6486002)(966005)(8676002)(4326008)(8936002)(478600001)(66556008)(316002)(66946007)(54906003)(66476007)(36756003)(110136005)(6506007)(53546011)(6666004)(86362001)(31686004)(38100700002)(2906002)(31696002)(83380400001)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3R0eE0weTNlTm5laXB3MDNOc04wZEJicEFyVXFDN0RDcmVoTnBWeXBnZ3l3?= =?utf-8?B?MjVVOG9mRnRQRmJObE1idXBMaTlRMXU4bnUxT2swdjJ2TnZWNFpqSG5BMWh5?= =?utf-8?B?QjI1ck1lOUcra1VNK2dXZ2lFRGRYcVpTQkJiSXU1YnI2aldBd0dzUzh2U0Zv?= =?utf-8?B?ekVub1pJNHgrTm1OQmdSMmRrcFpDb250RzhCQWtoR1FiSHlCMEFkY3ppblBB?= =?utf-8?B?ZjAwWXRZbitwbzdLdGllR1ltVStTWEt6Y3EwcWJwTi9FMDZLVU1pZHRxVGU0?= =?utf-8?B?b3RXRDVVREtPMExEQWxaamI3UEQ5c1pGTlVGbmxTby9XWWJ0RUY2MnhtRTlp?= =?utf-8?B?cHVDWUZDZnFNa3hzRzNaeXNwVUVOdjZ0anVmSW9wbXdGT2V6RlY0b04rc1VY?= =?utf-8?B?REFRazBuUit5OTFJY01LbGdQN0NVaFNDaEFwRXA5UVpzN0huOXRXT0dRWVpS?= =?utf-8?B?anp3RUxENHZPMWxuNlJLbUpEdm9tRFBrL3kzeDk1dGRzeDRMY0s1M1ZieVda?= =?utf-8?B?bXhvZTVGbDlYM0doNDJzd1EyaHFtTGpIM3FUVFg0Nml2Q2JjQklUM2FkTkk1?= =?utf-8?B?TlJLZmZJaUlvWkJCMmRQaDRtd2kzbHdZVFg4RzR5REtNamliZU4yRi81UFdU?= =?utf-8?B?c0VUWk1FRUdWVTZoU1hxWlhHR2xUR1EvVmdPUHk2V2RhaVB4bVFUbXY5SEFX?= =?utf-8?B?SFJJZEJiZytKL1ZCQlBiNzhlVC9KUFQvOGllVjAxcElialMxVFRBa1BXS1Bl?= =?utf-8?B?N2NIMnBtU3ByVU5qckVCL09USTVwNGJVRG9Fa0FrcXZVMnBFZVZpdHhmUVhl?= =?utf-8?B?Z0o5TVI1S0M1UkRPUzFJZHJyNkdCQnJDY3lObDFtbFp4a21adW9HT1pScDUy?= =?utf-8?B?c0NHUjVwYXd4clk5aDkvN0lReHd3VVE3aXgxT05yNXk4cUk4a0F3VURjdVdw?= =?utf-8?B?bVJaSTY3Y0ZZdkNKK3hiM0ZOQmhCNjlXVmsvYVlTV0tZM1J6Vmhwa3R0dlpl?= =?utf-8?B?azllQjRuSzQ2dUxJRmtPZDFFZ0t2ak9FbmM1NjBPc0NsRG9Fc20yRzNCRW84?= =?utf-8?B?NVJDL1k2dk1BcW5IcnZTdEsyV3N6V1JOWThYNFFLSDFqVzFzUDEvdi9lS1U2?= =?utf-8?B?RFNkUzM5VmdieTVWRHZ0U2NFcWNrczdxZEN5YmtPK3Z4ZFJTOHFJUkpkdzY5?= =?utf-8?B?RGp0djh2bjlqdTNsVmpuQmF1TU82TkhFQ1dZY3ZBTGd0ZW1HK0ltOFRCNG00?= =?utf-8?B?bmlFd3hZTTNNc2pySHh4MUhpNmppMjNLd2Rnc00zK0RrNFpyMmtuZTltV0o1?= =?utf-8?B?cnM2NHRwb3pnUXNITjVxZFc3UEJ0RWYzK2dwMDBJZVQzb3FERkJvSld5QWpm?= =?utf-8?B?S0NYUzh1cDJXNlluVGJvRUFzV2FaWHFEYTZ0UGZ6TFN5V1JWekRTTmxxWU13?= =?utf-8?B?a1JXZmpObWJDVXVWMjQ2TEJEUDllM1ZvVFo1KzI5dWNpKyt1YkpkQ0tKNWpL?= =?utf-8?B?SGRYZGVlUS9vV0VtL1ZjcjA2R29WU3Q5VFVRZi9DWHZ6dnd6YmphRE9iV1FQ?= =?utf-8?B?NWF3bm1ZcnJ4T1FJRERYZXhsbHVydERDNlAvaW1xUTFjMVlwU2FkYU1iZFRh?= =?utf-8?B?Ylc0QzUxQjR0enQwcDFUK3ArUTFEcFVEa2U4S29YSG9zbXc2TDFLTzcyTDlJ?= =?utf-8?B?bTk2ajZLc3VndHFKTTNFT1BFQXNaSnNLNUNJOEsrQjJkd0R4bVI5NnZwNStZ?= =?utf-8?B?b3p1NU9UUk1IOUh2ZGYrNnJRUWNDMnphMFo0bmljV09KbURnR1B4bTdsbzg3?= =?utf-8?B?REdBQzU2SURDd1VEMW1FWUZScjBCTkZza094MzJUMDIwSytsWjZZb3RjOWFZ?= =?utf-8?B?bEN0SXY5Q0JGdTA0VjdtdWIrV0dPTFU0M3gvb0xqZzk1dGNWZVlidlpuMlRM?= =?utf-8?B?a2ZIamRET1ZaMG9ZcHlQRm43ZHEwaHdNV2oxYjJhVmdsZ2p2SFppa0MvVjc3?= =?utf-8?B?WW9LQU83dVg2RE1ibHlOck9rbVJpVlU2VGpMVUZhUVZvcEo5Z3BpN0RFZzE2?= =?utf-8?B?dm4zOW1FVEI3RjRrcnpNbVhYdmdXN3BOQ0hWd3ArYXNCVEozVTZQbzljZEhm?= =?utf-8?Q?WGsA=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 142bd0d5-5e1c-4379-5fd0-08dbd616fe0a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 11:30:44.7811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQe/C/7CKshL4vhkqfm+UEIIyPGlC+hCRAngmbam0QCRXal5qBm/RYy5qlcnW7EW X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5331 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/26/2023 3:50 AM, Chaoyong He wrote: >>> On 10/24/2023 3:28 AM, Chaoyong He wrote: >>>> This patch series aims to add the NFP vDPA PMD, we also grab the >>>> common logic into the `drivers/common/nfp` directory. >>>> >>>> --- >>>> v2: >>>> * Grab more logic into the `drivers/common/nfp` directory. >>>> * Delete some logic which should be when moving logic. >>>> --- >>>> >>>> Chaoyong He (25): >>>> drivers: introduce the NFP common library >>>> net/nfp: make VF PMD using of NFP common module >>>> net/nfp: rename common module name >>>> net/nfp: rename ctrl module name >>>> net/nfp: extract the cap data field >>>> net/nfp: extract the qcp data field >>>> net/nfp: extract the ctrl BAR data field >>>> net/nfp: extract the ctrl data field >>>> net/nfp: change the parameter of APIs >>>> net/nfp: change the parameter of reconfig >>>> net/nfp: extract the MAC address data field >>>> net/nfp: rename parameter in related logic >>>> drivers: add the common ctrl module >>>> drivers: add the nfp common module >>>> drivers: move queue logic to common module >>>> drivers: move platform module to common library >>>> drivers: move device module to common library >>>> drivers/vdpa: introduce the NFP vDPA library >>>> drivers: add the basic framework of vDPA PMD >>>> vdpa/nfp: add the logic of remap PCI memory >>>> vdpa/nfp: add the hardware init logic >>>> drivers: add the datapath update logic >>>> vdpa/nfp: add the notify related logic >>>> vdpa/nfp: add nfp vDPA device operations >>>> doc: add the common and vDPA document >>>> >>> >>> Overall pretty clean set, but there are a few minor issues, commented >>> on patches. >>> >>> >>> Also can you please address checkpatch warnings: >>> >>> ### [PATCH] drivers: add the datapath update logic >>> >>> Warning in drivers/vdpa/nfp/nfp_vdpa.c: >>> Using __atomic_xxx built-ins, prefer rte_atomic_xxx >>> >> >> Oh, Sorry, we choose '__atomic_xxx' because we see the document in >> https://doc.dpdk.org/guides/prog_guide/writing_efficient_code.html?highlig >> ht=atomic%20operations%20use%20c11%20atomic%20builtins#atomic- >> operations-use-c11-atomic-builtins. >> Maybe we misunderstood it, we will change to the `rte_atomic_xxx` in next >> version, thanks. > > As the notes in the 'doc/guides/rel_notes/deprecation.rst': > --- > rte_atomicNN_xxx: These APIs do not take memory order parameter. This does > not allow for writing optimized code for all the CPU architectures supported > in DPDK. DPDK has adopted the atomic operations from > https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html. These > operations must be used for patches that need to be merged in 20.08 onwards. > This change will not introduce any performance degradation. > --- > The '__atomic_xxx' is the preferred choice? So maybe it's the 'checkpatches.sh' should update? > And seems there are many logics using the '__atomic_xxx'. > > Spend some time and confused about this now. > What is the right APIs I should use? > Please make it clear, thanks. > Atomics usage got a few updates by time, if I remember correct: first there was DPDK rte_atomicNN_xxx APIs, later guidance updated to prefer compiler builtins, and recently guidance updated to use C11 defined functions. And now there are 'rte_atomic_xxx()' APIs, underneath they use "compiler builtins" or "C11 functions" based on 'enable_stdatomic' config option and of course tool-chain support. That is the reason of complexity in the checkpatch script. @Tyler, @David, @Honnappa, what is the latest, up to date, guidance in the atomic APIs usage? @Honnappa, is the deprecation notice Chaoyong highlighted still valid? Should we update it?