From: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Cc: dev@dpdk.org
Subject: Re: Dpaa2 driver using system("echo...")
Date: Fri, 28 Apr 2023 15:42:29 +0530 [thread overview]
Message-ID: <d024fe19-14ee-f0f6-329d-4f212aa4d101@oss.nxp.com> (raw)
In-Reply-To: <20230410092156.546ffaef@hermes.local>
On 4/10/2023 9:51 PM, Stephen Hemminger wrote:
> When the CodeQl (https://codeql.github.com/) is run against DPDK,
> one of the issues it reports is the unsafe usage of system() in code.
>
> I reported and fixed one of these issues in the dpaa2 driver
> https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/
> but it seems to have been ignored.
>
> Could one of the maintainers of that driver review it?
>
Hello Stephen,
Apology for the delay and thanks for the changes suggested for dpaa2
driver improvement.
I have reviewed your changes and logically they look fine. When testing,
found issue of memory corruption that I have fixed over your changes. I
will send a 'v2' patch in context of your previous patch including this
fix for dpaa2 platform.
--
Thanks,
Sachin Saxena
(NXP)
prev parent reply other threads:[~2023-04-28 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 16:21 Stephen Hemminger
2023-04-28 10:12 ` Sachin Saxena (OSS) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d024fe19-14ee-f0f6-329d-4f212aa4d101@oss.nxp.com \
--to=sachin.saxena@oss.nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).