From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 981F142A13; Fri, 28 Apr 2023 12:13:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26E8A4113C; Fri, 28 Apr 2023 12:13:36 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by mails.dpdk.org (Postfix) with ESMTP id 2182F4021D for ; Fri, 28 Apr 2023 12:13:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UOsyMg1vAnAJcMpH2xlF6bI2Sesq6q1hXrn0Ao62i4U/8xvwM8ploSV4DJFca+pNL0R5AJ7zzEnGJjmKEOXdFXHfd/WjEIXPZFv0i4cDCTEE6q2JdQvzzw/6nTRR0kErgbhjIvRgbc/8PTsfX0hwH+EoWQJT+QxZ04Vuk73pR5/8m1ZYYMy4vi99TWL8QgsNABCyodsU1P8F4NPnBwz7uqXQBcUzxHhzT+YlTk2rRWlMabU552ehjQYusJ+K7crqximuBN+m+w5wmzNU8G0zoy6f9MIzwM8bDGnvtP1J0f7pZSk5ECRWdWxe6H+MytqMVc2HtBngYujzRBMGsKdVZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zjfCJPzDxuO508KP1H9yyRJHRHRwf94LooLfcWOHJxE=; b=iJ24OSuB236zKc0yfd/Qze1TfAbxpsmzUwwOMBHRvFctFa/FyY1+xyj90dEWYz/ruH66xCkHOcXHbQphQasFS9hVGl37IBN0xiTycy6aRDCIOtD/fU131QmlaLmd43gQ9M8HA1riEa4c2nh7y4YAsmnhUDTL7a6hl1z/8DKbe655mOlwC9SkbuceWhe/GGVkXikEgINLBagrsND4ruiqM83N3m01PVM6A29WquM913uw3vPEMoXvhPEqxIGT4jpg7tpF2Z6/m15LP6Z2+K5UtJP1khod0sGuX+4gfYiqdezxZ+2FaMZX7/pLGDvjOZXmTBB97gLq6oYjdKoi+uWUAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjfCJPzDxuO508KP1H9yyRJHRHRwf94LooLfcWOHJxE=; b=IM+W3A8Hj3PDs2raxvVCV5+mlwTsyFAiVL6XSW4xNXRa9nI635yzFbByyQaV2nNL1ZOLM7ZkzlCJ32mM96+FOOIzNKSKebznb8D2zPhpHc12/DxjmmlRx3pLZEPbx+QZGAOXYV6WK+S5m8Odj68lqfnxDv1cObsk39uzrP+X9hY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) by DBBPR04MB7660.eurprd04.prod.outlook.com (2603:10a6:10:20f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24; Fri, 28 Apr 2023 10:13:31 +0000 Received: from AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c]) by AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c%5]) with mapi id 15.20.6340.024; Fri, 28 Apr 2023 10:13:31 +0000 Message-ID: Date: Fri, 28 Apr 2023 15:42:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: Dpaa2 driver using system("echo...") Content-Language: en-US To: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Cc: dev@dpdk.org References: <20230410092156.546ffaef@hermes.local> From: "Sachin Saxena (OSS)" Organization: NXP In-Reply-To: <20230410092156.546ffaef@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2P153CA0007.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::8) To AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8562:EE_|DBBPR04MB7660:EE_ X-MS-Office365-Filtering-Correlation-Id: acbab9f6-208b-47b2-967a-08db47d137af X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4EtTRfN+S2GuVpa8ySDz6/t46BBzH73SSPTUuUZVR7IMYUrN2UabexeHXDf89bn75BvlIJo3RnE6DYvuvvvE2YPdxUwP+lpNhcEeTo7SIp7fweZRgPQj47mYqXYuzY0s39M8tKFmEOHf02X6r5IGWqaB+BEWoOlaF/Z5n2TpEJ0ZNhTDR/hNhnOEjXc1E6KYRV1jyOPPg+TZIo2qoAvb7ijWDBSxC1JwLv3vCoJ6z1IjFMmlNHPS+7mDgvFUu2qEz6r05y5qKDXb3Uq0J9Kz5QDyh32OvXjW11k+LGHo3hp2gCWCNLpQmUkUWqV+d6zepzcgg77jvqySGG4O3abohZ1T1NkR/5+D5+kSJP+mk81j7h740HcV1jzF94ec1KMViAIr2irv6Dcfv0KGytF4Km3EQ+k94M1pIYa9g9C4u3ZiYsK2nwf6rXNo+Sdi+Isx0QakloQJQYDz2SNgpa2JPw7rqG5GfHrrvEIEX3JNUquw8AF2lZIAf79DsFYxzmZ65j3XHKAeSAUCEDWLD+daNx3rbrAcAsJhZioOYJ7I+tccRi77exQ5hwjRWQelpYVLsWUk+Sd5QHXQ4zqPCKxXTNlkSSJmdmQmw7qFcWdpCwgAWsFYrlyeUO9PZNqudTOjzgU43J6xUQbBcJ9JVx6WWA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199021)(8936002)(8676002)(5660300002)(66476007)(66556008)(66946007)(316002)(38100700002)(41300700001)(31686004)(4326008)(2616005)(4744005)(2906002)(478600001)(86362001)(53546011)(55236004)(6506007)(6512007)(26005)(186003)(31696002)(110136005)(36916002)(6486002)(966005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3Jza2tQM25BVk9EU3VYSkZ4SGZlRFE3eWtuaHFXNXFodEJFaW0xN3VpQkdR?= =?utf-8?B?NlM0c3BMUENESk8wLzFpVVdUaDhYOVNGQTEyRjBUYllNQjFsVjhTTkpTR0RT?= =?utf-8?B?VXRBWCtZL1pBMUJPYjhlKzEyWGkzSGFTK1IycFZVdis5ZWNZa01sTVFlc1hm?= =?utf-8?B?VnBmMi9iSWthSEFrcVdwQUEyMWJoRzV0VXM4TzlROHFyWmZMbHVrUzdkOHFl?= =?utf-8?B?amJWZE1USTNwWHhNUUtWZWdjWUNYeVFHaGxUR3ZHdklPWDBsVEllUEZGUXpM?= =?utf-8?B?SUNHV0RoT0EvZmY5c1dYaFNjL2RPVTlvMWErRGl1Q080alVLQ0ZuZ3NyK0pD?= =?utf-8?B?dXJKR2NFbUtpM3dLbXFTS1JBblZhdlJUc0IvcUdReitZM3pRS25ndUNKVzJ4?= =?utf-8?B?bENQeEVnZEJBSndLVndpa2FERjA1bkZMVThGNC8yZldrMVRsUVF3WjI3eGJj?= =?utf-8?B?L0EzT1pyK2RZN1lNZEgrWTVrS3U2R1hLNUsvQlFuZ0ttNHlzRTYyYVRmSk5Y?= =?utf-8?B?cGN0MGcveEVPVWprU3F4bVRBVTM1NDNqSHRlSnlNMWJPSHZJTkxtU1hPQ2tL?= =?utf-8?B?bUM4dU9uS0I0WGlndVAwVG9qaWFUQnpmRVZmUjNCbzRRTjI5R3dEM00yb08y?= =?utf-8?B?VDBaa1BhbXRmd1VYRkdhVHZ4NFRaRlpTTzZxd3BkNXpqVkpQb203YVUyaGJm?= =?utf-8?B?REtJdjlnTlF1SFlmSkpUVmkxY1poeEV4MXNVd1ZQckVncGhIS3VMS2k3cWJB?= =?utf-8?B?aDhJa2VMQXZUeGhuRysyakMzNGo1bVJSK3o0TUwrcWhrTWdwRjVGV3ZCQ1Rs?= =?utf-8?B?eGtaVENEdXR2cmFSeXdPbXFHY0p5d203Zjh1V1lieG83aklYNnhHWExiSjZC?= =?utf-8?B?VnIwazlvdGdudWhodHJNQkZTb0gzbFZMTHJNUysrbkdBRE5yMkIybnR6Rk1X?= =?utf-8?B?VlplUVJDdSt1eW8wYjhxUkk2NmxkWStzZ1hRSldoYXN6Nk1HSDVMMjNhRjdU?= =?utf-8?B?emRCWmFqcjE4RWxiL2tza3lsOFVwR0hXNUZEaFNXVTNhK1BzQW8vRlpFdEMv?= =?utf-8?B?YzlJVlIrVE1QMGlCM0s3VSs4Mk9aUTZXYTlmRnBRZ2NROEwxSGQraGxZcVdK?= =?utf-8?B?amYySVVxenRSelR1ZHJjMG1kdU1mOXM0TW1ham1OckJIQjNpU2dMRTJsUWhN?= =?utf-8?B?eWc2aGhZbG11cTFBTFBKbWVNTTlwOTI4c0hqeWNtRkc2R0xvbDdpRDg4Y1dh?= =?utf-8?B?VnA2WHIxbnlpWVV0SmZDSHJHOElVUVYwQmt5cTE5djkwcktPbFZUY0t4czNj?= =?utf-8?B?cndYRGNPeE1KWjloTlF1UDdEaE16cnVUcUdLNlJJMjhkVE5LR1VOME5WTld6?= =?utf-8?B?R29zSm85Ym5manJqelE4TW5LNjBCUFRJZWN4YXdYR3ZZN0lrUnd4VlVhWWdr?= =?utf-8?B?NzhmM1lyaWNIVG9lYUpXU2NXSkRnejEvcmtjMkVFTEtsQjdTNjNMcHVwQWVE?= =?utf-8?B?eCsxU09QcHc4dWo2WXduTmhVL1oyenVnaE8veGJGWnBCV1NCUXZtTVBjaC9G?= =?utf-8?B?WEFGdXk2aHlza2FUbzh0VlR6QzVqMkFZb2RqY2YrNG1HMTE2Vk9WQnZmckFw?= =?utf-8?B?OExsQnZTM1kzSGRYalgzRkZxTFEzbjVtSlpqNEU0cjdyY0dHUjNKekJ4ZDJu?= =?utf-8?B?ZEMwK2JzZDdOTkdLRXJjckNERXN0dUY2S0l0SzhiaFN4dGt0T29zNTlLVVlP?= =?utf-8?B?TFNmZXBNRGZUZC9PeUwzU1V5c1BvUUh2aXg0dVNnU0ovWURBU1BSTGVxTkdy?= =?utf-8?B?M1Zpbko3UW1GUHg2UUwrWnZxZzdjY0NaVlNvb3J4M1BhUDZGNk9ScmtqUDA2?= =?utf-8?B?QlI4ckRPY3JOU1lNVVZTbTJ5TXIvOXdNb0lsSjNhRE40ODVRUC90aUc0OXAz?= =?utf-8?B?THBOSGRZdUhZcCtlaEFaR3pyNlNCdDRHcldQcHdvMjFid2xnVGlQS0Nub2hK?= =?utf-8?B?M2pWSGIvd1RtZ2dDYjZCb2U1eHBMdzJEeG0zOXRoYTVOSkNyTG1TcmpScmpR?= =?utf-8?B?YW1iUWt0NkNyWS9DYk8yODloYWx1UkZHSlp4Nm1XbnJnYzcrLzZ1cVI2MzM4?= =?utf-8?B?bDluRkZmcFdiajRRK2psOXRFUE9VNTZJaVdWNGdCZlltc3V0V2dMdnFoaG1s?= =?utf-8?B?ekE9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: acbab9f6-208b-47b2-967a-08db47d137af X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8562.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 10:13:31.7860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: le8BKzsuVtzHmW+LBzUHYXkuoZu4gpcwavWv73UpX4KB24QB0FBoTHB5h8WXmTs49OyFL3ZwjNVcdeJa0gmWjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7660 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/10/2023 9:51 PM, Stephen Hemminger wrote: > When the CodeQl (https://codeql.github.com/) is run against DPDK, > one of the issues it reports is the unsafe usage of system() in code. > > I reported and fixed one of these issues in the dpaa2 driver > https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/ > but it seems to have been ignored. > > Could one of the maintainers of that driver review it? > Hello Stephen, Apology for the delay and thanks for the changes suggested for dpaa2 driver improvement. I have reviewed your changes and logically they look fine. When testing, found issue of memory corruption that I have fixed over your changes. I will send a 'v2' patch in context of your previous patch including this fix for dpaa2 platform. -- Thanks, Sachin Saxena (NXP)