From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FBEA45C73; Mon, 4 Nov 2024 09:50:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 220A4402AF; Mon, 4 Nov 2024 09:50:22 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2081.outbound.protection.outlook.com [40.107.236.81]) by mails.dpdk.org (Postfix) with ESMTP id EA7714021F for ; Mon, 4 Nov 2024 09:50:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BTd5mahoLnOrsSz5Dyj17n0BS2xPLiH9UjqGNVbpMxWHKivdvIQ6g+p37DejJeqDf4cx0T68qtRTa4OwU7OMBAT990mBkoD6z0TLHzG09BOlxqJ7ckVxXO/R/1OBLYnk4BLxL0w74Z4h/alHASI7KGRX17wwNDyKf/HkgzctNxTO26mHnSszPz5TnGZXoXggMQi5EPGu+vdTumkRDXT3aH1S1ckRYMST2F1mv46R+mS6YwVpds0Xcwf6htJYSUjH3kfV2F9x8AqRG33A+kwCDHxFc8m6xwplnO+loMVSx9+U74yV+9EV1aP1YdIvaK/iePLiRtmaur/8AudcEnEvvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yqOnmxeRLJ0JaxsyYip3Hi0+R7gNwnsTPvV7PSRDMnc=; b=QxWTgEltw9rpUeQnOcYzTsw04pZqNtNFq66OodeC/fsERSfHvnLVnJgRNAE7KUakwwwhLCfwuIUjJLwb5tikk6OjWPN6F/KDvJWMCBXdRaG/TFOueMDawlYVCWh+Le66NRlk0RqwBJUIGwMFtF6hBF/EhMb7wQXxe3Pmr1JoZoWKq92e2cBP8dIT5w4d63NstWRo76JX63v/vQ8pxRQQ5V3XY0IU3WTnQDtV8mHyMAzVdlctvI7SgsGUS+AfijOEjqmZFzlhcC8TyO+DNECVBuZDvTtfCiBVBCJg2CydEX8JoMzDZ6uXoGTHKxtKepGoXzd/9fRrhEn2xM1xvsU96g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqOnmxeRLJ0JaxsyYip3Hi0+R7gNwnsTPvV7PSRDMnc=; b=BRHvp8tmSkaxdtIeAqgqe1dS3ZnjBWW9OoVDEyozTSvaL7jX0rxZrDQHHDDgaDp5rLhOj/wAPY7XAdBi+MFmXbgrl3ZVlrAWwjmUTDTa7bRfncYS/38EaST+XVkyYl5HbXb/u/mhY8ghGRobhNQndV2u0KoI7OQBPPj3bkZo9/g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV8PR12MB9450.namprd12.prod.outlook.com (2603:10b6:408:202::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Mon, 4 Nov 2024 08:50:17 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.028; Mon, 4 Nov 2024 08:50:17 +0000 Message-ID: Date: Mon, 4 Nov 2024 08:50:10 +0000 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOetlOWkjTogW1BBVENIIHY1IDAwLzE4XSBtb2RpZnkgY29kZSBh?= =?UTF-8?Q?s_suggested_by_the_maintainer?= To: =?UTF-8?B?546L6aKi?= , "dev@dpdk.org" Cc: "pro_nic_dpdk@realtek.com" References: <20241028073112.107535-1-howard_wang@realsil.com.cn> <1829a53dee504477a9cdb09e1568d133@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <1829a53dee504477a9cdb09e1568d133@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::12) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV8PR12MB9450:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c56317b-a2a2-4c50-872a-08dcfcadb4f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U3JaaXN2UE5qV2VBM0NQa0JxVVJ4VFZCTTNKN3M4V1pOYU5xUWxMSE0yN2Uv?= =?utf-8?B?OHc0Z2xOTTRsek9PZ2lOUmc3L1k4cC9zU2dLT0tIM1IyaGpRc0R3VXd3UVlY?= =?utf-8?B?QXhKU1JvM3RNUk1HaTRTVnVHdUUxWUpLWVY4aDB1UHlpcnNLZjJZeHFDSy90?= =?utf-8?B?S2w4U1FySGNDaDdMV0w0WFpxWTgrUXo3a0w1ckVPOTZ6QTRwdHJpVm1CaTB5?= =?utf-8?B?NWE1d2FBR2pBYXN0M3BHMG0zOVA3MTVtZEF5bjgyd0ZFM2xFeGl1bUZyT002?= =?utf-8?B?eXFUQjBlb2ZBT0F2UkFWTlRTcVpNS3ErMi9rTHFBcSs1M0EvY29BSWZXS0Vv?= =?utf-8?B?eFpkUFJVeEtjTjVDeENaakJSQTFGVmY0ZENJeDdBV2Jka1pHR3VmUDFxaUk1?= =?utf-8?B?YmYwQ1BpUm01RmNaK21rcllhYXB3a1drMndNb0xjVEd1ekRUTmYwQjJpeWQ2?= =?utf-8?B?RHhNQ0ZqOVFRcUFuanVTQklvOFNTTitPbkROVWsrS0ZIaFFtc29tNE9wS0xw?= =?utf-8?B?OXExMXlyUFplYllwdHBWVERON2w5Wm9Va2xRcjFkUGFOUit0SXFKVkJrTDFZ?= =?utf-8?B?YzFmdUo4YUUxdmsvSTI0czJWTVVYa2tGQlNrQk1TbkZJOExQM3h5bmhnZ0ta?= =?utf-8?B?YTRNQjZ2NWxZeWFNT1E5Ykl6VFlLTGszRUdKUnlsd2JoZnZkSGpZWDI5QkQy?= =?utf-8?B?U3JicCtibjk0TFAydFgwUlZoS25UT2NsTnR1d1MrbVlOZElZOGNvTjdNakJS?= =?utf-8?B?WUFma1ExdHVlT1IwNWwxRk5tQWJrM0wxQ3cxdjVpS0pxK21DRmpZQjROTm5N?= =?utf-8?B?TlFLR2pkYlk5YUQyMlIrT1J6UWw0NHN2dm93bEJvaU5xdXJDZHhiZE9LY3JM?= =?utf-8?B?blhtZTRPWEdSN2lSK1YwNUd3WmVaK1ZsSXlXRmlnNDdwMXUrZDFQREYzcDEx?= =?utf-8?B?di9KSmRSRkZoZE9hTjIzV2FqYmk0MVZpNXd3aFg5OHhOQ3FvWnpyU3l6dzVU?= =?utf-8?B?cHk4S2dYaWRyQXB3U2NBaE4reU9UWG9NOEVyeDAvOW9wMmt6Q0F6eVNrSkp4?= =?utf-8?B?MzN3Y04ydFJ3ZmptUVUzZWdNUVdQa21Cd2VKMFFhcmhrejN1NTJXUmNXOHkz?= =?utf-8?B?MXBQRXA2UnNzWHY1YjdBVmhXVkIrdHdIbzdUWUJYN1hEK2hwR3NINjNtblBD?= =?utf-8?B?MGFmbnRPOGdjWVFqTVNLN1pDN2dLTHNkTFBuVFphSURqQkxHcytabkh0dGha?= =?utf-8?B?K2lLRjU0cG1HRnk1QVJaWHIvRHJLZlFLRVl5dDE4V0V0NnllL2tubjF6b2Zm?= =?utf-8?B?SXVlWE1vTmtoU1lUWDhvMVgrZDIwa08yNkhTc3lnRlhEcG5uYmgzNDVGTjJJ?= =?utf-8?B?djB2QThNd2hBZ1NhaDMzdHhPUWRKZmpTTzNVQTI3ODVaTStScjErQ0JjUXlJ?= =?utf-8?B?RmV1NmpkWEVKT2VScm04TVlZSit6SkVtY25oU1FpandISmlVcGN5c2t3U3NW?= =?utf-8?B?YkpEV1FwUUFTTXJXczFUQWFkRGZQQ3IvcU9hbUNsSlg2MjlsV2RlTXhZVDNR?= =?utf-8?B?MFBKdFFxbm9MUkFCZC9hQVhnVzhSL1RVSnQzUXY0U01RVlJ3dTVQSzJvQ25Q?= =?utf-8?B?bm53TjF5ZjRZMmxuSUswOTVDK0o5Q25DSjV2Zk5LUDIyMjFpZk81RlN4bG50?= =?utf-8?B?Z3YyNHNCWVB6TTdOeHNTK2psV2tUSlAzRXVWNWZ5cHNzZ1JkSnN6L3BYRDVW?= =?utf-8?Q?uiLfK3pfTQOfLWzIs0rI0msSWJbvaBrfIQ/W3Fj?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVIrNDBxV25EWXRhVjJ0VXFVQnczc2VZL1VHV1ptM3phS3dVaklRMHdZdzBt?= =?utf-8?B?bm1YWjJkV1p3eXkyRmtFVE1HVzJuVnJ2SFFtTktZaEYwTld2MmtFc0x0Z0Jr?= =?utf-8?B?RkNXQllzM3c0eEJvKzBPcVg2dTAxZ0dId09BbFc2b0ZuNnR5VzNHUnpiNWhv?= =?utf-8?B?eGZnb3FsTGp2c24yNlZ0MHBHQWxqTW94aExLUmd3dmxta1JScVNGbGliaWJP?= =?utf-8?B?SmlmU0xKREZWWXZKM0c4Y0tCN2NsRUtlMWtRRHg1SDhpc2I4Nlh5TjMvcGVY?= =?utf-8?B?UTZseURvTGlsRW1mNnAzNEpyMGpPVHlpczBPMmQzaWU0RHhNTElEV3FvRi9v?= =?utf-8?B?WnRpUVRxVHRwSTR6eTVET1Zrb3gxM1ZFbTVLWDNrSWtiSVVpUW5SSlZDb2N5?= =?utf-8?B?MFYvc1VsNldFMnlRRkx6STRyUGdMS2ovcms4Smd4b0Z2WFlpQTRQMFRWNzZa?= =?utf-8?B?SGlwRXY0bHdJWTFhMjlKQzR1d2NIcXN5NWpKWGorTG8weVpqU1cxbm1pUWMy?= =?utf-8?B?a2FUVnMxKytTdDd0eXdLTEg1ZW9oTVBMZzhCYXdnaHl6cTZ1VEZGc29wWm02?= =?utf-8?B?UnZwOFd0SlJ1L1JTbWFpSWpmdkZZR0hOYXZyRmthMlIzVDN4QjF2SEx1RnpD?= =?utf-8?B?TEIrWmYzM3Y0SFRrd25CZFY3QnUzRXdCc2VaVEF1OFJEZTYwZHpDMVhUeUp0?= =?utf-8?B?cXU1Q0Y1TGhqcHdvWGV2WVVTQ01Ja0dvRGYyZmljOVdCZ3FkQ25Samp0ekxi?= =?utf-8?B?czJ0U2VWWGRibFJ2WmNBbXFoWE13bThuMXlFMWFKVGRUdGlRQjlVN3dvU0lm?= =?utf-8?B?SVZVMkNPN3pUQ0JUUmM2Z1ArTDlUeTEwUEpMQ2hCRXBIczUwVkhaUGFSTjlt?= =?utf-8?B?QktkWG91YzRYenVTdU5jL0JDVmJWR2FIenQ2cXVQRVAxMkNLK1dBNndBZ0ZR?= =?utf-8?B?WDUrdHJicHdEM1J0ZlJvdlVVLzE5SERDSVlFcytPL0hzU2dhSjJjOFJHUTdj?= =?utf-8?B?NUxzclNmaW1SdW5SOEFZK01HYWxrZ0xoS0dNQ2cxV25QQ1lNa1paM2djdTlt?= =?utf-8?B?b0hGN3hyR1l0d3J3Qk55R2V2NHlRNGU3OFBsd1J6Z2w5eldNbk0raUl3Skp0?= =?utf-8?B?Q3RWRWx6bk9WdnNIdExLL0I3ZWxtMXEySllseUVFdFA2T3Z3Z09hRTRJTk5k?= =?utf-8?B?Tk1LQ041cFhqQ2VraUdVbkt3VTdlNVBXNTRoQ3hjN0QybjRhWHdoMlFSN0Zs?= =?utf-8?B?eFBIT3pDaWkzSTVaOXR3bGI5T1d6cktvV2tWOVo2OExCV21LVkdXd25aaFpE?= =?utf-8?B?T1ZSSmJyR0NFTEE5dW9uaGN5eVpYUFdYWkN3SkdPNjVidFJ4MVlyK1FZTnZi?= =?utf-8?B?YlNraVlrWWI3WTBwc3pIbmJhMWoxbnpCYmNBMGVXc21jT2E5MWlTWGxxNXBD?= =?utf-8?B?aTcxbEFxRzlkQ3pXMk1EVysvSFFZQkhyZVpWU2tvWnZ3clo0bytvRGs0WGlu?= =?utf-8?B?MHh6NmFqanZsdXhNZlo1K2hRK3B6bzhpMTJVdHc2R1FPVkhKWG9aNVJGNkRa?= =?utf-8?B?RTNDblJzUDlQVldWVlVEMEF5MHRIYlp0Ykp2ZmlTamMvMEErRjdVSTYrelYz?= =?utf-8?B?Y3h2dGphNjNXbitSWjlLQi9qWW1paVRRNktPTGRFMFNDeXBlOUgvNjcxdEJh?= =?utf-8?B?Qnh2NWFUSWtzREI5WFR0NytPK2lCMnpQazNKMExPUjBRTS94VFBhcXZoZG1I?= =?utf-8?B?ZGdGWWxwRWNmQ1dTVDJxMU5FRjZQdngwUzlLTys3bGRKa1pqYTNTSU1iYmZ1?= =?utf-8?B?L3BMTDliUUUxd1lyUGtnNTYzeW5vcDg1UnMzbUo4clpBdUkzcERrbEZsNWhk?= =?utf-8?B?U2FnVEM3bnVZNmVOL2NiRlZmUmlxN2VQekxGZVc0T3FSYzFaVkxMcExxd0xt?= =?utf-8?B?bkJCUzhVMXhWOE54OE0xMTEwa08wSUZscCtiU0xSNHlWUEpIMEc4RTRSM3BS?= =?utf-8?B?UVgyanZYbHNuWWprbVpDUCtsbWdCTWxLcTVHS0E3WENpTHpIMmxtS3FJbEhO?= =?utf-8?B?eWEvR29tWjh6ajZVK3NZY3pYUVozSFlGZjRDeDRiYnBxcDhpMUxqbzRadDBB?= =?utf-8?Q?r4m6pgRp89pLVdqetPTzhic7c?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c56317b-a2a2-4c50-872a-08dcfcadb4f8 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2024 08:50:17.7609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kOjmCqOUfeX8KB5GCbYRc/OZmBxoM44rLMkcfK7+BMjmTOXJ4Gd95guTPZNduziG X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9450 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/4/2024 2:05 AM, 王颢 wrote: > Dear Ferruh, > > Thank you for your comments. I will make the changes you suggested. Our DPDK PMD is developed based on our company’s Linux kernel drivers r8125 and r8126, which are more comprehensive and detailed. To facilitate synchronized maintenance, I have retained the CamelCase. > OK to keep the CamelCase syntax since code is shared. > Best Regards, > Howard Wang > > -----邮件原件----- > 发件人: Ferruh Yigit > 发送时间: 2024年11月3日 10:24 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_dpdk@realtek.com > 主题: Re: [PATCH v5 00/18] modify code as suggested by the maintainer > > > External mail. > > > > On 10/28/2024 7:30 AM, Howard Wang wrote: >> Fix some warning issues. >> >> Howard Wang (18): >> net/r8169: add PMD driver skeleton >> net/r8169: add logging structure >> net/r8169: add hardware registers access routines >> net/r8169: implement core logic for Tx/Rx >> net/r8169: add support for hw config >> net/r8169: add phy registers access routines >> net/r8169: add support for hardware operations >> net/r8169: add support for phy configuration >> net/r8169: add support for hw initialization >> net/r8169: add link status and interrupt management >> net/r8169: implement Rx path >> net/r8169: implement Tx path >> net/r8169: implement device statistics >> net/r8169: implement promisc and allmulti modes >> net/r8169: implement MTU configuration >> net/r8169: add support for getting fw version >> net/r8169: add driver_start and driver_stop >> doc/guides/nics: add documents for r8169 pmd >> > > Hi Howard, > > Thanks for restructuring the patch series, it looks better now, I put some comments. > > Btw, there are many "Avoid CamelCase" checkpatch warning, if this code is not shared (but developed for DPDK), can you please address the warnings?