From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0597A00C3; Wed, 19 Jan 2022 17:58:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7CF541178; Wed, 19 Jan 2022 17:58:36 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1EBE741147 for ; Wed, 19 Jan 2022 17:58:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642611515; x=1674147515; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ANY5fVasi3gsY7xURytH9+KmYsif6/j2y2Bx78dOMak=; b=XuuXe+eSrpdcfzry9La8ZkZfIrmfF2IvBFtFFRrP61loMweJPVemPu3K lMbn/qQ7SmEc//Aje67xwvC1H3d+bSPh0c8dJOgwvEyZX/iudB67UiSBS eoXkz6pg8wRuSHmMGP9BoNxRa4QIMRElmBEum5mdDZJngyUd+sJlp6KZM Jb3Eh1ILlRMM5AYQyCKrIUJIcLWjMea1tvD2DQJxvrEGRImiLbxkqxOAk 2hhe98GZ2m3yOQ/9dBPmlo/xmKi+ChsQ4UQcoNx3t8rnwgnAzR6wpzCz3 R+mznT+9Ob809zQRqkDr3PqnI4gVZ8Bm2TrntE8f4dpC9bxLthA2HRzLT w==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="242674943" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="242674943" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:58:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="477440195" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 19 Jan 2022 08:58:32 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 08:58:32 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 08:58:31 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 19 Jan 2022 08:58:31 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 19 Jan 2022 08:58:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NOyeeDBR1FLrblS/6Wvp4KHlmD/Qc/cmYqsrt8m8pN2Pq0YQJo5bfsRhM5XbeOconj1pLt2TX2OLMmvFq9KhbqwD/rnTeREmQEiVbY/gmzFl/OZX/DxdNWIjie+Sud7hPE209IGiTC43WmpyOfwrzcFyn4HgjCrTpwvF6LZgdtGjgLUh0sFNryg6zJ3V4rcH12Yt9NVx8dEUtvMFmhu/xfHM+YZy1XjBxkr8D3k+Mm/lpu8+nyX+9yzt30aqjyw32zLncOwUcyr73HtJvQLfvkoWUhlm0c/4EG+KA7pam+bCbiG6BzVT5EAozVH5uudQsrC0XRoQMhrpAjNMm4QFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C64Ma5X+n6cBaF2dpfnHhjsXVZA9kAuerzCIw9Iecsw=; b=ggFm5Hmfr27wPiVS4+9nHYrvZe0yixca6PW3yq3uMf2JQLaRxQmp67+zvArt80LRklYIYKoNpQBHq0BUTdjX8j/MNQLbMxVUzwvH9lt7e8bWfODW5gg63rhg/szPnRu2Ya40XggQkDySrGFeSP7WU8H9+VziPnbpSScoWx1Cjyk79QV92+dYUgRVp2OVjrLE70ZQdYaZyOyfPzlIc0wLMl8IvUv092BvUOHUJ1wHUMXLAN3lA1TEk/mAswfQfKpf57sikbZ/lRjw1ApgWRJ3fyzehWet44xQaoCzM9sZ2+d7ywZGhBLaOXSSbpCf6+ebZDFF0IKKJ3cjCKB9VskN8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5951.namprd11.prod.outlook.com (2603:10b6:510:145::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 16:58:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.008; Wed, 19 Jan 2022 16:58:18 +0000 Message-ID: Date: Wed, 19 Jan 2022 16:58:12 +0000 Content-Language: en-US To: Yanling Song , CC: , , , , References: From: Ferruh Yigit Subject: Re: [PATCH v6 01/26] drivers/net: introduce a new PMD driver X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0486.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9af9e7d-9d76-4a64-fb8f-08d9db6ce436 X-MS-TrafficTypeDiagnostic: PH0PR11MB5951:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DAASH1fOG1fHVSSFWBMVbHPWj8P9cc76c/q6xfQPEg3RgtWvRlzoYwxQfxM2EjQVx84Tebtb2mif1JOJN0tXDUZ4BBql9a/BNRlFRPxQ+PM7/lklLsfKaOpRnbJqeTfbl3t54dn6ttt6sgjB1s9vJkflA8bonVAVcwy2o0Lw6y+Ykf1wW6g8PkkAvzSchojdfbvsH3aTCMQ0US3QK5ku256efGSmzgLi0Yy8No9QQwEW0yDd9njhqoRmHPqiMsGbgeUPImeGoEgh16ioRJIBtfE/rUQ3fvuv5kHWd1Pqty7MKUH5tnlOa+h9qp2ORvi2RdSCJGhtGVSQLSrXGjmSSipxla8JsOQdaiVgGBrM2+UrVlDGYvcha/xk9iCopLhaJqy9nW7R2t+THbVAb2BdvRzIiluJENt1YoNZrWizjuyYVlgBoC89mNpQbKj3vZrZ8BDx57kJLJbpWCPfmWo7p5Dop7XbLMLuN20AuX3PC8/JLX4faXp4xkXGzy22+gCAWAL7EPgzmknzqlyVN1kShsa0haeFEhGPwqfct/MupM3i4m0gKbg8zmnxJXDPoolQrIp7znTPCX6ZKkDdpYQ1WX0IJ43FEYdLVC0mlTHecodHbjJOc1aWmIN+T+469c3syQgrBxdTD8mq143miGLmkmnkH/wdYJW5CNH3e9pheu+MmSeHXGqLIOptiptzya5LABBaIsG36OcCOB6u/5Q/Tg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(31686004)(66946007)(316002)(2906002)(44832011)(2616005)(66476007)(4326008)(5660300002)(6506007)(6666004)(186003)(86362001)(36756003)(8936002)(6486002)(508600001)(83380400001)(31696002)(26005)(53546011)(8676002)(66556008)(82960400001)(6512007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGNKVVB4U3VCUURnYnBkUUxmbFA2cnE3NFhhU2t0dEpCYWRwb3lKdTE4Qk5M?= =?utf-8?B?Q0xYbU52MUgvdFlEZ3JzcWpwNndQR3pHYlJqY08wZC9rVUtKN0ZobTdmRWJ6?= =?utf-8?B?ZmJSQ1NIQnBIR2swOGQ3QWE5a2xsTm9YZDZOb2dnNmhHODdON0ZaVlcxa0Fz?= =?utf-8?B?K3VCeDNYQWV4a2VLaU9hNjVaL3FBaTNzcXVrTWdFVDlzVlNmY09KZW9qSTdY?= =?utf-8?B?UDRTMGc3QzhKbDlMeHRKeGlDTk42OGVuUTQrcHZMZDZhaVBpWGNUMWpueEF5?= =?utf-8?B?MWNheXNST1E3dEd5OG82SzF1aDBpRTVHb3Q4cGFKbjdqV0RXUDdCVGsvVHQx?= =?utf-8?B?WEo2bVZsc3NadEozVGt3RUdWTlFnRXNEeWsyMGJrN0FFY1Bzem1vWXdGd2ND?= =?utf-8?B?d0U1TGsrbVhDM3R1ZDlrVEJDMkI4L1MwZUEyWmRmR3RqU3BIUVNaYWVJVndY?= =?utf-8?B?S01CVFNFYk1IRFlEaGFNQ1JvMkRkSE1mcVBDQ2Vkd0t3bXgrOE9iVE5odlNv?= =?utf-8?B?NEJqZ2FNQkZhV2J6WVhva0UxL3pqNXhGRyt5bUZzYnhaVVNNRGh0UXp0Zzk2?= =?utf-8?B?U0VPWTIxd0FKUnExRG1zVVErcWhsUTRZdE5JTXRxUkFRVW9saUMzUEp1VTI4?= =?utf-8?B?dEhMSytLcTFiMlZZeEZ2S2tUVlExTXlzNGNlV1NYYnVrMTlYQSt5RkZCYmFS?= =?utf-8?B?YjRMOXBWT2IyejVGMy9WNDFyTlFYV1hLY0ozV0x6MU1uWjYxUGtmeXN1UVpE?= =?utf-8?B?eDRuc2RKN2tJQjBZek5nOXUyNmpDUnNJTWRBRCtGNTcyR2s1ZTAvZitseEs2?= =?utf-8?B?dWJxazFacVpPOU5EbFV2Mi9jck5yWWxhcDBjMU5DRFdLdVJnS1ZhU3pRa1Nn?= =?utf-8?B?Ri9KblNKeE9uc2RQcTdCSFhIcFp1YkxpanNBWTBnc2tDdjFVV2t1U1FtR0F6?= =?utf-8?B?ZFhHald5eVNyREhURm9CV01wQ1FqOVhYbWY5YnRtcjM4SzBLTC9tV2JEOFo3?= =?utf-8?B?dGNIVm5vWUZSTTFJcnNKeFlEWHdRd3owTXRLenM2THlZMkU2dkRsSlgxVHVZ?= =?utf-8?B?MDlrZ2VKYVcxcmdiQ3o4eFhWcXVBT2FrTmJMZWl4bVVJK0VEZjVORDgwMExQ?= =?utf-8?B?QStrdyswRXJNMXlwdi9sVExhWGFpUjNvczhieU0xazA1a05NSTVIUnJtMnN6?= =?utf-8?B?bEFwSElxVUE3dTd6cDYzNTdqbytsMGhiZGFCWmNRNS9aKzFWd0hYRTJBRkho?= =?utf-8?B?algwSzVRWFlHUDk0RGU4UHYrYmVtYWtnZVU2bWFNRjR1ZmFuYnpJQUJpMUx2?= =?utf-8?B?eTFxcnJxZzE4alBWQ0p5dXU3S005cmdINDJRRFk2WDhudnlvNmxOZHhZUS9B?= =?utf-8?B?QzA0RXdXaEs0NmZCUGkxZm40eXh4cFMyWlpWTlREQTBXWU1aZ2lhT0pEb1Br?= =?utf-8?B?c0JyNGp3clpNWnEvbTM3MlJFbkhkKzIwZEJoU0lHOEw2T1k2dUlqMjVvb0dG?= =?utf-8?B?Um1ramk5Mmhxa2VxTFBFbDh0ZDcxVVRrQkVEYjNjZ0tlVG9VcjBWY1VURFh6?= =?utf-8?B?WXRpUXFvL1M2ZmNsTmdOdXdieVBoSU91SU03WTd0cEIrbFpRb0JST3dtQmVQ?= =?utf-8?B?L1dCOGFoUkFmbThubW5zZUhRaHZhTkRML214VE41cXFFZTF1UlliS1ljblAw?= =?utf-8?B?MzJvanF6by9POGFCdnowcC9OQWxTbGV5eUJub21NTmQ2dnNIOFJ3TFJSNlpu?= =?utf-8?B?VjJWMHZKRVZaZVNjZzlDMzM1RzQzMFkwQW1pNUs4TGJQMHJqS2ZpbG5Oc3Yr?= =?utf-8?B?RFlLaTRKVHZZYzN3U1k1MWcxcFN1MEVwUitiYnNFV1V1UHc0T2V1dEZlUC9m?= =?utf-8?B?ZlZFeHN2aW1OajFPMGNjVWVXakR4K0RFYVQvdENQVk9iaTkycUs4NzNQR3A1?= =?utf-8?B?UXpmdkQ1NzRBcUJCdWdJalVkNEhFTXJCeXJmb3BHSmphMFBYcURWWm5uL1dN?= =?utf-8?B?TkdaUmxMMGZSNlRYcDZvbXFSYm9aVG5tQnB3Uk9hNFZEV2gxTDVXcFdOUUFj?= =?utf-8?B?bGxqMkIxdWFkUmN4elZSd0pxTSsyeTk5emhWNWlDVTQ4UjJiQkMvWEt2NHNW?= =?utf-8?B?S3UvcjdSOEd5Wm8wUlRVbmh4OWZVc2pta25iKzk2Y0czOWFoTndWYmg0Z0VG?= =?utf-8?Q?cj+elPG1SxpVA7VXIFQov8E=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a9af9e7d-9d76-4a64-fb8f-08d9db6ce436 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 16:58:18.3582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B4K2dO+Dzqlng04qTjdCotrubgy8z8ZFI+Ax18LaVrVrsCIm8S7u4ohIyXsfDBHfPH4Ww5EV7aYP/6BZ1QjoQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5951 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/30/2021 6:08 AM, Yanling Song wrote: > Introduce a new PMD driver which names spnic. PMD stands for "Poll mode driver", so "PMD driver" usage is wrong, can you please update it in the patch title too? Also domain for patch title can be "net/spnic: ". > Now, this driver only implements module entry > without doing anything else. > > Signed-off-by: Yanling Song > --- > drivers/net/meson.build | 1 + > drivers/net/spnic/base/meson.build | 26 ++++ > drivers/net/spnic/base/spnic_compat.h | 184 ++++++++++++++++++++++++++ > drivers/net/spnic/meson.build | 17 +++ > drivers/net/spnic/spnic_ethdev.c | 107 +++++++++++++++ > drivers/net/spnic/spnic_ethdev.h | 28 ++++ > drivers/net/spnic/version.map | 3 + > 7 files changed, 366 insertions(+) > create mode 100644 drivers/net/spnic/base/meson.build > create mode 100644 drivers/net/spnic/base/spnic_compat.h > create mode 100644 drivers/net/spnic/meson.build > create mode 100644 drivers/net/spnic/spnic_ethdev.c > create mode 100644 drivers/net/spnic/spnic_ethdev.h > create mode 100644 drivers/net/spnic/version.map Can you please add/update following files in this first patch: - MAINTAINERS (sorted by vendor name) - doc/guides/nics/spnic.rst - doc/guides/nics/features/spnic.ini - doc/guides/nics/index.rst - doc/guides/rel_notes/release_22_03.rst Most of them are already in the patch 25/26, so please squash it in this patch, and I put some comment on the documentation. > > diff --git a/drivers/net/meson.build b/drivers/net/meson.build > index 2355d1cde8..a5c715f59c 100644 > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -53,6 +53,7 @@ drivers = [ > 'ring', > 'sfc', > 'softnic', > + 'spnic', The indentation in the meson files needs to be fixed, please run 'check-meson.py' Comment is valid for all meson file updates in other patches. $ ./devtools/check-meson.py Error parsing drivers/net/meson.build:54, got some tabulation Error: Incorrect indent at drivers/net/meson.build:55 Error parsing drivers/net/spnic/meson.build:13, got some tabulation Error: Incorrect indent at drivers/net/spnic/meson.build:14 Error parsing drivers/net/spnic/meson.build:14, got some tabulation Error parsing drivers/net/spnic/base/meson.build:23, got some tabulation Error parsing drivers/net/spnic/base/meson.build:24, got some tabulation > 'tap', > 'thunderx', > 'txgbe', > diff --git a/drivers/net/spnic/base/meson.build b/drivers/net/spnic/base/meson.build > new file mode 100644 > index 0000000000..e83a473881 > --- /dev/null > +++ b/drivers/net/spnic/base/meson.build > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2021 Ramaxel Memory Technology, Ltd > + > +sources = [ > +] > + > +extra_flags = [] > +# The driver runs only on arch64 machine, remove 32bit warnings > +if not dpdk_conf.get('RTE_ARCH_64') > + extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > +endif Why disabling compiler warning even without having any source file. Please start with empty meson file, and develop it as needed. > + > +foreach flag: extra_flags > + if cc.has_argument(flag) > + cflags += flag > + endif > +endforeach > + > +deps += ['hash'] > +cflags += ['-DHW_CONVERT_ENDIAN'] > +c_args = cflags ditto > + > +base_lib = static_library('spnic_base', sources, > + dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], > + c_args: c_args) > +base_objs = base_lib.extract_all_objects() > diff --git a/drivers/net/spnic/base/spnic_compat.h b/drivers/net/spnic/base/spnic_compat.h > new file mode 100644 > index 0000000000..97f817cba9 > --- /dev/null > +++ b/drivers/net/spnic/base/spnic_compat.h > @@ -0,0 +1,184 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2021 Ramaxel Memory Technology, Ltd > + */ > + > +#ifndef _SPNIC_COMPAT_H_ > +#define _SPNIC_COMPAT_H_ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + Do you need to include all these headers at this stage? Can you please add them as needed? > +typedef uint8_t u8; > +typedef int8_t s8; > +typedef uint16_t u16; > +typedef uint32_t u32; > +typedef int32_t s32; > +typedef uint64_t u64; > + > +#ifndef BIT > +#define BIT(n) (1 << (n)) > +#endif > + There is already RTE_BIT64 / RTE_BIT32 in DPDK, those can be used. > +#define upper_32_bits(n) ((u32)(((n) >> 16) >> 16)) > +#define lower_32_bits(n) ((u32)(n)) > + > +#define SPNIC_MEM_ALLOC_ALIGN_MIN 1 > + > +#define SPNIC_DRIVER_NAME "spnic" > + > +extern int spnic_logtype; > + > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, spnic_logtype, \ > + SPNIC_DRIVER_NAME ": " fmt "\n", ##args) > + > +/* Bit order interface */ > +#define cpu_to_be16(o) rte_cpu_to_be_16(o) > +#define cpu_to_be32(o) rte_cpu_to_be_32(o) > +#define cpu_to_be64(o) rte_cpu_to_be_64(o) > +#define cpu_to_le32(o) rte_cpu_to_le_32(o) > +#define be16_to_cpu(o) rte_be_to_cpu_16(o) > +#define be32_to_cpu(o) rte_be_to_cpu_32(o) > +#define be64_to_cpu(o) rte_be_to_cpu_64(o) > +#define le32_to_cpu(o) rte_le_to_cpu_32(o) > + > +#define ARRAY_LEN(arr) ((sizeof(arr) / sizeof((arr)[0]))) > + There is DPDK 'RTE_DIM' for it. > +#define SPNIC_MUTEX_TIMEOUT 10 > +#define SPNIC_S_TO_MS_UNIT 1000 > +#define SPNIC_S_TO_NS_UNIT 1000000 > + > +static inline unsigned long clock_gettime_ms(void) > +{ > + struct timespec tv; > + > + (void)clock_gettime(CLOCK_MONOTONIC_COARSE, &tv); > + > + return (unsigned long)tv.tv_sec * SPNIC_S_TO_MS_UNIT + > + (unsigned long)tv.tv_nsec / SPNIC_S_TO_NS_UNIT; > +} > + > +#define jiffies clock_gettime_ms() Is 'jiffies' used at all? <...> > + > +RTE_INIT(spnic_init_log) > +{ > + spnic_logtype = rte_log_register("pmd.net.spnic"); > + if (spnic_logtype >= 0) > + rte_log_set_level(spnic_logtype, RTE_LOG_INFO); > +} Can you please use 'RTE_LOG_REGISTER_DEFAULT' macro instead? <...>