From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id BE3B64F9B;
 Tue, 30 Oct 2018 10:10:59 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 1DB7AC050DFB;
 Tue, 30 Oct 2018 09:10:59 +0000 (UTC)
Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id ECC3F60C76;
 Tue, 30 Oct 2018 09:10:57 +0000 (UTC)
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
References: <20181025094659.25492-1-tiwei.bie@intel.com>
 <20181025094659.25492-3-tiwei.bie@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <d042502f-08c9-9807-8861-aba7c8e9a1b4@redhat.com>
Date: Tue, 30 Oct 2018 10:10:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181025094659.25492-3-tiwei.bie@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Tue, 30 Oct 2018 09:10:59 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 09:11:00 -0000



On 10/25/18 11:46 AM, Tiwei Bie wrote:
> Add the missing params to the param string.
> 
> Fixes: 39cac2adcad0 ("net/vhost: add client option")
> Fixes: 4ce97c6f6b4f ("net/vhost: add an option to enable dequeue zero copy")
> Fixes: 447e0d379756 ("net/vhost: add parameter to enable IOMMU feature")
> Fixes: 6d6e95cec455 ("net/vhost: add parameter to enable postcopy")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 55e51c89a..07a9c2598 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1470,7 +1470,11 @@ RTE_PMD_REGISTER_VDEV(net_vhost, pmd_vhost_drv);
>   RTE_PMD_REGISTER_ALIAS(net_vhost, eth_vhost);
>   RTE_PMD_REGISTER_PARAM_STRING(net_vhost,
>   	"iface=<ifc> "
> -	"queues=<int>");
> +	"queues=<int> "
> +	"client=<0|1> "
> +	"dequeue-zero-copy=<0|1> "
> +	"iommu-support=<0|1> "
> +	"postcopy-support=<0|1>");
>   
>   RTE_INIT(vhost_init_log)
>   {
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime