From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B57A0548; Tue, 27 Apr 2021 12:47:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C30140142; Tue, 27 Apr 2021 12:47:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D5DDD4003D for ; Tue, 27 Apr 2021 12:47:25 +0200 (CEST) IronPort-SDR: 8Fpwcy3TUSL1sqSsDh719PQgujAerKKJHPisSOVxBaxtS2D8ctG/eDcpYGBvoMDUbASaryLZfU qMHjFdRWLBgg== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="257789600" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="257789600" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 03:47:23 -0700 IronPort-SDR: A/Bhy+gvqrdvnEoaZjZahx5PolAa9+wMaJbWz5sB9wjfn0UXn8Iu3uGCeFGSYld4rMKt8Qe9L3 bCplZwCSldFg== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457592445" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231]) ([10.213.221.231]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 03:47:22 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619075569-33619-1-git-send-email-humin29@huawei.com> <1619515014-19181-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 27 Apr 2021 11:47:20 +0100 MIME-Version: 1.0 In-Reply-To: <1619515014-19181-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix socket id check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 10:16 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The socket ID entered by user is cast to an unsigned integer. However, > the value may be an illegal negative value, which may cause some > problems. In this case, an error should be returned. > > In addition, the socket ID may be an invalid positive number, which is > also processed in this patch. > > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) > --- > v2: > * fixed socket id type. > --- > drivers/net/bonding/rte_eth_bond_args.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c > index 8c5f90d..977f3fe 100644 > --- a/drivers/net/bonding/rte_eth_bond_args.c > +++ b/drivers/net/bonding/rte_eth_bond_args.c > @@ -207,13 +207,13 @@ bond_ethdev_parse_socket_id_kvarg(const char *key __rte_unused, > return -1; > > errno = 0; > - socket_id = (uint8_t)strtol(value, &endptr, 10); > + socket_id = (int)strtol(value, &endptr, 10); Already provided some comment to v1, why it is better to do checks first and cast later. > if (*endptr != 0 || errno != 0) > return -1; > > /* validate socket id value */ > - if (socket_id >= 0) { > - *(uint8_t *)extra_args = (uint8_t)socket_id; > + if (socket_id >= 0 && socket_id < RTE_MAX_NUMA_NODES) { > + *(int *)extra_args = socket_id; The provided 'extra_args' is 'uint8_t', we can't just cast it to "int *" and assign to it.