From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61])
by dpdk.org (Postfix) with ESMTP id 4EAFE2030
for <dev@dpdk.org>; Wed, 13 Dec 2017 15:13:12 +0100 (CET)
Received: from CY4PR03CA0108.namprd03.prod.outlook.com (2603:10b6:910:4d::49)
by SN2PR03MB2365.namprd03.prod.outlook.com (2603:10b6:804:e::16) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13
Dec 2017 14:13:10 +0000
Received: from BN1AFFO11FD030.protection.gbl (2a01:111:f400:7c10::181) by
CY4PR03CA0108.outlook.office365.com (2603:10b6:910:4d::49) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.302.9 via Frontend Transport; Wed, 13 Dec 2017 14:13:09 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed)
header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1AFFO11FD030.mail.protection.outlook.com (10.58.52.168) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5
via Frontend Transport; Wed, 13 Dec 2017 14:13:02 +0000
Received: from [10.232.14.39] ([10.232.14.39])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBDED6vU004953;
Wed, 13 Dec 2017 07:13:07 -0700
To: Gaetan Rivet <gaetan.rivet@6wind.com>
References: <cover.1503676587.git.gaetan.rivet@6wind.com>
<cover.1507796100.git.gaetan.rivet@6wind.com>
<c16edb4815d830679404fa1012b2989e3ba24f9c.1507796100.git.gaetan.rivet@6wind.com>
CC: <dev@dpdk.org>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <d051e00f-42db-a4ac-00ea-adeb07934d76@nxp.com>
Date: Wed, 13 Dec 2017 19:56:42 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <c16edb4815d830679404fa1012b2989e3ba24f9c.1507796100.git.gaetan.rivet@6wind.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131576479825657038;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(336005)(7966004)(346002)(376002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(24454002)(81166006)(81156014)(229853002)(8676002)(50466002)(316002)(65826007)(4326008)(85426001)(58126008)(64126003)(97736004)(104016004)(498600001)(68736007)(5660300001)(86362001)(105606002)(77096006)(106466001)(23676004)(31696002)(2486003)(65806001)(2906002)(31686004)(36756003)(6246003)(356003)(47776003)(305945005)(67846002)(76176011)(230700001)(6916009)(8936002)(2950100002)(53936002)(83506002)(6666003)(65956001)(41533002);
DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2365; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD030;
1:jXFd6eyyVMqbMROWW1Bv+XrgltLp5wBz1sjFGxoF8SgiEueoQM/uyIhzoEJcaJFmfQrfZcNCEtSUewGBAeGqqIL7AOSeSad549K+0rwYCPd5QsH9lQQFDLgdyCw5OPnU
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2e5bab0e-f350-420f-fcce-08d542339f44
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307);
SRVR:SN2PR03MB2365;
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365;
3:3dLYMCf/BQDn5m1Zg8DAWwRNYeIFp5WgI/iQbdxvjTkS8cWy2Zrpkg7TeCwImJnRaAIMAB/4Tcn7yqzVStFZynxJKKNKSbVtyNIXwNjv0LDNwwsLKCHpXeMBXBTcM2aS50vOT+rj34Z/fnNVU88DSwkqNwUthf94ncBiYMy48vW2qaDFkqP3ZhCVxCSsQt236ZJyXVK9QCpxS8HsAtpjz270RD6Wh0t14Bd9SHV0b8mXponD4iN4hPeVeGiu/fDc+aGhdyFxhQJi0ihCZlkOupBRhw1RaVqERo3mF0orPL9fXZJSbDpQakm9rHiolISY4FH38tXyvRAT7rIvIvScDtZX48s6gg4FmQsbKIEkqGA=;
25:fpC77LsnatgQlfFGzoymcPIW6gBc2m8OJrT/FKxEsrGH1YPwMkv4oVVo78pNCR2kZuXbiqmwMzHdiu5bSieKJQ74b4ghgcrQcmCUShkWwTJp7BZjhy25eUKb1HtQO1TenTdoDuQbQdPIlnAKrJYFeaH0EVhPIF8kdPNtBAtCSTaVr2o8OYe3KJ4dar71JLLf2BZfD/fpfsyXAh7BIV0GTNESy+YabGGPsytJVtZ0oLXyBi+sQ6VM0FMJYf/cPESnOiOsgRSq9ZHbEGjISFNctzc/26ZG9iKl3Xa/qlrFZBeW0fY6mTy8l9pOCZAqluQVzeMnokquwZKp7wRBfga0ug==
X-MS-TrafficTypeDiagnostic: SN2PR03MB2365:
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365;
31:1Wpt8bHtG6EoZrCmB5dMCIvH/jzd1phFlH9uyS0JJU/FjNawRjj5Nbf7QNSOLfk18Uft5dAtIHdeIy3KMV1jn5bAIvNvNPuHaQPtbuwvctlbC2QJuxD2dR0hQMDA3/tK7cYGcLgWuZ0aYNuzdbn1oL0O9bwyZuO9GrnI54qAL5x7Y3iiO2Y3bKKub99rgDWNaTHX6kgpEUl4L8mStT49GUF7yy8R59MEozzM8QNUnzc=;
4:UfSvwGG1/PZ6M6DCgMgiAcjhsdisGuO1XnkEPePf2HdnnL+dnyqQ33U9AOJocV04XZCvRIHT/71KSVXVGkFVKTY/lQLylcHcAoPNflcJJnk/VtO46ktZdTfU8++7mYLlkpFxnqb+jztLugf3Vugqb+3R9p69eouCDZUkCi0UEm1xjfQIyr0szc+sSL1i0E6FZ/JRisk1PtSPCMg6T+IpI4JBYqep3ASxdawVQrn6BWxLQlySZZBSOg9G4RlewXQMi+a8qcN1kABXhAzMM5ATUg==
X-Microsoft-Antispam-PRVS: <SN2PR03MB2365BA9719DB5B9318B5DCA090350@SN2PR03MB2365.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6095135)(2401047)(5005006)(8121501046)(3231023)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(20161123556025)(20161123561025)(20161123565025)(20161123559100)(201708071742011);
SRVR:SN2PR03MB2365; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006);
SRVR:SN2PR03MB2365;
X-Forefront-PRVS: 052017CAF1
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIyMzY1OzIzOk90bVBUK1dZTWV5aTZ3bGRwT1AzM2NMaFNv?=
=?utf-8?B?VlQ0QXNBYzYyNjJMZFJXSWhCMjlnK0NudTJ2YWY2N3RsaG1Fd2J0UVFBYUpa?=
=?utf-8?B?S1ZVTEVMbHlGRkkwOVd4UjBXWkVNVmVFeG4rTjBNM1lDemhNSVhkM0FkT1F4?=
=?utf-8?B?TDkxd0VvVDZTRmsvRTJVWGtrVXVROE5hRTNjZS85YVhBcWV0c29xTGZOTXlv?=
=?utf-8?B?NmdvdE84QUZGMDBCRGQ1b0dOWXFKcllpYThTZ2VDOGVoUVc5OFl3ekxRbWpl?=
=?utf-8?B?UEtpMzNsSXY0elFmSDJRa3M4bzk0cE9YWERpenZFdGtOWnp5V25XN1V5QmpM?=
=?utf-8?B?bkpWY1BYSVJtN1VPOFN3RzBLRW1IOFZWdnVMQVdDTzkwUkFraitHK0pqNGNw?=
=?utf-8?B?bGt1UlArOVZHVGRSdzh4QlFmK2hvbmpRenhjTlpFVXQ5MEljSTdwKzA5L3hj?=
=?utf-8?B?bUkwT2wzM3cyUEc5bG45Sk9tNmRWTEhRN2ZkdlBRRkRQNkF6SUdqR0FyYzdF?=
=?utf-8?B?V2pla3g0c1Q0dkpCQlF5Z3hoWHkxMXRaaW5GcWdrYWNqZXdUQXlJeXdvSXJh?=
=?utf-8?B?WkhwbkN1K0lsNlY4dFFyTHpzeFF4VFp4R0VrNnY2d3lIV2tXb0xaV0VFM0dv?=
=?utf-8?B?UWJDdThEaDRBRmd6SkI2YlJrYW11MTByTTBaZ3lya05ibW9KVDF0T0ZaNDRB?=
=?utf-8?B?TkdnYi9FYUVLYVZJK3FicFczQmtHQlFJRk5Rd2dlWFVlSWt5SXFDQXpCaHl1?=
=?utf-8?B?T2V1bDFoU3ZLcmZmMHpVUTVmSTI1K1VXUER1Slh4WUNpTlJuREZ4SE8wYk5x?=
=?utf-8?B?dXdtSW1xTXYxODZ2dFZ5R1RhZnBLUnhzbWkxSTMwS3pybEJVeVFXSlBLM3lU?=
=?utf-8?B?R0M4RzBiNmZQVzNwVWk1TUlsdXRGRWQ5cXIvalg4UVo4RFhOTEFDRm1rTTN0?=
=?utf-8?B?aEFyZWtXYTZ1RWJFWUN2RlhYT1ZXVTR6ajZpYWdjUXM4cTVLSjVEbllmTXp6?=
=?utf-8?B?WjE0WFpmV1FYWE92d3pmajNkRzdNTG5CYVJEWXFrbFFmR3k1VS8zUjJGMlNG?=
=?utf-8?B?NE5MN2R3Mzlmd3B4blFmS0l1NmlkN2REc2JQdml5VEhJem83ZHc4dnZITDBi?=
=?utf-8?B?QlpqdXNuc0M2UDdheEs0dERLbzErR1huZ2t1eVdycWpjcUdFdEg2eG1NbVNn?=
=?utf-8?B?dEJLWVFUdjI3VDA0b21lNDM3Nnpoa0NIR3ZhZFJHQjlQR0tTaEwzTW9kQjJG?=
=?utf-8?B?VzFETU9vWmVsK0toRzFlV3MvUkZoOWwrblRZcU5rOHJHR0t4WTMwT2VIbWxO?=
=?utf-8?B?VnE2dVd0SjNrYkg4dE5MWE1jUVNYQ09VU2NYWXZ0V3I0ZTMrQUoycGVidmVa?=
=?utf-8?B?RDRhTWlLVUNQaDc5ZzI0ZkRsZ0R5dUdHU0FyZ1BjeUtSVDJURlRCREZXTE9v?=
=?utf-8?B?SGdGSmJZcWYzV2V0UXBXTVFZR3VUYk55WGJlNkIwOUNnd0tzMDFtaVF6SnJ6?=
=?utf-8?B?YkhCanRnQTZlYWEreXdMTzM1RnBPcytjTkY4L2hlVW9yQnRaaEk3bXI3Qndu?=
=?utf-8?B?ejZLK2paM3pJNnQ4R0N3V2tHcWQwTllCT0xLUjdLZEo5cXdVSlBuODNHT1cw?=
=?utf-8?B?R09MdnY5RXpwZXNWeEpxVU1ZL1VoNlI3VW1wL0Y2cnNXakozTXJOQStJdjdR?=
=?utf-8?B?aFNjT0JIUlJTN25kV29pS2s3S2tMNldmTHpYTFpocmZjSUtOcmhLd0VmU1FH?=
=?utf-8?B?cDRINTdUNi9YTDExZGJxdz09?=
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365;
6:7fhBFtM5xE1OHQ/C8mCGUrPXBuxfPB/MCsEEnyLWPV0qVjGL9Bp4zy+s3GpNAUxJwxKwQVDZRfPUrz4badrVdTlC/7PEqZOom7hDJB8sxMBe7ZnN6sMwsZAeqH/U6SI/EiBq/Nh8UkRNHoGzTnHVtxmrCsFKlIna4v+XrGmTl563f1hphTeyj6mxwZgT3MYW1/yig9YWnbbf/qhtpnCUB/YilscdDEYoEYUcNj7gKjxUfC/LoZW/Gf5fzCGzP2KRyLLbxQqQgOhdKlCy9KfKiPVNmZWVjK83ZumxichnN2cV/xeqJ3G9iVMZFKlY2hNG2PNhBGrr0OrxZYnSGs0UkAj8w9zOQMvWz4n2TRxnMiM=;
5:sAbspvg4D78Zx6+UtVah+kw1/+T123xrOmLUWhsGUrGQkJbQE3s6oVSH3Un7TNh9Tu/d0TkjgTnA8KXplHxSBU/DTlhcuSyINWVMV/IcO8uC6Uo18SKRcCxmUpoyfay7e9mDVr+RKO6qgIYg8v6JXFgJ2GX1giPaE4Tft93iAF0=;
24:DNGC3x0fi0v5mQ6Iu/C8zXML9ktKEojcL4pgmbuIHnavBGdGCkuiOAeK6E7g2UqJnrtMamSRnJcuKKR2so+6IhNyUKRuBbhMoZPW4mE+NU0=;
7:mYUMvobdTtqTnD4M2b902n1skPDC/i3M8J6cCVC4ykxQEWbHJHn43JuYEsO5Wba/7XkVmUWNJFjmb03cKJb/1YbOqksYYKyThwBq09Y1YZ2h+cPho6vubOwZZDUg60k70Oln/Ra0k15T4UuyenoTeMabpYuLv4ykl+GZSqnMxvMZLiwxm/ZdYpyJIR2IgzQZWsgXHg2cozBx1V0rNPr2hOO1ZhdbS1Lyy7O+KjxUo77lZ3gK8h223QHpOoanryjc
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 14:13:02.3941 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5bab0e-f350-420f-fcce-08d542339f44
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2365
Subject: Re: [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration
parameter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2017 14:13:12 -0000
On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote:
> Add a new generic device declaration parameter:
>
> --dev=<device_declaration>
>
[...]
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 603df27..b7591fd 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -95,6 +95,7 @@ eal_long_options[] = {
> {OPT_PROC_TYPE, 1, NULL, OPT_PROC_TYPE_NUM },
> {OPT_SOCKET_MEM, 1, NULL, OPT_SOCKET_MEM_NUM },
> {OPT_SYSLOG, 1, NULL, OPT_SYSLOG_NUM },
> + {OPT_DEV, 1, NULL, OPT_DEV_NUM },
> {OPT_VDEV, 1, NULL, OPT_VDEV_NUM },
> {OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM },
> {OPT_VMWARE_TSC_MAP, 0, NULL, OPT_VMWARE_TSC_MAP_NUM },
> @@ -1120,6 +1121,21 @@ eal_parse_common_option(int opt, const char *optarg,
> }
> break;
>
> + case OPT_DEV_NUM: {
> + struct rte_devargs da;
> + int ret;
> +
> + if (rte_eal_devargs_parse(&da, optarg) < 0)
> + return -1;
> + ret = rte_bus_probe_mode_set(da.bus->name,
> + RTE_BUS_PROBE_WHITELIST);
> + if (ret < 0 && ret != -ENOTSUP)
> + return -1;
> + if (eal_option_device_add(NULL, optarg) < 0)
> + return -1;
> + }
Might be a naive question: Any specific reason why we don't add the
devices directly into devargs_list here (eal_parse_args ->
eal_parse_common_option -> OPT_DEV ->) rather than wait for eal to call
eal_option_device_parse again?
Is it to allow eal_plugins_init() to finish?
> + break;
> +
> case OPT_VDEV_NUM:
> if (eal_option_device_add("vdev", optarg) < 0)
> return -1;
[...]