Re: [PATCH v3 0/4] support HW Rx/Tx descriptor dump

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 6/1/22 21:26, Andrew Rybchenko wrote:
> Again, please, add maintainers using --cc-cmd or --to-cmd to patches.
> Also, don't forget to keep in Cc participants of the discussion.
> 
> On 6/1/22 10:49, Min Hu (Connor) wrote:
>> This patch set support HW Rx/Tx descriptor dump by using procinfo tool.

One more thing. I'd remove HW from the description.
Format is undefined and driver can log any kind of information
related to particular descriptor.
Just highlight that the dupmp format is vendor-specific.

>>
>> Min Hu (Connor) (4):
>>    ethdev: introduce ethdev HW desc dump PI
>>    net/hns3: rename hns3 dump files
>>    net/hns3: support Rx/Tx bd dump
>>    app/procinfo: support descriptor dump
>>
>>   app/proc-info/main.c                          | 81 +++++++++++++++++++
>>   doc/guides/rel_notes/release_22_07.rst        |  7 ++
>>   .../hns3/{hns3_ethdev_dump.c => hns3_dump.c}  | 66 ++++++++++++++-
>>   drivers/net/hns3/hns3_dump.h                  | 17 ++++
>>   drivers/net/hns3/hns3_ethdev.c                |  3 +
>>   drivers/net/hns3/hns3_ethdev.h                |  1 -
>>   drivers/net/hns3/hns3_ethdev_vf.c             |  3 +
>>   drivers/net/hns3/meson.build                  |  2 +-
>>   lib/ethdev/ethdev_driver.h                    | 42 ++++++++++
>>   lib/ethdev/rte_ethdev.c                       | 44 ++++++++++
>>   lib/ethdev/rte_ethdev.h                       | 44 ++++++++++
>>   lib/ethdev/version.map                        |  2 +
>>   12 files changed, 309 insertions(+), 3 deletions(-)
>>   rename drivers/net/hns3/{hns3_ethdev_dump.c => hns3_dump.c} (93%)
>>   create mode 100644 drivers/net/hns3/hns3_dump.h
>> ---
>> v3:
>> * fix desc id handling.
>>
>> v2:
>> * add 'const' for ethdev.
>