From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0B87A0548; Thu, 2 Jun 2022 15:28:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9043F40691; Thu, 2 Jun 2022 15:28:02 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 2F5B04021E for ; Thu, 2 Jun 2022 15:28:01 +0200 (CEST) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 97D10C8; Thu, 2 Jun 2022 16:27:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 97D10C8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654176479; bh=lyflf7ERYEUaH+2KA8N1iWzM2YZQIZVUmfYHlTCYwmI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=OQ4btrFkbHukrBT6hCfoxW6lVZZtTRwy6g/70IjW51QagkqbFO9sNrDT0enK5Wp/S T0RuZQAdkFsBMAH3R5QQzKcBy7d8w8I4KOGn/oxGoDnZ/CrGRn4ExSp3iuDkvUx4Th OMj+vzlTS1KZ/2pv77fm3rURdSCSdscVyB0QFAJg= Message-ID: Date: Thu, 2 Jun 2022 16:27:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 0/4] support HW Rx/Tx descriptor dump Content-Language: en-US From: Andrew Rybchenko To: "Min Hu (Connor)" , dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit , Stephen Hemminger , Ray Kinsella References: <20220527023351.40577-1-humin29@huawei.com> <20220601074930.10313-1-humin29@huawei.com> <40b88110-1474-9175-46a1-3d305126465e@oktetlabs.ru> In-Reply-To: <40b88110-1474-9175-46a1-3d305126465e@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/22 21:26, Andrew Rybchenko wrote: > Again, please, add maintainers using --cc-cmd or --to-cmd to patches. > Also, don't forget to keep in Cc participants of the discussion. > > On 6/1/22 10:49, Min Hu (Connor) wrote: >> This patch set support HW Rx/Tx descriptor dump by using procinfo tool. One more thing. I'd remove HW from the description. Format is undefined and driver can log any kind of information related to particular descriptor. Just highlight that the dupmp format is vendor-specific. >> >> Min Hu (Connor) (4): >>    ethdev: introduce ethdev HW desc dump PI >>    net/hns3: rename hns3 dump files >>    net/hns3: support Rx/Tx bd dump >>    app/procinfo: support descriptor dump >> >>   app/proc-info/main.c                          | 81 +++++++++++++++++++ >>   doc/guides/rel_notes/release_22_07.rst        |  7 ++ >>   .../hns3/{hns3_ethdev_dump.c => hns3_dump.c}  | 66 ++++++++++++++- >>   drivers/net/hns3/hns3_dump.h                  | 17 ++++ >>   drivers/net/hns3/hns3_ethdev.c                |  3 + >>   drivers/net/hns3/hns3_ethdev.h                |  1 - >>   drivers/net/hns3/hns3_ethdev_vf.c             |  3 + >>   drivers/net/hns3/meson.build                  |  2 +- >>   lib/ethdev/ethdev_driver.h                    | 42 ++++++++++ >>   lib/ethdev/rte_ethdev.c                       | 44 ++++++++++ >>   lib/ethdev/rte_ethdev.h                       | 44 ++++++++++ >>   lib/ethdev/version.map                        |  2 + >>   12 files changed, 309 insertions(+), 3 deletions(-) >>   rename drivers/net/hns3/{hns3_ethdev_dump.c => hns3_dump.c} (93%) >>   create mode 100644 drivers/net/hns3/hns3_dump.h >> --- >> v3: >> * fix desc id handling. >> >> v2: >> * add 'const' for ethdev. >