* [dpdk-dev] [PATCH] net/thunderx: add compile-time checks
@ 2017-05-01 6:40 Jerin Jacob
2017-05-12 11:24 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Jerin Jacob @ 2017-05-01 6:40 UTC (permalink / raw)
To: dev; +Cc: thomas, olivier.matz, bruce.richardson, Jerin Jacob
The thunderx PMD is sensitive to the layout of the mbuf on
the RX path. Add in some compile-time checks to make sure the mbuf layout
assumptions are valid, and to provide hints to anyone changing the mbuf
where things may need to be updated.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
- As previously discussed*, add some compile time checks to the pmds to
help sanity-check their dependencies on the mbuf layout.
* http://dpdk.org/ml/archives/dev/2017-April/064988.html
- Targeted for v17.08
---
drivers/net/thunderx/nicvf_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index e4910c9b3..ddcfabaf7 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -1239,6 +1239,13 @@ nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
struct rte_mbuf mb_def;
RTE_BUILD_BUG_ON(sizeof(union mbuf_initializer) != 8);
+ RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) % 8 != 0);
+ RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, refcnt) -
+ offsetof(struct rte_mbuf, data_off) != 2);
+ RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, nb_segs) -
+ offsetof(struct rte_mbuf, data_off) != 4);
+ RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, port) -
+ offsetof(struct rte_mbuf, data_off) != 6);
mb_def.nb_segs = 1;
mb_def.data_off = RTE_PKTMBUF_HEADROOM;
mb_def.port = rxq->port_id;
--
2.12.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-12 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 6:40 [dpdk-dev] [PATCH] net/thunderx: add compile-time checks Jerin Jacob
2017-05-12 11:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).