From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B41F45B94; Mon, 21 Oct 2024 19:57:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE6D34028C; Mon, 21 Oct 2024 19:57:32 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 91C064021F for ; Mon, 21 Oct 2024 19:57:31 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id D772BEA36 for ; Mon, 21 Oct 2024 19:57:30 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id CB8AAEA92; Mon, 21 Oct 2024 19:57:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 94131EA90; Mon, 21 Oct 2024 19:57:28 +0200 (CEST) Message-ID: Date: Mon, 21 Oct 2024 19:57:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] bitset: fix build for GCC without experimental API To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20241015121046.2556695-1-david.marchand@redhat.com> <20241021160447.3538245-1-david.marchand@redhat.com> <20241021160447.3538245-2-david.marchand@redhat.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20241021160447.3538245-2-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-10-21 18:04, David Marchand wrote: > For a reason similar to the change on bitops header, hide bitset > implementation relying on experimental API. > > Fixes: 99a1197647d8 ("eal: add bitset type") > > Signed-off-by: David Marchand > --- > Changes since v2: > - added a runtime assert so that an application won't call those > experimental APIs, > > --- > lib/eal/include/rte_bitset.h | 132 +++++++++++++++++++++++++++++++++++ > 1 file changed, 132 insertions(+) > > diff --git a/lib/eal/include/rte_bitset.h b/lib/eal/include/rte_bitset.h > index 27b7a2e34d..116121eec4 100644 > --- a/lib/eal/include/rte_bitset.h > +++ b/lib/eal/include/rte_bitset.h > @@ -255,7 +255,13 @@ __rte_experimental > static inline bool > rte_bitset_test(const uint64_t *bitset, size_t bit_num) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __RTE_BITSET_DELEGATE(rte_bit_test, bitset, bit_num); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -277,7 +283,13 @@ __rte_experimental > static inline void > rte_bitset_set(uint64_t *bitset, size_t bit_num) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE(rte_bit_set, bitset, bit_num); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -299,7 +311,13 @@ __rte_experimental > static inline void > rte_bitset_clear(uint64_t *bitset, size_t bit_num) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE(rte_bit_clear, bitset, bit_num); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -323,7 +341,14 @@ __rte_experimental > static inline void > rte_bitset_assign(uint64_t *bitset, size_t bit_num, bool bit_value) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE_N(rte_bit_assign, bitset, bit_num, bit_value); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(bit_value); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -345,7 +370,13 @@ __rte_experimental > static inline void > rte_bitset_flip(uint64_t *bitset, size_t bit_num) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE(rte_bit_flip, bitset, bit_num); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -370,7 +401,14 @@ __rte_experimental > static inline bool > rte_bitset_atomic_test(const uint64_t *bitset, size_t bit_num, int memory_order) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __RTE_BITSET_DELEGATE_N(rte_bit_atomic_test, bitset, bit_num, memory_order); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(memory_order); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -399,7 +437,14 @@ __rte_experimental > static inline void > rte_bitset_atomic_set(uint64_t *bitset, size_t bit_num, int memory_order) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE_N(rte_bit_atomic_set, bitset, bit_num, memory_order); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(memory_order); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -428,7 +473,14 @@ __rte_experimental > static inline void > rte_bitset_atomic_clear(uint64_t *bitset, size_t bit_num, int memory_order) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE_N(rte_bit_atomic_clear, bitset, bit_num, memory_order); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(memory_order); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -459,7 +511,15 @@ __rte_experimental > static inline void > rte_bitset_atomic_assign(uint64_t *bitset, size_t bit_num, bool bit_value, int memory_order) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE_N(rte_bit_atomic_assign, bitset, bit_num, bit_value, memory_order); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(bit_value); > + RTE_SET_USED(memory_order); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -488,7 +548,14 @@ __rte_experimental > static inline void > rte_bitset_atomic_flip(uint64_t *bitset, size_t bit_num, int memory_order) > { > +#ifdef ALLOW_EXPERIMENTAL_API > __RTE_BITSET_DELEGATE_N(rte_bit_atomic_flip, bitset, bit_num, memory_order); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(bit_num); > + RTE_SET_USED(memory_order); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -524,7 +591,13 @@ __rte_experimental > static inline void > rte_bitset_clear_all(uint64_t *bitset, size_t size) > { > +#ifdef ALLOW_EXPERIMENTAL_API > rte_bitset_init(bitset, size); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -576,7 +649,13 @@ __rte_experimental > static inline size_t > rte_bitset_count_clear(const uint64_t *bitset, size_t size) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return size - rte_bitset_count_set(bitset, size); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_VERIFY(false); > +#endif > } > > #define __RTE_BITSET_FIND_FLAG_FIND_CLEAR (1U << 0) > @@ -635,6 +714,7 @@ static inline ssize_t > __rte_bitset_find(const uint64_t *bitset, size_t size, size_t start_bit, size_t len, > unsigned int flags) > { > +#ifdef ALLOW_EXPERIMENTAL_API > bool find_clear = flags & __RTE_BITSET_FIND_FLAG_FIND_CLEAR; > bool may_wrap = flags & __RTE_BITSET_FIND_FLAG_WRAP; > bool does_wrap = (start_bit + len) > size; > @@ -655,6 +735,14 @@ __rte_bitset_find(const uint64_t *bitset, size_t size, size_t start_bit, size_t > rc = __rte_bitset_find_nowrap(bitset, size, start_bit, len, find_clear); > > return rc; > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_SET_USED(start_bit); > + RTE_SET_USED(len); > + RTE_SET_USED(flags); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -678,7 +766,13 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_first_set(const uint64_t *bitset, size_t size) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, 0, size, 0); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -708,7 +802,15 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_set(const uint64_t *bitset, size_t size, size_t start_bit, size_t len) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, start_bit, len, 0); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_SET_USED(start_bit); > + RTE_SET_USED(len); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -739,7 +841,15 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_set_wrap(const uint64_t *bitset, size_t size, size_t start_bit, size_t len) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, start_bit, len, __RTE_BITSET_FIND_FLAG_WRAP); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_SET_USED(start_bit); > + RTE_SET_USED(len); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -763,7 +873,13 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_first_clear(const uint64_t *bitset, size_t size) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, 0, size, __RTE_BITSET_FIND_FLAG_FIND_CLEAR); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -793,7 +909,15 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_clear(const uint64_t *bitset, size_t size, size_t start_bit, size_t len) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, start_bit, len, __RTE_BITSET_FIND_FLAG_FIND_CLEAR); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_SET_USED(start_bit); > + RTE_SET_USED(len); > + RTE_VERIFY(false); > +#endif > } > > /** > @@ -824,8 +948,16 @@ __rte_experimental > static inline ssize_t > rte_bitset_find_clear_wrap(const uint64_t *bitset, size_t size, size_t start_bit, size_t len) > { > +#ifdef ALLOW_EXPERIMENTAL_API > return __rte_bitset_find(bitset, size, start_bit, len, > __RTE_BITSET_FIND_FLAG_FIND_CLEAR | __RTE_BITSET_FIND_FLAG_WRAP); > +#else > + RTE_SET_USED(bitset); > + RTE_SET_USED(size); > + RTE_SET_USED(start_bit); > + RTE_SET_USED(len); > + RTE_VERIFY(false); > +#endif > } > > /** Reviewed-by: Mattias Rönnblom